You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "JiajunBernoulli (via GitHub)" <gi...@apache.org> on 2023/08/06 05:40:23 UTC
[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3289: [CALCITE-5813] Type inference for sql functions REPEAT, SPACE, XML_TRANSFORM, and XML_EXTRACT is incorrect
JiajunBernoulli commented on code in PR #3289:
URL: https://github.com/apache/calcite/pull/3289#discussion_r1285155403
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -224,6 +224,62 @@ private static boolean skipItem(RexNode expr) {
&& "item".equalsIgnoreCase(((RexCall) expr).getOperator().getName());
}
+ /**
+ * Test case for <a href="https://issues.apache.org/jira/browse/CALCITE-5813">[CALCITE-5813]
+ * Type inference for REPEAT sql function is incorrect</a>. */
Review Comment:
Type inference for sql functions REPEAT, SPACE, XML_TRANSFORM, and XML_EXTRACT is incorrect
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -224,6 +224,62 @@ private static boolean skipItem(RexNode expr) {
&& "item".equalsIgnoreCase(((RexCall) expr).getOperator().getName());
}
+ /**
+ * Test case for <a href="https://issues.apache.org/jira/browse/CALCITE-5813">[CALCITE-5813]
+ * Type inference for REPEAT sql function is incorrect</a>. */
Review Comment:
Type inference for sql functions REPEAT, SPACE, XML_TRANSFORM, and XML_EXTRACT is incorrect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org