You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/10/13 06:50:16 UTC

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8271


Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................

[consensus] do not call EnableFailureDetector twice

This minor clean-up removes second call to EnableFailureDetector()
upon starting the Raft consensus state machine.

Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
2 files changed, 11 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/8271/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8271 )

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.cc@582
PS2, Line 582:   EnableFailureDetector(std::move(fd_delta));
> I thought in that case it's set to minimum election timeout, and that's exa
Ah yes, you're right. I don't know why the test is failing then.



-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Fri, 13 Oct 2017 22:55:29 +0000
Gerrit-HasComments: Yes

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/8271 )

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8271 )

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.h
File src/kudu/consensus/raft_consensus.h:

http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.h@a553
PS2, Line 553: 
> Why remove this comment?
My mistake, I'll return it back.


http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.cc@582
PS2, Line 582:   EnableFailureDetector(std::move(fd_delta));
> If fd_delta is boost::none, won't that mean we'll configure the FD to expir
I thought in that case it's set to minimum election timeout, and that's exactly like it was before this change.  Not sure that's the reason behind failures of the RaftConsensusITest.TestLargeBatches test in TSAN builds.



-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Fri, 13 Oct 2017 22:18:46 +0000
Gerrit-HasComments: Yes

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8271 )

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8271/5/src/kudu/consensus/raft_consensus.h
File src/kudu/consensus/raft_consensus.h:

http://gerrit.cloudera.org:8080/#/c/8271/5/src/kudu/consensus/raft_consensus.h@558
PS5, Line 558: delta
> I don't know why clang-tidy didn't catch this but this should be fd_delta s
nope, that should be delta, and it corresponds to the notation in the *.cc file.



-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Mon, 16 Oct 2017 17:58:26 +0000
Gerrit-HasComments: Yes

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8271 )

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8271/5/src/kudu/consensus/raft_consensus.h
File src/kudu/consensus/raft_consensus.h:

http://gerrit.cloudera.org:8080/#/c/8271/5/src/kudu/consensus/raft_consensus.h@558
PS5, Line 558: delta
I don't know why clang-tidy didn't catch this but this should be fd_delta since that's what it's called in the .cc file



-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Mon, 16 Oct 2017 05:00:50 +0000
Gerrit-HasComments: Yes

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8271 )

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.h
File src/kudu/consensus/raft_consensus.h:

http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.h@a553
PS2, Line 553: 
Why remove this comment?


http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.cc@582
PS2, Line 582:   EnableFailureDetector(std::move(fd_delta));
If fd_delta is boost::none, won't that mean we'll configure the FD to expire immediately? Maybe that's why one of the raft_consensus-itest instances is failing?



-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Fri, 13 Oct 2017 21:35:36 +0000
Gerrit-HasComments: Yes

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8271 )

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................


Patch Set 2: Code-Review+1

It doesn't look like the failure is related.


-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Sun, 15 Oct 2017 02:06:59 +0000
Gerrit-HasComments: No

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8271

to look at the new patch set (#5).

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................

[consensus] do not call EnableFailureDetector twice

This minor clean-up removes second call to EnableFailureDetector()
upon starting the Raft consensus state machine.

Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
2 files changed, 11 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/8271/5
-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8271 )

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

http://gerrit.cloudera.org:8080/#/c/8271/2/src/kudu/consensus/raft_consensus.cc@582
PS2, Line 582:   EnableFailureDetector(std::move(fd_delta));
> Ah yes, you're right. I don't know why the test is failing then.
It seems that was due to out-of-memory errors in TSAN mode due to recent changes.  Todd already posted a patch to flush 'shadow' TSAN memory every 10 seconds, which makes fixed the issue.



-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Sun, 15 Oct 2017 05:56:34 +0000
Gerrit-HasComments: Yes

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8271 )

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8271/1/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

http://gerrit.cloudera.org:8080/#/c/8271/1/src/kudu/consensus/raft_consensus.cc@582
PS1, Line 582:   EnableFailureDetector(std::move(fd_delta));
> warning: parameter 'fd_delta' is passed by value and only copied once; cons
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Fri, 13 Oct 2017 15:15:51 +0000
Gerrit-HasComments: Yes

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8271

to look at the new patch set (#2).

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................

[consensus] do not call EnableFailureDetector twice

This minor clean-up removes second call to EnableFailureDetector()
upon starting the Raft consensus state machine.

Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
2 files changed, 11 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/8271/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8271 )

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................


Patch Set 6: Verified+1

Unrelated flake in ClientStressTest.TestUniqueClientIds


-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Mon, 16 Oct 2017 21:50:27 +0000
Gerrit-HasComments: No

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8271 )

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................

[consensus] do not call EnableFailureDetector twice

This minor clean-up removes second call to EnableFailureDetector()
upon starting the Raft consensus state machine.

Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Reviewed-on: http://gerrit.cloudera.org:8080/8271
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
2 files changed, 11 insertions(+), 13 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8271

to look at the new patch set (#4).

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................

[consensus] do not call EnableFailureDetector twice

This minor clean-up removes second call to EnableFailureDetector()
upon starting the Raft consensus state machine.

Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
2 files changed, 11 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/8271/4
-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8271 )

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8271/5/src/kudu/consensus/raft_consensus.h
File src/kudu/consensus/raft_consensus.h:

http://gerrit.cloudera.org:8080/#/c/8271/5/src/kudu/consensus/raft_consensus.h@554
PS5, Line 554:   // If 'fd_delta' is set, it is used as the initial period for leader failure
L558 calls the parameter 'delta', not 'fd_delta'.



-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Mon, 16 Oct 2017 19:48:02 +0000
Gerrit-HasComments: Yes

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8271 )

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Mon, 16 Oct 2017 21:45:08 +0000
Gerrit-HasComments: No

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8271

to look at the new patch set (#6).

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................

[consensus] do not call EnableFailureDetector twice

This minor clean-up removes second call to EnableFailureDetector()
upon starting the Raft consensus state machine.

Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
2 files changed, 11 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/8271/6
-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [consensus] do not call EnableFailureDetector twice

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8271 )

Change subject: [consensus] do not call EnableFailureDetector twice
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8271/5/src/kudu/consensus/raft_consensus.h
File src/kudu/consensus/raft_consensus.h:

http://gerrit.cloudera.org:8080/#/c/8271/5/src/kudu/consensus/raft_consensus.h@554
PS5, Line 554:   // If 'fd_delta' is set, it is used as the initial period for leader failure
> L558 calls the parameter 'delta', not 'fd_delta'.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87dac245b20d85dcda991ea02b51d6ee0fe41822
Gerrit-Change-Number: 8271
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Mon, 16 Oct 2017 21:01:16 +0000
Gerrit-HasComments: Yes