You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "eirikbakke (via GitHub)" <gi...@apache.org> on 2024/06/13 21:23:22 UTC
[PR] MacOS: Make SVG/HiDPI icons work in the main menu bar [netbeans]
eirikbakke opened a new pull request, #7477:
URL: https://github.com/apache/netbeans/pull/7477
Adjust the Icon implementation in ImageUtilities to make SVG/HiDPI icons work in the MacOS menu bar.
The effect can be seen e.g. for the Undo and Redo actions in the Edit menu, which have SVG icons present. Some more menu actions will have SVG icons once https://github.com/apache/netbeans/pull/7463 is merged.
(I'd upload a screenshot here but I don't have a Mac available at the moment. I have tested the patch on MacOS many times in the last 6 months, though.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] MacOS: Make SVG/HiDPI icons work in the main menu bar [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #7477:
URL: https://github.com/apache/netbeans/pull/7477#issuecomment-2232976334
@mbien this is still marked as requesting changes from you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] MacOS: Make SVG/HiDPI icons work in the main menu bar [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7477:
URL: https://github.com/apache/netbeans/pull/7477#issuecomment-2233335751
done, I thought dismiss review would delete everything i said, but all it does is to remove the red marker. So I always pressed the re-request review button to get rid of the red marker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] MacOS: Make SVG/HiDPI icons work in the main menu bar [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7477:
URL: https://github.com/apache/netbeans/pull/7477#discussion_r1639946278
##########
platform/openide.util.ui/nbproject/project.properties:
##########
@@ -16,8 +16,8 @@
# under the License.
javac.compilerargs=-Xlint -Xlint:-serial -Xlint:-processing
-javac.source=1.8
-javac.target=1.8
+javac.source=1.9
+javac.target=1.9
Review Comment:
https://github.com/apache/netbeans/issues/4904 is currently preventing to bump the module to >8
some tests which depend on this module fail on JDK 11.
but lets say the remaining tests would be fixed or disabled by someone:
- change this to `javac.relese=11`
- and remove the `OpenIDE-Module-Java-Dependencies` manifest entry again since it is automatically added now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] MacOS: Make SVG/HiDPI icons work in the main menu bar [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #7477:
URL: https://github.com/apache/netbeans/pull/7477#issuecomment-2166881466
I see a test failing called "NetBeans / APISupport Modules on Linux/JDK 8 (pull_request)". Is the openide.util.ui module (which contains ImageUtilities) required to work with Java 8? In that case this patch can't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] MacOS: Make SVG/HiDPI icons work in the main menu bar [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke merged PR #7477:
URL: https://github.com/apache/netbeans/pull/7477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] MacOS: Make SVG/HiDPI icons work in the main menu bar [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #7477:
URL: https://github.com/apache/netbeans/pull/7477#issuecomment-2233415137
Thanks!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] MacOS: Make SVG/HiDPI icons work in the main menu bar [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7477:
URL: https://github.com/apache/netbeans/pull/7477#discussion_r1639946278
##########
platform/openide.util.ui/nbproject/project.properties:
##########
@@ -16,8 +16,8 @@
# under the License.
javac.compilerargs=-Xlint -Xlint:-serial -Xlint:-processing
-javac.source=1.8
-javac.target=1.8
+javac.source=1.9
+javac.target=1.9
Review Comment:
https://github.com/apache/netbeans/issues/4904 is currently preventing to bump the module to >8
some tests which depend on this module fail on JDK 11.
but lets say the remaining tests would be fixed or disabled by someone:
- change this to `javac.relese=11`
- and remove the `OpenIDE-Module-Java-Dependencies` manifest entry gain since it is automatically added now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] MacOS: Make SVG/HiDPI icons work in the main menu bar [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #7477:
URL: https://github.com/apache/netbeans/pull/7477#issuecomment-2233303103
@mbien you should be able to dismiss the review then if you don't want to switch to approve.
@eirikbakke over to you to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] MacOS: Make SVG/HiDPI icons work in the main menu bar [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7477:
URL: https://github.com/apache/netbeans/pull/7477#issuecomment-2233287234
@neilcsmith-net nope, I marked the two points I commented on as resolved - all good from my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists