You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/01 18:30:21 UTC
[GitHub] [incubator-superset] simchaNielsen opened a new pull request #11880: feat: Support multiple queries per request
simchaNielsen opened a new pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880
### SUMMARY
This feat give opportunity to get from BE response multiple query results and pass them to Chart plugins
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Network Response:
<img width="459" alt="Screen Shot 2020-12-01 at 20 27 41" src="https://user-images.githubusercontent.com/56388545/100781461-bc1d6c80-3413-11eb-9b5a-5dbde1d77176.png">
Results in chart plugin before:
Results in chart plugin after:
### TEST PLAN
Build request with multiple queries
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (a4b2a75) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `2.94%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.85% -2.95%
==========================================
Files 924 461 -463
Lines 44837 28353 -16484
Branches 4253 0 -4253
==========================================
- Hits 29951 18104 -11847
+ Misses 14777 10249 -4528
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.85% <ø> (-0.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.98% <0.00%> (-2.97%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.25% <0.00%> (-2.81%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.21% <0.00%> (-2.57%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.60% <0.00%> (-1.87%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [460 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...a4b2a75](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (efd98fb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `2.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.96% -2.84%
==========================================
Files 924 461 -463
Lines 44837 28380 -16457
Branches 4253 0 -4253
==========================================
- Hits 29951 18152 -11799
+ Misses 14777 10228 -4549
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.96% <ø> (-0.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.59% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.36% <0.00%> (-0.41%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.67% <0.00%> (-0.27%)` | :arrow_down: |
| ... and [459 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...efd98fb](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-737435500
What's still unclear to me are the proposed backend changes to support multiple queries, and how that will affect the async query feature, which will be coming out of draft status this week.
- Which endpoints will support multiple queries? `/api/v1/chart/data`? `/superset/explore_json`?
- What changes will be made in `QueryContext` and `viz.py` to support this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (8428c07) into [master](https://codecov.io/gh/apache/incubator-superset/commit/022d7556401750c6bc28a081a6780fce2f4033fd?el=desc) (022d755) will **decrease** coverage by `3.16%`.
> The diff coverage is `47.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.66% 63.49% -3.17%
==========================================
Files 951 951
Lines 46663 46661 -2
Branches 4571 4576 +5
==========================================
- Hits 31106 29626 -1480
- Misses 15421 16851 +1430
- Partials 136 184 +48
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.62% <47.50%> (-0.04%)` | :arrow_down: |
| python | `64.01% <ø> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.71% <0.00%> (-45.65%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `39.72% <0.00%> (-35.62%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `25.00% <ø> (-33.34%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.97% <0.00%> (-50.67%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <ø> (-2.95%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `13.63% <ø> (-63.64%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `93.33% <ø> (-6.67%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.77% <91.66%> (-23.19%)` | :arrow_down: |
| ... and [157 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [022d755...8428c07](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (b6f4fe1) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `2.89%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.90% -2.90%
==========================================
Files 924 461 -463
Lines 44837 28380 -16457
Branches 4253 0 -4253
==========================================
- Hits 29951 18136 -11815
+ Misses 14777 10244 -4533
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.90% <ø> (-0.26%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.87% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.59% <0.00%> (-0.61%)` | :arrow_down: |
| ... and [461 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...b6f4fe1](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (0d8b758) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **increase** coverage by `0.23%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 63.37% 63.60% +0.23%
==========================================
Files 970 481 -489
Lines 47937 29682 -18255
Branches 4736 0 -4736
==========================================
- Hits 30380 18880 -11500
+ Misses 17370 10802 -6568
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.60% <ø> (-0.55%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.37% <0.00%> (-0.08%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | | |
| ... and [475 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...0d8b758](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] amitmiran137 commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534262315
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -171,11 +171,18 @@ class SliceHeaderControls extends React.PureComponent {
addDangerToast,
isFullSize,
} = this.props;
- const cachedWhen = moment.utc(cachedDttm).fromNow();
+ const cachedWhen = cachedDttm.map(itemCachedDttm =>
+ moment.utc(itemCachedDttm).fromNow(),
+ );
const updatedWhen = updatedDttm ? moment.utc(updatedDttm).fromNow() : '';
- const refreshTooltip = isCached
- ? t('Cached %s', cachedWhen)
- : (updatedWhen && t('Fetched %s', updatedWhen)) || '';
+ const getCachedTitle = itemCached => {
+ return itemCached
+ ? t('Cached %s', cachedWhen)
+ : updatedWhen && t('Fetched %s', updatedWhen);
+ };
+ let refreshTooltip = isCached.map(getCachedTitle) || '';
+ // If all queries have same cache time we can unit them to one
+ refreshTooltip = [...new Set(refreshTooltip)].join(', ');
Review comment:
@simchaNielsen
could you share the new screenshot?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534861251
##########
File path: superset-frontend/src/chart/chartAction.js
##########
@@ -360,28 +360,33 @@ export function exploreJSON(
// problem: response holds a list of results, when before we were just getting one result.
// How to make the entire app compatible with multiple results?
// For now just use the first result.
- const result = response.result[0];
+ const queryResponse = response.result[0]; // deprecated
+ const queriesResponse = response.result;
- dispatch(
- logEvent(LOG_ACTIONS_LOAD_CHART, {
- slice_id: key,
- applied_filters: result.applied_filters,
- is_cached: result.is_cached,
- force_refresh: force,
- row_count: result.rowcount,
- datasource: formData.datasource,
- start_offset: logStart,
- ts: new Date().getTime(),
- duration: Logger.getTimestamp() - logStart,
- has_extra_filters:
- formData.extra_filters && formData.extra_filters.length > 0,
- viz_type: formData.viz_type,
- data_age: result.is_cached
- ? moment(new Date()).diff(moment.utc(result.cached_dttm))
- : null,
- }),
+ queriesResponse.forEach(resultItem =>
+ dispatch(
+ logEvent(LOG_ACTIONS_LOAD_CHART, {
+ slice_id: key,
+ applied_filters: resultItem.applied_filters,
+ is_cached: resultItem.is_cached,
+ force_refresh: force,
+ row_count: resultItem.rowcount,
+ datasource: formData.datasource,
+ start_offset: logStart,
+ ts: new Date().getTime(),
+ duration: Logger.getTimestamp() - logStart,
+ has_extra_filters:
+ formData.extra_filters && formData.extra_filters.length > 0,
+ viz_type: formData.viz_type,
+ data_age: resultItem.is_cached
+ ? moment(new Date()).diff(moment.utc(resultItem.cached_dttm))
+ : null,
+ }),
+ ),
+ );
+ return dispatch(
+ chartUpdateSucceeded(queryResponse, queriesResponse, key),
Review comment:
@robdiciuccio hmm... good point, actually I wanted avoid refactoring of a lot places in code, but now I see I think I can handle it, I also will add someone more to review, where I see that my refactor will affect his parts of code to be sure. I tests these changes in explore/dashboard in areas that I know, but if there are some other places, that I need to test please update me.
I pushed now refactored code as you proposed and asked @etr2460 to review also...
I also see that affected some code that @suddjian implemented, may be it can be good to add him as reviewer?
Thanks
##########
File path: superset-frontend/src/chart/chartAction.js
##########
@@ -360,28 +360,33 @@ export function exploreJSON(
// problem: response holds a list of results, when before we were just getting one result.
// How to make the entire app compatible with multiple results?
// For now just use the first result.
- const result = response.result[0];
+ const queryResponse = response.result[0]; // deprecated
+ const queriesResponse = response.result;
- dispatch(
- logEvent(LOG_ACTIONS_LOAD_CHART, {
- slice_id: key,
- applied_filters: result.applied_filters,
- is_cached: result.is_cached,
- force_refresh: force,
- row_count: result.rowcount,
- datasource: formData.datasource,
- start_offset: logStart,
- ts: new Date().getTime(),
- duration: Logger.getTimestamp() - logStart,
- has_extra_filters:
- formData.extra_filters && formData.extra_filters.length > 0,
- viz_type: formData.viz_type,
- data_age: result.is_cached
- ? moment(new Date()).diff(moment.utc(result.cached_dttm))
- : null,
- }),
+ queriesResponse.forEach(resultItem =>
+ dispatch(
+ logEvent(LOG_ACTIONS_LOAD_CHART, {
+ slice_id: key,
+ applied_filters: resultItem.applied_filters,
+ is_cached: resultItem.is_cached,
+ force_refresh: force,
+ row_count: resultItem.rowcount,
+ datasource: formData.datasource,
+ start_offset: logStart,
+ ts: new Date().getTime(),
+ duration: Logger.getTimestamp() - logStart,
+ has_extra_filters:
+ formData.extra_filters && formData.extra_filters.length > 0,
+ viz_type: formData.viz_type,
+ data_age: resultItem.is_cached
+ ? moment(new Date()).diff(moment.utc(resultItem.cached_dttm))
+ : null,
+ }),
+ ),
+ );
+ return dispatch(
+ chartUpdateSucceeded(queryResponse, queriesResponse, key),
Review comment:
@robdiciuccio hmm... good point, actually I wanted avoid refactoring of a lot places in code, but now I see I think I can handle it, I also will add someone more to review, where I see that my refactor will affect his parts of code to be sure. I tested these changes in explore/dashboard in areas that I know, but if there are some other places, that I need to test please update me.
I pushed now refactored code as you proposed and asked @etr2460 to review also...
I also see that affected some code that @suddjian implemented, may be it can be good to add him as reviewer?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (af13a23) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.13%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.66% -3.14%
==========================================
Files 924 927 +3
Lines 44837 44995 +158
Branches 4253 4309 +56
==========================================
- Hits 29951 28646 -1305
- Misses 14777 16171 +1394
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.15% <42.85%> (+0.11%)` | :arrow_up: |
| python | `63.96% <ø> (-0.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <0.00%> (-47.28%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `38.66% <0.00%> (-36.68%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `26.22% <ø> (-42.63%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `25.00% <ø> (-33.34%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `11.53% <0.00%> (-33.67%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.00% <ø> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <90.00%> (-22.30%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <100.00%> (-15.06%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [189 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...b6f4fe1](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534523366
##########
File path: superset-frontend/src/chart/Chart.jsx
##########
@@ -185,14 +179,14 @@ class Chart extends React.PureComponent {
errorMessage,
onQuery,
refreshOverlayVisible,
+ queriesResponse,
} = this.props;
const isLoading = chartStatus === 'loading';
-
const isFaded = refreshOverlayVisible && !errorMessage;
this.renderContainerStartTime = Logger.getTimestamp();
if (chartStatus === 'failed') {
- return this.renderErrorMessage();
+ return queriesResponse.map(item => this.renderErrorMessage(item));
Review comment:
Do you have a screenshot of multiple errors rendered in a chart?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (efd98fb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.27%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.52% -3.28%
==========================================
Files 924 461 -463
Lines 44837 28380 -16457
Branches 4253 0 -4253
==========================================
- Hits 29951 18028 -11923
+ Misses 14777 10352 -4425
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.52% <ø> (-0.64%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [463 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...efd98fb](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] amitmiran137 commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-737022289
And about async queries, once feature is mature we can consider supporting multiple queries there as well
But for now we not familiar with that feature
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (dc23d64) into [master](https://codecov.io/gh/apache/incubator-superset/commit/90ed3267e498f7c95a34f6703e534d69c9aed2db?el=desc) (90ed326) will **decrease** coverage by `2.56%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.58% 64.01% -2.57%
==========================================
Files 951 471 -480
Lines 46663 29028 -17635
Branches 4571 0 -4571
==========================================
- Hits 31070 18583 -12487
+ Misses 15456 10445 -5011
+ Partials 137 0 -137
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.01% <ø> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.62% <0.00%> (-0.14%)` | :arrow_down: |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | | |
| [...tend/src/dashboard/components/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | | |
| ... and [464 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [90ed326...dc23d64](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (80460ea) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 63.37% 63.38% +0.01%
==========================================
Files 970 481 -489
Lines 47937 29673 -18264
Branches 4736 0 -4736
==========================================
- Hits 30380 18809 -11571
+ Misses 17370 10864 -6506
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.38% <ø> (-0.77%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.73% <0.00%> (-6.87%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [486 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...80460ea](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (618fbaf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `6.07%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 60.72% -6.08%
==========================================
Files 924 881 -43
Lines 44837 43174 -1663
Branches 4253 3812 -441
==========================================
- Hits 29951 26218 -3733
- Misses 14777 16956 +2179
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.31% <88.88%> (+4.74%)` | :arrow_up: |
| javascript | `?` | |
| python | `64.06% <ø> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <0.00%> (ø)` | |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `59.01% <ø> (-9.84%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `58.33% <ø> (ø)` | |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `75.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `74.66% <100.00%> (-0.68%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `71.50% <100.00%> (-1.87%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `63.63% <100.00%> (+18.43%)` | :arrow_up: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `77.41% <100.00%> (-3.23%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [359 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...6267716](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (8428c07) into [master](https://codecov.io/gh/apache/incubator-superset/commit/022d7556401750c6bc28a081a6780fce2f4033fd?el=desc) (022d755) will **decrease** coverage by `2.64%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.66% 64.01% -2.65%
==========================================
Files 951 471 -480
Lines 46663 29028 -17635
Branches 4571 0 -4571
==========================================
- Hits 31106 18583 -12523
+ Misses 15421 10445 -4976
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.01% <ø> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.62% <0.00%> (-0.14%)` | :arrow_down: |
| [...perset-frontend/src/utils/DebouncedMessageQueue.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL0RlYm91bmNlZE1lc3NhZ2VRdWV1ZS5qcw==) | | |
| [...et-frontend/src/dashboard/util/isDashboardEmpty.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzRGFzaGJvYXJkRW1wdHkudHM=) | | |
| ... and [464 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [022d755...8428c07](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (dc23d64) into [master](https://codecov.io/gh/apache/incubator-superset/commit/90ed3267e498f7c95a34f6703e534d69c9aed2db?el=desc) (90ed326) will **decrease** coverage by `1.98%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.58% 64.59% -1.99%
==========================================
Files 951 471 -480
Lines 46663 29028 -17635
Branches 4571 0 -4571
==========================================
- Hits 31070 18751 -12319
+ Misses 15456 10277 -5179
+ Partials 137 0 -137
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.59% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/FlashProvider.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmxhc2hQcm92aWRlci50c3g=) | | |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | | |
| [...et-frontend/src/components/ConfirmStatusChange.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29uZmlybVN0YXR1c0NoYW5nZS50c3g=) | | |
| [...set-frontend/src/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uLmpzeA==) | | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | | |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | | |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | | |
| [superset-frontend/src/explore/AdhocFilter.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQWRob2NGaWx0ZXIuanM=) | | |
| [...rontend/src/visualizations/TimeTable/TimeTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9UaW1lVGFibGUuanN4) | | |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | | |
| ... and [456 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [90ed326...dc23d64](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (0d8b758) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **increase** coverage by `0.79%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 63.37% 64.17% +0.79%
==========================================
Files 970 481 -489
Lines 47937 29682 -18255
Branches 4736 0 -4736
==========================================
- Hits 30380 19048 -11332
+ Misses 17370 10634 -6736
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.17% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.37% <0.00%> (-0.08%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | | |
| [.../dashboard/util/logging/findNonTabChildChartIds.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZmluZE5vblRhYkNoaWxkQ2hhcnRJZHMuanM=) | | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | | |
| [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | | |
| [...et-frontend/src/dashboard/actions/dashboardInfo.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEluZm8uanM=) | | |
| [...erset-frontend/src/common/components/Tabs/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1RhYnMvaW5kZXgudHM=) | | |
| [...ntend/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEhlYWRlci5qc3g=) | | |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | | |
| [superset-frontend/src/components/Menu/NewMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9OZXdNZW51LnRzeA==) | | |
| ... and [467 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...0d8b758](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534158986
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -171,11 +171,18 @@ class SliceHeaderControls extends React.PureComponent {
addDangerToast,
isFullSize,
} = this.props;
- const cachedWhen = moment.utc(cachedDttm).fromNow();
+ const cachedWhen = cachedDttm.map(itemCachedDttm =>
+ moment.utc(itemCachedDttm).fromNow(),
+ );
const updatedWhen = updatedDttm ? moment.utc(updatedDttm).fromNow() : '';
- const refreshTooltip = isCached
- ? t('Cached %s', cachedWhen)
- : (updatedWhen && t('Fetched %s', updatedWhen)) || '';
+ const getCachedTitle = itemCached => {
+ return itemCached
+ ? t('Cached %s', cachedWhen)
+ : updatedWhen && t('Fetched %s', updatedWhen);
+ };
+ let refreshTooltip = isCached.map(getCachedTitle) || '';
+ // If all queries have same cache time we can unit them to one
+ refreshTooltip = [...new Set(refreshTooltip)].join(', ');
Review comment:
I wonder if we should instead have something like this for the case when there are more than one result:
```
Force refresh
Query 1: Fetched a minute ago
Query 2: Fetched 3 minutes ago
Query 3: Not cached
```
Also, we should think about how to display multiple results in the "View Results" tab. But that can wait; let's just make sure the user experience is unchanged for single queries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (6267716) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.11%`.
> The diff coverage is `46.15%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.68% -3.12%
==========================================
Files 924 927 +3
Lines 44837 45005 +168
Branches 4253 4309 +56
==========================================
- Hits 29951 28661 -1290
- Misses 14777 16166 +1389
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.16% <46.15%> (+0.13%)` | :arrow_up: |
| python | `63.98% <ø> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <0.00%> (-47.28%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `38.66% <0.00%> (-36.68%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `26.22% <ø> (-42.63%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `25.00% <ø> (-33.34%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `11.68% <0.00%> (-33.52%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.00% <ø> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <90.00%> (-22.30%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <100.00%> (-15.06%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [178 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...6267716](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (618fbaf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `2.73%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 64.06% -2.74%
==========================================
Files 924 461 -463
Lines 44837 28380 -16457
Branches 4253 0 -4253
==========================================
- Hits 29951 18181 -11770
+ Misses 14777 10199 -4578
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.06% <ø> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.14% <0.00%> (-0.81%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.59% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.31% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.49% <0.00%> (-0.27%)` | :arrow_down: |
| ... and [459 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...6267716](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (85a3aa5) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `11.88%`.
> The diff coverage is `74.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
===========================================
- Coverage 66.79% 54.91% -11.89%
===========================================
Files 924 420 -504
Lines 44837 14806 -30031
Branches 4253 3816 -437
===========================================
- Hits 29951 8130 -21821
+ Misses 14777 6676 -8101
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.91% <74.35%> (+5.33%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `57.14% <0.00%> (-1.04%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `59.01% <0.00%> (-9.84%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `58.33% <ø> (ø)` | |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.14% <ø> (+1.16%)` | :arrow_up: |
| [...nd/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `75.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `71.35% <75.00%> (-2.02%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `64.19% <92.30%> (+18.99%)` | :arrow_up: |
| ... and [812 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...85a3aa5](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: WIP: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534861251
##########
File path: superset-frontend/src/chart/chartAction.js
##########
@@ -360,28 +360,33 @@ export function exploreJSON(
// problem: response holds a list of results, when before we were just getting one result.
// How to make the entire app compatible with multiple results?
// For now just use the first result.
- const result = response.result[0];
+ const queryResponse = response.result[0]; // deprecated
+ const queriesResponse = response.result;
- dispatch(
- logEvent(LOG_ACTIONS_LOAD_CHART, {
- slice_id: key,
- applied_filters: result.applied_filters,
- is_cached: result.is_cached,
- force_refresh: force,
- row_count: result.rowcount,
- datasource: formData.datasource,
- start_offset: logStart,
- ts: new Date().getTime(),
- duration: Logger.getTimestamp() - logStart,
- has_extra_filters:
- formData.extra_filters && formData.extra_filters.length > 0,
- viz_type: formData.viz_type,
- data_age: result.is_cached
- ? moment(new Date()).diff(moment.utc(result.cached_dttm))
- : null,
- }),
+ queriesResponse.forEach(resultItem =>
+ dispatch(
+ logEvent(LOG_ACTIONS_LOAD_CHART, {
+ slice_id: key,
+ applied_filters: resultItem.applied_filters,
+ is_cached: resultItem.is_cached,
+ force_refresh: force,
+ row_count: resultItem.rowcount,
+ datasource: formData.datasource,
+ start_offset: logStart,
+ ts: new Date().getTime(),
+ duration: Logger.getTimestamp() - logStart,
+ has_extra_filters:
+ formData.extra_filters && formData.extra_filters.length > 0,
+ viz_type: formData.viz_type,
+ data_age: resultItem.is_cached
+ ? moment(new Date()).diff(moment.utc(resultItem.cached_dttm))
+ : null,
+ }),
+ ),
+ );
+ return dispatch(
+ chartUpdateSucceeded(queryResponse, queriesResponse, key),
Review comment:
hmm... good point, actually I wanted avoid refactor of a lot places in code, but now I see I hope I can handle it, I also will add some people to review, where I see my refactor affect there parts of code to be sure. I pushed now refactored code as you proposed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-737064842
@robdiciuccio based on my latest review of the async PR, I don't anticipate this feature will cause any complications with said feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (6267716) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.38%`.
> The diff coverage is `46.15%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.41% -3.39%
==========================================
Files 924 927 +3
Lines 44837 45005 +168
Branches 4253 4309 +56
==========================================
- Hits 29951 28539 -1412
- Misses 14777 16288 +1511
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.16% <46.15%> (+0.13%)` | :arrow_up: |
| python | `63.55% <ø> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <0.00%> (-47.28%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `38.66% <0.00%> (-36.68%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `26.22% <ø> (-42.63%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `25.00% <ø> (-33.34%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `11.68% <0.00%> (-33.52%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.00% <ø> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <90.00%> (-22.30%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <100.00%> (-15.06%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [181 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...6267716](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534704488
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -171,11 +171,18 @@ class SliceHeaderControls extends React.PureComponent {
addDangerToast,
isFullSize,
} = this.props;
- const cachedWhen = moment.utc(cachedDttm).fromNow();
+ const cachedWhen = cachedDttm.map(itemCachedDttm =>
+ moment.utc(itemCachedDttm).fromNow(),
+ );
const updatedWhen = updatedDttm ? moment.utc(updatedDttm).fromNow() : '';
- const refreshTooltip = isCached
- ? t('Cached %s', cachedWhen)
- : (updatedWhen && t('Fetched %s', updatedWhen)) || '';
+ const getCachedTitle = itemCached => {
+ return itemCached
+ ? t('Cached %s', cachedWhen)
+ : updatedWhen && t('Fetched %s', updatedWhen);
+ };
+ let refreshTooltip = isCached.map(getCachedTitle) || '';
+ // If all queries have same cache time we can unit them to one
+ refreshTooltip = [...new Set(refreshTooltip)].join(', ');
Review comment:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (dc23d64) into [master](https://codecov.io/gh/apache/incubator-superset/commit/90ed3267e498f7c95a34f6703e534d69c9aed2db?el=desc) (90ed326) will **decrease** coverage by `1.99%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.58% 64.59% -2.00%
==========================================
Files 951 471 -480
Lines 46663 29028 -17635
Branches 4571 0 -4571
==========================================
- Hits 31070 18750 -12320
+ Misses 15456 10278 -5178
+ Partials 137 0 -137
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.59% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset-frontend/src/common/components/Radio.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1JhZGlvLnRzeA==) | | |
| [...ews/CRUD/annotationlayers/AnnotationLayersList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJzTGlzdC50c3g=) | | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | | |
| [.../src/views/CRUD/alert/components/RecipientIcon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvY29tcG9uZW50cy9SZWNpcGllbnRJY29uLnRzeA==) | | |
| [superset-frontend/src/views/CRUD/data/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9ob29rcy50cw==) | | |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | | |
| [...nd/src/dashboard/components/FiltersBadge/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9pbmRleC50c3g=) | | |
| [superset-frontend/src/showSavedQuery/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Nob3dTYXZlZFF1ZXJ5L2luZGV4LmpzeA==) | | |
| [...rc/explore/components/controls/ViewportControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3cG9ydENvbnRyb2wuanN4) | | |
| ... and [457 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [90ed326...dc23d64](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] amitmiran137 commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r541584468
##########
File path: superset-frontend/src/chart/chartAction.js
##########
@@ -361,38 +361,36 @@ export function exploreJSON(
const chartDataRequestCaught = chartDataRequest
.then(response => {
+ const queriesResponse = response.result;
+
if (isFeatureEnabled(FeatureFlag.GLOBAL_ASYNC_QUERIES)) {
// deal with getChartDataRequest transforming the response data
const result = 'result' in response ? response.result[0] : response;
return dispatch(chartUpdateQueued(result, key));
Review comment:
@robdiciuccio should we continue sending a single result to chartUpdateQuered action?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (b6f4fe1) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.41%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.38% -3.42%
==========================================
Files 924 461 -463
Lines 44837 28365 -16472
Branches 4253 0 -4253
==========================================
- Hits 29951 17979 -11972
+ Misses 14777 10386 -4391
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.38% <ø> (-0.78%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.53% <0.00%> (-6.94%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.05% <0.00%> (-3.74%)` | :arrow_down: |
| ... and [478 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...b6f4fe1](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736906926
@simchaNielsen there's currently [a PR open](https://github.com/apache/incubator-superset/pull/11499) implementing async queries for charts (SIP-39) that I'm hoping to get merged in the next week or so. I'm curious how you see multiple queries working with this async model, and what changes you're proposing on the backend to support this.
Also curious, in general, what the use cases are for multiple queries in a visualization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r537818342
##########
File path: superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts
##########
@@ -132,12 +132,12 @@ export const selectIndicatorsForChart = (
// for now we only need to know which columns are compatible/incompatible,
// so grab the columns from the applied/rejected filters
const appliedColumns: Set<string> = new Set(
- (chart?.queryResponse?.applied_filters || []).map(
+ (chart?.queriesResponse?.[0]?.applied_filters || []).map(
Review comment:
I implemented this logic. The goal of these two lines is to get a set of all the filters that were applied on a chart, and the filters that were rejected (due to the column not existing in the dataset), in order to display them in the filter badge.
If a chart makes multiple queries, it would probably be more correct to add the `applied_filters` and `rejected_filters` from each of the queries, instead of just the first one. But that really depends on how dashboard filters works with multiple queries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (efd98fb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `2.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 64.12% -2.68%
==========================================
Files 924 461 -463
Lines 44837 28380 -16457
Branches 4253 0 -4253
==========================================
- Hits 29951 18198 -11753
+ Misses 14777 10182 -4595
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.12% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.59% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.49% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <0.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.78% <0.00%> (ø)` | |
| [superset/reports/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9hcGkucHk=) | `84.21% <0.00%> (ø)` | |
| ... and [455 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...efd98fb](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-747809315
Here are the changes necessary. Let me know if you'd like me to commit them to the PR.
<img width="765" alt="Screen Shot 2020-12-17 at 5 27 20 PM" src="https://user-images.githubusercontent.com/296227/102563012-39d8ad80-408d-11eb-8cab-18e2eaa6e0e4.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (197ba55) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **increase** coverage by `0.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 63.37% 63.57% +0.20%
==========================================
Files 970 481 -489
Lines 47937 29667 -18270
Branches 4736 0 -4736
==========================================
- Hits 30380 18862 -11518
+ Misses 17370 10805 -6565
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.57% <ø> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.68% <0.00%> (-0.47%)` | :arrow_down: |
| ... and [485 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...d6ffbf2](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (8428c07) into [master](https://codecov.io/gh/apache/incubator-superset/commit/022d7556401750c6bc28a081a6780fce2f4033fd?el=desc) (022d755) will **decrease** coverage by `2.68%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.66% 63.97% -2.69%
==========================================
Files 951 471 -480
Lines 46663 29013 -17650
Branches 4571 0 -4571
==========================================
- Hits 31106 18560 -12546
+ Misses 15421 10453 -4968
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.97% <ø> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.26% <0.00%> (-1.63%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.77% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [473 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [022d755...8428c07](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (197ba55) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **increase** coverage by `0.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 63.37% 63.61% +0.24%
==========================================
Files 970 481 -489
Lines 47937 29667 -18270
Branches 4736 0 -4736
==========================================
- Hits 30380 18873 -11507
+ Misses 17370 10794 -6576
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.61% <ø> (-0.54%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.36% <0.00%> (-0.15%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| ... and [482 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...d6ffbf2](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (efd98fb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.46% -3.34%
==========================================
Files 924 461 -463
Lines 44837 28380 -16457
Branches 4253 0 -4253
==========================================
- Hits 29951 18011 -11940
+ Misses 14777 10369 -4408
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.46% <ø> (-0.70%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [464 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...efd98fb](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (0d8b758) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **increase** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 63.37% 63.51% +0.14%
==========================================
Files 970 481 -489
Lines 47937 29680 -18257
Branches 4736 0 -4736
==========================================
- Hits 30380 18852 -11528
+ Misses 17370 10828 -6542
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.51% <ø> (-0.64%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [481 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...0d8b758](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (47a1293) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `2.81%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.98% -2.82%
==========================================
Files 924 461 -463
Lines 44837 28383 -16454
Branches 4253 0 -4253
==========================================
- Hits 29951 18161 -11790
+ Misses 14777 10222 -4555
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.98% <ø> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.59% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.67% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.62% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.68% <0.00%> (-0.10%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <0.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <0.00%> (ø)` | |
| ... and [451 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...47a1293](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534185852
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -171,11 +171,18 @@ class SliceHeaderControls extends React.PureComponent {
addDangerToast,
isFullSize,
} = this.props;
- const cachedWhen = moment.utc(cachedDttm).fromNow();
+ const cachedWhen = cachedDttm.map(itemCachedDttm =>
+ moment.utc(itemCachedDttm).fromNow(),
+ );
const updatedWhen = updatedDttm ? moment.utc(updatedDttm).fromNow() : '';
- const refreshTooltip = isCached
- ? t('Cached %s', cachedWhen)
- : (updatedWhen && t('Fetched %s', updatedWhen)) || '';
+ const getCachedTitle = itemCached => {
+ return itemCached
+ ? t('Cached %s', cachedWhen)
+ : updatedWhen && t('Fetched %s', updatedWhen);
+ };
+ let refreshTooltip = isCached.map(getCachedTitle) || '';
+ // If all queries have same cache time we can unit them to one
+ refreshTooltip = [...new Set(refreshTooltip)].join(', ');
Review comment:
1. updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (4e4238c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `11.84%`.
> The diff coverage is `89.28%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
===========================================
- Coverage 66.79% 54.95% -11.85%
===========================================
Files 924 420 -504
Lines 44837 14799 -30038
Branches 4253 3812 -441
===========================================
- Hits 29951 8133 -21818
+ Misses 14777 6666 -8111
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.95% <89.28%> (+5.38%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <0.00%> (ø)` | |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `59.01% <ø> (-9.84%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `58.33% <ø> (ø)` | |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `75.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `74.66% <100.00%> (-0.68%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `71.50% <100.00%> (-1.87%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `64.10% <100.00%> (+18.89%)` | :arrow_up: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `77.41% <100.00%> (-3.23%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [807 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...b6f4fe1](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (8428c07) into [master](https://codecov.io/gh/apache/incubator-superset/commit/022d7556401750c6bc28a081a6780fce2f4033fd?el=desc) (022d755) will **decrease** coverage by `3.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.66% 63.65% -3.01%
==========================================
Files 951 471 -480
Lines 46663 29013 -17650
Branches 4571 0 -4571
==========================================
- Hits 31106 18468 -12638
+ Misses 15421 10545 -4876
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.65% <ø> (-0.95%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [487 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [022d755...8428c07](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (a61c985) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **increase** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 63.37% 63.50% +0.13%
==========================================
Files 970 481 -489
Lines 47937 29658 -18279
Branches 4736 0 -4736
==========================================
- Hits 30380 18835 -11545
+ Misses 17370 10823 -6547
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.50% <ø> (-0.65%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [487 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...a61c985](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (efd98fb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.47% -3.33%
==========================================
Files 924 461 -463
Lines 44837 28365 -16472
Branches 4253 0 -4253
==========================================
- Hits 29951 18004 -11947
+ Misses 14777 10361 -4416
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.47% <ø> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [471 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...efd98fb](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534524589
##########
File path: superset-frontend/src/chart/chartAction.js
##########
@@ -360,28 +360,33 @@ export function exploreJSON(
// problem: response holds a list of results, when before we were just getting one result.
// How to make the entire app compatible with multiple results?
// For now just use the first result.
- const result = response.result[0];
+ const queryResponse = response.result[0]; // deprecated
+ const queriesResponse = response.result;
- dispatch(
- logEvent(LOG_ACTIONS_LOAD_CHART, {
- slice_id: key,
- applied_filters: result.applied_filters,
- is_cached: result.is_cached,
- force_refresh: force,
- row_count: result.rowcount,
- datasource: formData.datasource,
- start_offset: logStart,
- ts: new Date().getTime(),
- duration: Logger.getTimestamp() - logStart,
- has_extra_filters:
- formData.extra_filters && formData.extra_filters.length > 0,
- viz_type: formData.viz_type,
- data_age: result.is_cached
- ? moment(new Date()).diff(moment.utc(result.cached_dttm))
- : null,
- }),
+ queriesResponse.forEach(resultItem =>
+ dispatch(
+ logEvent(LOG_ACTIONS_LOAD_CHART, {
+ slice_id: key,
+ applied_filters: resultItem.applied_filters,
+ is_cached: resultItem.is_cached,
+ force_refresh: force,
+ row_count: resultItem.rowcount,
+ datasource: formData.datasource,
+ start_offset: logStart,
+ ts: new Date().getTime(),
+ duration: Logger.getTimestamp() - logStart,
+ has_extra_filters:
+ formData.extra_filters && formData.extra_filters.length > 0,
+ viz_type: formData.viz_type,
+ data_age: resultItem.is_cached
+ ? moment(new Date()).diff(moment.utc(resultItem.cached_dttm))
+ : null,
+ }),
+ ),
+ );
+ return dispatch(
+ chartUpdateSucceeded(queryResponse, queriesResponse, key),
Review comment:
What's the thinking behind adding another value here rather than replacing the current `queryResponse`? This is essentially doubling the data that's being passed around to components.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: WIP: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534780130
##########
File path: superset-frontend/src/chart/Chart.jsx
##########
@@ -185,14 +179,14 @@ class Chart extends React.PureComponent {
errorMessage,
onQuery,
refreshOverlayVisible,
+ queriesResponse,
} = this.props;
const isLoading = chartStatus === 'loading';
-
const isFaded = refreshOverlayVisible && !errorMessage;
this.renderContainerStartTime = Logger.getTimestamp();
if (chartStatus === 'failed') {
- return this.renderErrorMessage();
+ return queriesResponse.map(item => this.renderErrorMessage(item));
Review comment:
Hi good catch, I didn't check it properly for all kinds of charts (new/old). I pushed now some small fix for it. Basically for now for new api there is no case that it returns more than 1 error per request even for multi queries, but if it will return we can support it, but for now it will be only one row.
Attaching screenshots after my fix for charts:
1. Old charts:
2. New charts:
3. New charts with multiqueries (looks the same):
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: WIP: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (47a1293) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.21% -3.59%
==========================================
Files 924 461 -463
Lines 44837 28368 -16469
Branches 4253 0 -4253
==========================================
- Hits 29951 17933 -12018
+ Misses 14777 10435 -4342
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.21% <ø> (-0.95%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `83.67% <0.00%> (-5.31%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [475 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...47a1293](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-747805749
Running this locally with the `GLOBAL_ASYNC_QUERIES` feature flag enabled results in the following error when rendering a dashboard:
```
TypeError: Cannot read property 'call' of undefined
at Chart.render (Chart.jsx?484f:272)
```
Also:
```
Warning: Failed prop type: Invalid prop `charts.597.queriesResponse` of type `object` supplied to `Dashboard`, expected an array.
Warning: Failed prop type: Invalid prop `chart.queriesResponse` of type `object` supplied to `Chart`, expected an array.
```
Looking into the cause.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] amitmiran137 commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-742669070
Can this be merged?
or those wait for additional review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534151585
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -171,11 +171,18 @@ class SliceHeaderControls extends React.PureComponent {
addDangerToast,
isFullSize,
} = this.props;
- const cachedWhen = moment.utc(cachedDttm).fromNow();
+ const cachedWhen = cachedDttm.map(itemCachedDttm =>
+ moment.utc(itemCachedDttm).fromNow(),
+ );
const updatedWhen = updatedDttm ? moment.utc(updatedDttm).fromNow() : '';
- const refreshTooltip = isCached
- ? t('Cached %s', cachedWhen)
- : (updatedWhen && t('Fetched %s', updatedWhen)) || '';
+ const getCachedTitle = itemCached => {
+ return itemCached
+ ? t('Cached %s', cachedWhen)
+ : updatedWhen && t('Fetched %s', updatedWhen);
+ };
+ let refreshTooltip = isCached.map(getCachedTitle) || '';
+ // If all queries have same cache time we can unit them to one
+ refreshTooltip = [...new Set(refreshTooltip)].join(', ');
Review comment:
@villebro So basically if all requests will have same time it will look like"
And if different then like this:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (6267716) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.01%`.
> The diff coverage is `46.15%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.78% -3.02%
==========================================
Files 924 927 +3
Lines 44837 45005 +168
Branches 4253 4309 +56
==========================================
- Hits 29951 28707 -1244
- Misses 14777 16120 +1343
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.16% <46.15%> (+0.13%)` | :arrow_up: |
| python | `64.15% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <0.00%> (-47.28%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `38.66% <0.00%> (-36.68%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `26.22% <ø> (-42.63%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `25.00% <ø> (-33.34%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `11.68% <0.00%> (-33.52%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.00% <ø> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <90.00%> (-22.30%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <100.00%> (-15.06%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [173 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...6267716](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (8428c07) into [master](https://codecov.io/gh/apache/incubator-superset/commit/022d7556401750c6bc28a081a6780fce2f4033fd?el=desc) (022d755) will **decrease** coverage by `2.80%`.
> The diff coverage is `47.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.66% 63.85% -2.81%
==========================================
Files 951 951
Lines 46663 46661 -2
Branches 4571 4576 +5
==========================================
- Hits 31106 29794 -1312
- Misses 15421 16683 +1262
- Partials 136 184 +48
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.62% <47.50%> (-0.04%)` | :arrow_down: |
| python | `64.59% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.71% <0.00%> (-45.65%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `39.72% <0.00%> (-35.62%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `25.00% <ø> (-33.34%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.97% <0.00%> (-50.67%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <ø> (-2.95%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `13.63% <ø> (-63.64%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `93.33% <ø> (-6.67%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.77% <91.66%> (-23.19%)` | :arrow_down: |
| ... and [149 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [022d755...8428c07](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (8428c07) into [master](https://codecov.io/gh/apache/incubator-superset/commit/022d7556401750c6bc28a081a6780fce2f4033fd?el=desc) (022d755) will **increase** coverage by `0.97%`.
> The diff coverage is `85.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 66.66% 67.63% +0.97%
==========================================
Files 951 951
Lines 46663 46675 +12
Branches 4571 4576 +5
==========================================
+ Hits 31106 31568 +462
+ Misses 15421 14990 -431
+ Partials 136 117 -19
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.73% <74.35%> (+6.62%)` | :arrow_up: |
| javascript | `62.62% <47.50%> (-0.04%)` | :arrow_down: |
| python | `64.59% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `57.14% <0.00%> (+0.77%)` | :arrow_up: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `58.33% <ø> (ø)` | |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `75.00% <ø> (+25.00%)` | :arrow_up: |
| [...nd/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `77.27% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `100.00% <ø> (ø)` | |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `63.41% <85.71%> (+1.77%)` | :arrow_up: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.34% <100.00%> (ø)` | |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.23% <100.00%> (+4.28%)` | :arrow_up: |
| ... and [77 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [022d755...8428c07](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: WIP: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534869980
##########
File path: superset-frontend/src/chart/chartReducer.js
##########
@@ -89,13 +89,13 @@ export default function chartReducer(charts = {}, action) {
return {
...state,
chartStatus: 'failed',
- chartAlert: action.queryResponse
- ? action.queryResponse.error
+ chartAlert: action.queriesResponse
+ ? action.queriesResponse?.[0]?.error
: t('Network error.'),
chartUpdateEndTime: now(),
- queryResponse: action.queryResponse,
- chartStackTrace: action.queryResponse
- ? action.queryResponse.stacktrace
+ queriesResponse: action.queriesResponse,
+ chartStackTrace: action.queriesResponse
Review comment:
@etr2460 and also this one please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (47a1293) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `2.65%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 64.14% -2.66%
==========================================
Files 924 461 -463
Lines 44837 28383 -16454
Branches 4253 0 -4253
==========================================
- Hits 29951 18207 -11744
+ Misses 14777 10176 -4601
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.14% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.59% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.68% <0.00%> (-0.10%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <0.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <0.00%> (ø)` | |
| [superset/reports/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9hcGkucHk=) | `84.21% <0.00%> (ø)` | |
| [...ns/978245563a02\_migrate\_iframe\_to\_dash\_markdown.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy85NzgyNDU1NjNhMDJfbWlncmF0ZV9pZnJhbWVfdG9fZGFzaF9tYXJrZG93bi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | | |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | | |
| [...t-frontend/src/SqlLab/components/ColumnElement.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQudHN4) | | |
| ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...47a1293](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (8428c07) into [master](https://codecov.io/gh/apache/incubator-superset/commit/022d7556401750c6bc28a081a6780fce2f4033fd?el=desc) (022d755) will **decrease** coverage by `2.63%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.66% 64.02% -2.64%
==========================================
Files 951 471 -480
Lines 46663 29013 -17650
Branches 4571 0 -4571
==========================================
- Hits 31106 18576 -12530
+ Misses 15421 10437 -4984
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.02% <ø> (-0.57%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.61% <0.00%> (-0.15%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| ... and [471 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [022d755...8428c07](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534158986
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -171,11 +171,18 @@ class SliceHeaderControls extends React.PureComponent {
addDangerToast,
isFullSize,
} = this.props;
- const cachedWhen = moment.utc(cachedDttm).fromNow();
+ const cachedWhen = cachedDttm.map(itemCachedDttm =>
+ moment.utc(itemCachedDttm).fromNow(),
+ );
const updatedWhen = updatedDttm ? moment.utc(updatedDttm).fromNow() : '';
- const refreshTooltip = isCached
- ? t('Cached %s', cachedWhen)
- : (updatedWhen && t('Fetched %s', updatedWhen)) || '';
+ const getCachedTitle = itemCached => {
+ return itemCached
+ ? t('Cached %s', cachedWhen)
+ : updatedWhen && t('Fetched %s', updatedWhen);
+ };
+ let refreshTooltip = isCached.map(getCachedTitle) || '';
+ // If all queries have same cache time we can unit them to one
+ refreshTooltip = [...new Set(refreshTooltip)].join(', ');
Review comment:
I wonder if we should instead have something like this for the case when there are more than one result:
```
*Force refresh*
Query 1: Fetched a minute ago
Query 2: Fetched 3 minutes ago
Query 3: Not cached
```
Also, we should think about how to display multiple results in the "View Results" tab. But that can wait; let's just make sure the user experience is unchanged for single queries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r542107527
##########
File path: superset-frontend/src/chart/chartAction.js
##########
@@ -361,38 +361,36 @@ export function exploreJSON(
const chartDataRequestCaught = chartDataRequest
.then(response => {
+ const queriesResponse = response.result;
+
if (isFeatureEnabled(FeatureFlag.GLOBAL_ASYNC_QUERIES)) {
// deal with getChartDataRequest transforming the response data
const result = 'result' in response ? response.result[0] : response;
return dispatch(chartUpdateQueued(result, key));
Review comment:
Yes, the return value here is a [async job metadata payload](https://github.com/apache/incubator-superset/blob/4d329071a1651994574c3ad1f26e32b56d9ff810/superset/charts/schemas.py#L1108).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-737460449
@robdiciuccio here's my take on the topic:
- The multiple queries feature was added prior to the SIP process, but was only implemented on the backend - the necessary frontend changes weren't done.
- The `api/v1/chart/data` already supports multiple queries, so no backend changes are necessary.
- `superset/explore_json` and `viz.py` don't need to be changed, as they won't be supporting multiple queries.
- Based on my understanding of the async PR, `QueryContext` gets a `cache_key` of it's own in `QueryContext.cache_key()`, and that can handle multiple queries. I'm uncertain if we want to cache only the `QueryObject` or both the `QueryObject` and `QueryContext` going forward, but both can be done.
- There are a few things that still need to be addressed. For instance, the "View Results" and "View Query" features currently only support showing the query/results for a single query object. But AFAIK this isn't a major problem and can be addressed later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r537818342
##########
File path: superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts
##########
@@ -132,12 +132,12 @@ export const selectIndicatorsForChart = (
// for now we only need to know which columns are compatible/incompatible,
// so grab the columns from the applied/rejected filters
const appliedColumns: Set<string> = new Set(
- (chart?.queryResponse?.applied_filters || []).map(
+ (chart?.queriesResponse?.[0]?.applied_filters || []).map(
Review comment:
I implemented this logic. The goal of these two lines is to get a set of all the columns that were applied on a chart, and the columns that were rejected, in order to display them in the filter badge.
If a chart makes multiple queries, it would probably be more correct to add the `applied_filters` and `rejected_filters` from each of the queries, instead of just the first one. But that really depends on how dashboard filters works with multiple queries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534111820
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -171,11 +171,18 @@ class SliceHeaderControls extends React.PureComponent {
addDangerToast,
isFullSize,
} = this.props;
- const cachedWhen = moment.utc(cachedDttm).fromNow();
+ const cachedWhen = cachedDttm.map(itemCachedDttm =>
+ moment.utc(itemCachedDttm).fromNow(),
+ );
const updatedWhen = updatedDttm ? moment.utc(updatedDttm).fromNow() : '';
- const refreshTooltip = isCached
- ? t('Cached %s', cachedWhen)
- : (updatedWhen && t('Fetched %s', updatedWhen)) || '';
+ const getCachedTitle = itemCached => {
+ return itemCached
+ ? t('Cached %s', cachedWhen)
+ : updatedWhen && t('Fetched %s', updatedWhen);
+ };
+ let refreshTooltip = isCached.map(getCachedTitle) || '';
+ // If all queries have same cache time we can unit them to one
+ refreshTooltip = [...new Set(refreshTooltip)].join(', ');
Review comment:
Could you share a screenshot of what this looks like?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (4e4238c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `12.43%`.
> The diff coverage is `89.28%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
===========================================
- Coverage 66.79% 54.36% -12.44%
===========================================
Files 924 420 -504
Lines 44837 14799 -30038
Branches 4253 3812 -441
===========================================
- Hits 29951 8046 -21905
+ Misses 14777 6753 -8024
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.36% <89.28%> (+4.79%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <0.00%> (ø)` | |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `59.01% <ø> (-9.84%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `58.33% <ø> (ø)` | |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `75.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `74.66% <100.00%> (-0.68%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `71.50% <100.00%> (-1.87%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `64.10% <100.00%> (+18.89%)` | :arrow_up: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `77.41% <100.00%> (-3.23%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [808 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...b6f4fe1](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: WIP: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534780130
##########
File path: superset-frontend/src/chart/Chart.jsx
##########
@@ -185,14 +179,14 @@ class Chart extends React.PureComponent {
errorMessage,
onQuery,
refreshOverlayVisible,
+ queriesResponse,
} = this.props;
const isLoading = chartStatus === 'loading';
-
const isFaded = refreshOverlayVisible && !errorMessage;
this.renderContainerStartTime = Logger.getTimestamp();
if (chartStatus === 'failed') {
- return this.renderErrorMessage();
+ return queriesResponse.map(item => this.renderErrorMessage(item));
Review comment:
@robdiciuccio Hi good catch, I didn't check it properly for all kinds of charts (new/old). I pushed now some small fix for it. Basically for now for new api there is no case that it returns more than 1 error per request even for multi queries, but if it will return we can support it, but for now it will be only one error.
P.S. If you have some more places where I can check this functionality, update me please, because I'm new in Superset so I don't know all places and cases of its usages :)
Attaching screenshots after my fix for charts:
1. Old charts:
2. New charts:
3. New charts with multiqueries (looks the same):
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (af13a23) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.64%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.15% -3.65%
==========================================
Files 924 466 -458
Lines 44837 16630 -28207
Branches 4253 4309 +56
==========================================
- Hits 29951 10502 -19449
+ Misses 14777 5950 -8827
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.15% <42.85%> (+0.11%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <0.00%> (-47.28%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `38.66% <0.00%> (-36.68%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `26.22% <ø> (-42.63%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `25.00% <ø> (-33.34%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `11.53% <0.00%> (-33.67%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.00% <ø> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <90.00%> (-22.30%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <100.00%> (-15.06%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [627 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...4e4238c](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (80460ea) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **increase** coverage by `0.46%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 63.37% 63.83% +0.46%
==========================================
Files 970 481 -489
Lines 47937 29673 -18264
Branches 4736 0 -4736
==========================================
- Hits 30380 18942 -11438
+ Misses 17370 10731 -6639
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.83% <ø> (-0.32%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.90% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.97% <0.00%> (-2.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.75% <0.00%> (-1.85%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.44% <0.00%> (-1.84%)` | :arrow_down: |
| ... and [480 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...80460ea](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio merged pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
robdiciuccio merged pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (8428c07) into [master](https://codecov.io/gh/apache/incubator-superset/commit/022d7556401750c6bc28a081a6780fce2f4033fd?el=desc) (022d755) will **decrease** coverage by `2.90%`.
> The diff coverage is `47.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.66% 63.75% -2.91%
==========================================
Files 951 951
Lines 46663 46661 -2
Branches 4571 4576 +5
==========================================
- Hits 31106 29748 -1358
- Misses 15421 16729 +1308
- Partials 136 184 +48
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.62% <47.50%> (-0.04%)` | :arrow_down: |
| python | `64.43% <ø> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.71% <0.00%> (-45.65%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `39.72% <0.00%> (-35.62%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `25.00% <ø> (-33.34%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.97% <0.00%> (-50.67%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <ø> (-2.95%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `13.63% <ø> (-63.64%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `93.33% <ø> (-6.67%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.77% <91.66%> (-23.19%)` | :arrow_down: |
| ... and [154 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [022d755...8428c07](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (dc23d64) into [master](https://codecov.io/gh/apache/incubator-superset/commit/90ed3267e498f7c95a34f6703e534d69c9aed2db?el=desc) (90ed326) will **decrease** coverage by `2.59%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.58% 63.99% -2.60%
==========================================
Files 951 471 -480
Lines 46663 29013 -17650
Branches 4571 0 -4571
==========================================
- Hits 31070 18566 -12504
+ Misses 15456 10447 -5009
+ Partials 137 0 -137
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.99% <ø> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| ... and [475 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [90ed326...dc23d64](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-737436810
Is there a SIP that references support for multiple queries in charts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534151585
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -171,11 +171,18 @@ class SliceHeaderControls extends React.PureComponent {
addDangerToast,
isFullSize,
} = this.props;
- const cachedWhen = moment.utc(cachedDttm).fromNow();
+ const cachedWhen = cachedDttm.map(itemCachedDttm =>
+ moment.utc(itemCachedDttm).fromNow(),
+ );
const updatedWhen = updatedDttm ? moment.utc(updatedDttm).fromNow() : '';
- const refreshTooltip = isCached
- ? t('Cached %s', cachedWhen)
- : (updatedWhen && t('Fetched %s', updatedWhen)) || '';
+ const getCachedTitle = itemCached => {
+ return itemCached
+ ? t('Cached %s', cachedWhen)
+ : updatedWhen && t('Fetched %s', updatedWhen);
+ };
+ let refreshTooltip = isCached.map(getCachedTitle) || '';
+ // If all queries have same cache time we can unit them to one
+ refreshTooltip = [...new Set(refreshTooltip)].join(', ');
Review comment:
@villebro So basically if all requests will have same time it will look like"
And if different then like this (just emulate by code changes for screenshot):
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (af13a23) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.14%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.65% -3.15%
==========================================
Files 924 927 +3
Lines 44837 45010 +173
Branches 4253 4309 +56
==========================================
- Hits 29951 28653 -1298
- Misses 14777 16179 +1402
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.15% <42.85%> (+0.11%)` | :arrow_up: |
| python | `63.95% <ø> (-0.21%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <0.00%> (-47.28%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `38.66% <0.00%> (-36.68%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `26.22% <ø> (-42.63%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `25.00% <ø> (-33.34%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `11.53% <0.00%> (-33.67%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.00% <ø> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <90.00%> (-22.30%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <100.00%> (-15.06%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [182 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...b6f4fe1](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: WIP: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534861251
##########
File path: superset-frontend/src/chart/chartAction.js
##########
@@ -360,28 +360,33 @@ export function exploreJSON(
// problem: response holds a list of results, when before we were just getting one result.
// How to make the entire app compatible with multiple results?
// For now just use the first result.
- const result = response.result[0];
+ const queryResponse = response.result[0]; // deprecated
+ const queriesResponse = response.result;
- dispatch(
- logEvent(LOG_ACTIONS_LOAD_CHART, {
- slice_id: key,
- applied_filters: result.applied_filters,
- is_cached: result.is_cached,
- force_refresh: force,
- row_count: result.rowcount,
- datasource: formData.datasource,
- start_offset: logStart,
- ts: new Date().getTime(),
- duration: Logger.getTimestamp() - logStart,
- has_extra_filters:
- formData.extra_filters && formData.extra_filters.length > 0,
- viz_type: formData.viz_type,
- data_age: result.is_cached
- ? moment(new Date()).diff(moment.utc(result.cached_dttm))
- : null,
- }),
+ queriesResponse.forEach(resultItem =>
+ dispatch(
+ logEvent(LOG_ACTIONS_LOAD_CHART, {
+ slice_id: key,
+ applied_filters: resultItem.applied_filters,
+ is_cached: resultItem.is_cached,
+ force_refresh: force,
+ row_count: resultItem.rowcount,
+ datasource: formData.datasource,
+ start_offset: logStart,
+ ts: new Date().getTime(),
+ duration: Logger.getTimestamp() - logStart,
+ has_extra_filters:
+ formData.extra_filters && formData.extra_filters.length > 0,
+ viz_type: formData.viz_type,
+ data_age: resultItem.is_cached
+ ? moment(new Date()).diff(moment.utc(resultItem.cached_dttm))
+ : null,
+ }),
+ ),
+ );
+ return dispatch(
+ chartUpdateSucceeded(queryResponse, queriesResponse, key),
Review comment:
hmm... good point, actually I wanted avoid refactor of a lot places in code, but now I see I hope I can handle it, I also will add some people to review, where I see my refactor affect there parts of code to be sure.
I pushed now refactored code as you proposed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (6267716) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.21% -3.59%
==========================================
Files 924 461 -463
Lines 44837 28365 -16472
Branches 4253 0 -4253
==========================================
- Hits 29951 17932 -12019
+ Misses 14777 10433 -4344
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.21% <ø> (-0.95%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `83.67% <0.00%> (-5.31%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [480 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...6267716](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (47a1293) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `2.65%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 64.14% -2.66%
==========================================
Files 924 461 -463
Lines 44837 28383 -16454
Branches 4253 0 -4253
==========================================
- Hits 29951 18207 -11744
+ Misses 14777 10176 -4601
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.14% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.59% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.68% <0.00%> (-0.10%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <0.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <0.00%> (ø)` | |
| [superset/reports/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9hcGkucHk=) | `84.21% <0.00%> (ø)` | |
| [...ns/978245563a02\_migrate\_iframe\_to\_dash\_markdown.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy85NzgyNDU1NjNhMDJfbWlncmF0ZV9pZnJhbWVfdG9fZGFzaF9tYXJrZG93bi5weQ==) | `0.00% <0.00%> (ø)` | |
| [...rontend/src/visualizations/TimeTable/TimeTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9UaW1lVGFibGUuanN4) | | |
| [superset-frontend/src/components/FormLabel.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybUxhYmVsLnRzeA==) | | |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | | |
| ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...47a1293](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (a4b2a75) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `2.72%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 64.07% -2.73%
==========================================
Files 924 461 -463
Lines 44837 28353 -16484
Branches 4253 0 -4253
==========================================
- Hits 29951 18167 -11784
+ Misses 14777 10186 -4591
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.07% <ø> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.14% <0.00%> (-0.81%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.31% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.49% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.20% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <0.00%> (ø)` | |
| [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | | |
| ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...a4b2a75](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: WIP: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (47a1293) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.55% -3.25%
==========================================
Files 924 461 -463
Lines 44837 28368 -16469
Branches 4253 0 -4253
==========================================
- Hits 29951 18030 -11921
+ Misses 14777 10338 -4439
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.55% <ø> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.14% <0.00%> (-0.81%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.59% <0.00%> (-0.61%)` | :arrow_down: |
| ... and [463 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...47a1293](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: WIP: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534780130
##########
File path: superset-frontend/src/chart/Chart.jsx
##########
@@ -185,14 +179,14 @@ class Chart extends React.PureComponent {
errorMessage,
onQuery,
refreshOverlayVisible,
+ queriesResponse,
} = this.props;
const isLoading = chartStatus === 'loading';
-
const isFaded = refreshOverlayVisible && !errorMessage;
this.renderContainerStartTime = Logger.getTimestamp();
if (chartStatus === 'failed') {
- return this.renderErrorMessage();
+ return queriesResponse.map(item => this.renderErrorMessage(item));
Review comment:
@robdiciuccio Hi good catch, I didn't check it properly for all kinds of charts (new/old). I pushed now some small fix for it. Basically for now for new api there is no case that it returns more than 1 error per request even for multi queries, but if it will return we can support it, but for now it will be only one error.
Attaching screenshots after my fix for charts:
1. Old charts:
2. New charts:
3. New charts with multiqueries (looks the same):
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] amitmiran137 commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-747754233
Can we review and merge ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534191734
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -171,11 +171,18 @@ class SliceHeaderControls extends React.PureComponent {
addDangerToast,
isFullSize,
} = this.props;
- const cachedWhen = moment.utc(cachedDttm).fromNow();
+ const cachedWhen = cachedDttm.map(itemCachedDttm =>
+ moment.utc(itemCachedDttm).fromNow(),
+ );
const updatedWhen = updatedDttm ? moment.utc(updatedDttm).fromNow() : '';
- const refreshTooltip = isCached
- ? t('Cached %s', cachedWhen)
- : (updatedWhen && t('Fetched %s', updatedWhen)) || '';
+ const getCachedTitle = itemCached => {
+ return itemCached
+ ? t('Cached %s', cachedWhen)
+ : updatedWhen && t('Fetched %s', updatedWhen);
+ };
+ let refreshTooltip = isCached.map(getCachedTitle) || '';
+ // If all queries have same cache time we can unit them to one
+ refreshTooltip = [...new Set(refreshTooltip)].join(', ');
Review comment:
1. done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (b6f4fe1) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.37% -3.43%
==========================================
Files 924 461 -463
Lines 44837 28380 -16457
Branches 4253 0 -4253
==========================================
- Hits 29951 17986 -11965
+ Misses 14777 10394 -4383
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.37% <ø> (-0.79%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.53% <0.00%> (-6.94%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.05% <0.00%> (-3.74%)` | :arrow_down: |
| ... and [471 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...b6f4fe1](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534861251
##########
File path: superset-frontend/src/chart/chartAction.js
##########
@@ -360,28 +360,33 @@ export function exploreJSON(
// problem: response holds a list of results, when before we were just getting one result.
// How to make the entire app compatible with multiple results?
// For now just use the first result.
- const result = response.result[0];
+ const queryResponse = response.result[0]; // deprecated
+ const queriesResponse = response.result;
- dispatch(
- logEvent(LOG_ACTIONS_LOAD_CHART, {
- slice_id: key,
- applied_filters: result.applied_filters,
- is_cached: result.is_cached,
- force_refresh: force,
- row_count: result.rowcount,
- datasource: formData.datasource,
- start_offset: logStart,
- ts: new Date().getTime(),
- duration: Logger.getTimestamp() - logStart,
- has_extra_filters:
- formData.extra_filters && formData.extra_filters.length > 0,
- viz_type: formData.viz_type,
- data_age: result.is_cached
- ? moment(new Date()).diff(moment.utc(result.cached_dttm))
- : null,
- }),
+ queriesResponse.forEach(resultItem =>
+ dispatch(
+ logEvent(LOG_ACTIONS_LOAD_CHART, {
+ slice_id: key,
+ applied_filters: resultItem.applied_filters,
+ is_cached: resultItem.is_cached,
+ force_refresh: force,
+ row_count: resultItem.rowcount,
+ datasource: formData.datasource,
+ start_offset: logStart,
+ ts: new Date().getTime(),
+ duration: Logger.getTimestamp() - logStart,
+ has_extra_filters:
+ formData.extra_filters && formData.extra_filters.length > 0,
+ viz_type: formData.viz_type,
+ data_age: resultItem.is_cached
+ ? moment(new Date()).diff(moment.utc(resultItem.cached_dttm))
+ : null,
+ }),
+ ),
+ );
+ return dispatch(
+ chartUpdateSucceeded(queryResponse, queriesResponse, key),
Review comment:
@robdiciuccio hmm... good point, actually I wanted avoid refactoring of a lot places in code, but now I see I think I can handle it, I also will add someone more to review, where I see that my refactor will affect his parts of code to be sure.
I pushed now refactored code as you proposed and asked @etr2460 to review also... I tested these changes in explore/dashboard in areas that I know, but if there are some other places, that I need to test please update me.
I also see that affected some code that @suddjian implemented, may be it can be good to add him as reviewer?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-748089330
@amitmiran137 CI has been slightly flaky lately. I restarted, let's see if this fixes it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (dc23d64) into [master](https://codecov.io/gh/apache/incubator-superset/commit/90ed3267e498f7c95a34f6703e534d69c9aed2db?el=desc) (90ed326) will **decrease** coverage by `1.98%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.58% 64.59% -1.99%
==========================================
Files 951 471 -480
Lines 46663 29028 -17635
Branches 4571 0 -4571
==========================================
- Hits 31070 18751 -12319
+ Misses 15456 10277 -5179
+ Partials 137 0 -137
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.59% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/common/components/Radio.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1JhZGlvLnRzeA==) | | |
| [...ews/CRUD/annotationlayers/AnnotationLayersList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJzTGlzdC50c3g=) | | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | | |
| [.../src/views/CRUD/alert/components/RecipientIcon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvY29tcG9uZW50cy9SZWNpcGllbnRJY29uLnRzeA==) | | |
| [superset-frontend/src/views/CRUD/data/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9ob29rcy50cw==) | | |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | | |
| [...nd/src/dashboard/components/FiltersBadge/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9pbmRleC50c3g=) | | |
| [superset-frontend/src/showSavedQuery/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Nob3dTYXZlZFF1ZXJ5L2luZGV4LmpzeA==) | | |
| [...rc/explore/components/controls/ViewportControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3cG9ydENvbnRyb2wuanN4) | | |
| [...set-frontend/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZFVybC5qcw==) | | |
| ... and [456 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [90ed326...dc23d64](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (dc23d64) into [master](https://codecov.io/gh/apache/incubator-superset/commit/90ed3267e498f7c95a34f6703e534d69c9aed2db?el=desc) (90ed326) will **decrease** coverage by `2.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.58% 64.43% -2.15%
==========================================
Files 951 471 -480
Lines 46663 29028 -17635
Branches 4571 0 -4571
==========================================
- Hits 31070 18704 -12366
+ Misses 15456 10324 -5132
+ Partials 137 0 -137
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.43% <ø> (-0.17%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.61% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.62% <0.00%> (-0.14%)` | :arrow_down: |
| [.../dashboard/util/logging/findNonTabChildChartIds.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZmluZE5vblRhYkNoaWxkQ2hhcnRJZHMuanM=) | | |
| [superset-frontend/src/components/ErrorBoundary.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JCb3VuZGFyeS5qc3g=) | | |
| [...d/src/dashboard/components/FiltersBadge/Styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9TdHlsZXMudHN4) | | |
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | | |
| ... and [462 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [90ed326...dc23d64](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: WIP: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534865375
##########
File path: superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts
##########
@@ -132,12 +132,12 @@ export const selectIndicatorsForChart = (
// for now we only need to know which columns are compatible/incompatible,
// so grab the columns from the applied/rejected filters
const appliedColumns: Set<string> = new Set(
- (chart?.queryResponse?.applied_filters || []).map(
+ (chart?.queriesResponse?.[0]?.applied_filters || []).map(
Review comment:
@etr2460 Hi I see you implemented this part of code, I refactored it to use multi queries, can you please look that my changes not break some functionality. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (af13a23) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.12%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.67% -3.13%
==========================================
Files 924 927 +3
Lines 44837 45010 +173
Branches 4253 4309 +56
==========================================
- Hits 29951 28661 -1290
- Misses 14777 16171 +1394
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.15% <42.85%> (+0.11%)` | :arrow_up: |
| python | `63.98% <ø> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <0.00%> (-47.28%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `38.66% <0.00%> (-36.68%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `26.22% <ø> (-42.63%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `25.00% <ø> (-33.34%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `11.53% <0.00%> (-33.67%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.00% <ø> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <90.00%> (-22.30%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <100.00%> (-15.06%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [179 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...b6f4fe1](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-737460449
@robdiciuccio here's my take on the topic:
- The multiple queries feature was added prior to the SIP process, but was only implemented on the backend - the necessary frontend changes weren't done.
- The `api/v1/chart/data` already supports multiple queries, so no backend changes are necessary.
- `superset/explore_json` and `viz.py` don't need to be changed, as they won't be supporting multiple queries.
- Based on my understanding of the async PR, `QueryContext` gets a `cache_key` of it's own in `QueryContext.cache_key()`, and that can handle multiple queries. I'm uncertain if we want to cache only the `QueryObject` or both the `QueryObject` and `QueryContext` going forward, but both can be done.
- There are a few things that still need to be addressed. For instance, the "View Results" and "View Query" features currently only support showing the query/results for a single query object. But AFAIK this isn't a major problem and can be addressed later. It would be great to get design input on these at some point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (618fbaf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.47% -3.33%
==========================================
Files 924 461 -463
Lines 44837 28365 -16472
Branches 4253 0 -4253
==========================================
- Hits 29951 18004 -11947
+ Misses 14777 10361 -4416
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.47% <ø> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [471 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...6267716](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (0d8b758) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **increase** coverage by `0.79%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 63.37% 64.17% +0.79%
==========================================
Files 970 481 -489
Lines 47937 29682 -18255
Branches 4736 0 -4736
==========================================
- Hits 30380 19048 -11332
+ Misses 17370 10634 -6736
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.17% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.37% <0.00%> (-0.08%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | | |
| [...set-frontend/src/explore/components/ControlRow.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUm93LmpzeA==) | | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | | |
| [superset-frontend/src/messageToasts/constants.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29uc3RhbnRzLnRz) | | |
| [superset-frontend/src/setup/setupPluginsExtra.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLnRz) | | |
| [superset-frontend/src/views/CRUD/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdHlwZXMudHM=) | | |
| [superset-frontend/src/setup/setupClient.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ2xpZW50LnRz) | | |
| [...d/src/dashboard/util/updateComponentParentsList.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3VwZGF0ZUNvbXBvbmVudFBhcmVudHNMaXN0Lmpz) | | |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | | |
| ... and [467 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...197ba55](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] amitmiran137 commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-737021784
@robdiciuccio A classic use-case for multiple queries is uplifting table pagination in which you query the page data and second the total item count for determining how many pages to display
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-743458514
Hi @simchaNielsen, heads-up that the [async queries PR](https://github.com/apache/incubator-superset/pull/11499) has been merged, which may affect how the chart actions are called here. Happy to answer any questions about the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] amitmiran137 commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-737458961
@robdiciuccio BE already supports running multiple queries for a long time now.
The what handling the multiple responses properly in the FE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (197ba55) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **increase** coverage by `0.23%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 63.37% 63.60% +0.23%
==========================================
Files 970 481 -489
Lines 47937 29682 -18255
Branches 4736 0 -4736
==========================================
- Hits 30380 18880 -11500
+ Misses 17370 10802 -6568
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.60% <ø> (-0.55%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.37% <0.00%> (-0.08%)` | :arrow_down: |
| [...rontend/src/components/ListView/CardSortSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZFNvcnRTZWxlY3QudHN4) | | |
| ... and [475 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...d6ffbf2](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (dc23d64) into [master](https://codecov.io/gh/apache/incubator-superset/commit/90ed3267e498f7c95a34f6703e534d69c9aed2db?el=desc) (90ed326) will **decrease** coverage by `2.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.58% 64.02% -2.56%
==========================================
Files 951 471 -480
Lines 46663 29013 -17650
Branches 4571 0 -4571
==========================================
- Hits 31070 18576 -12494
+ Misses 15456 10437 -5019
+ Partials 137 0 -137
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.02% <ø> (-0.57%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.61% <0.00%> (-0.15%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| ... and [471 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [90ed326...dc23d64](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (a4b2a75) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `2.72%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 64.07% -2.73%
==========================================
Files 924 461 -463
Lines 44837 28353 -16484
Branches 4253 0 -4253
==========================================
- Hits 29951 18167 -11784
+ Misses 14777 10186 -4591
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.07% <ø> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.14% <0.00%> (-0.81%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.31% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.49% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.20% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <0.00%> (ø)` | |
| [...src/dashboard/components/gridComponents/Column.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NvbHVtbi5qc3g=) | | |
| ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...a4b2a75](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] amitmiran137 commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-748050660
@robdiciuccio I've added necessary changes.
could anyone rerun the E2E?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (a4b2a75) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `5.76%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 61.03% -5.77%
==========================================
Files 924 878 -46
Lines 44837 43028 -1809
Branches 4253 3762 -491
==========================================
- Hits 29951 26264 -3687
- Misses 14777 16764 +1987
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.17% <85.71%> (+5.60%)` | :arrow_up: |
| javascript | `?` | |
| python | `64.07% <ø> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <0.00%> (ø)` | |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `59.01% <ø> (-9.84%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `58.33% <ø> (ø)` | |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `75.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `74.66% <75.00%> (-0.68%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `71.50% <100.00%> (-1.87%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `63.15% <100.00%> (+17.95%)` | :arrow_up: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `77.41% <100.00%> (-3.23%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [349 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...a4b2a75](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (47a1293) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `2.65%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 64.14% -2.66%
==========================================
Files 924 461 -463
Lines 44837 28383 -16454
Branches 4253 0 -4253
==========================================
- Hits 29951 18207 -11744
+ Misses 14777 10176 -4601
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.14% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.59% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.68% <0.00%> (-0.10%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <0.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.68% <0.00%> (ø)` | |
| [superset/reports/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9hcGkucHk=) | `84.21% <0.00%> (ø)` | |
| [...ns/978245563a02\_migrate\_iframe\_to\_dash\_markdown.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy85NzgyNDU1NjNhMDJfbWlncmF0ZV9pZnJhbWVfdG9fZGFzaF9tYXJrZG93bi5weQ==) | `0.00% <0.00%> (ø)` | |
| [...ashboard/components/gridComponents/new/NewTabs.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdUYWJzLmpzeA==) | | |
| [superset-frontend/src/setup/setupPluginsExtra.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLnRz) | | |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | | |
| ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...47a1293](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r538104882
##########
File path: superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts
##########
@@ -132,12 +132,12 @@ export const selectIndicatorsForChart = (
// for now we only need to know which columns are compatible/incompatible,
// so grab the columns from the applied/rejected filters
const appliedColumns: Set<string> = new Set(
- (chart?.queryResponse?.applied_filters || []).map(
+ (chart?.queriesResponse?.[0]?.applied_filters || []).map(
Review comment:
> If a chart makes multiple queries, it would probably be more correct to add the `applied_filters` and `rejected_filters` from each of the queries, instead of just the first one. But that really depends on how dashboard filters works with multiple queries.
I think we should probably be applying the same filters to all `QueryObject`s. Since a `QueryContext` currently only supports a single datasource, the applied/rejected columns should be identical. However, temporal filters will only be applicable for `QueryObject`s with `is_temporal: true`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (618fbaf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `5.87%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 60.92% -5.88%
==========================================
Files 924 881 -43
Lines 44837 43174 -1663
Branches 4253 3812 -441
==========================================
- Hits 29951 26305 -3646
- Misses 14777 16869 +2092
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.90% <88.88%> (+5.33%)` | :arrow_up: |
| javascript | `?` | |
| python | `64.06% <ø> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <0.00%> (ø)` | |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `59.01% <ø> (-9.84%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `58.33% <ø> (ø)` | |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `75.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `74.66% <100.00%> (-0.68%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `71.50% <100.00%> (-1.87%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `63.63% <100.00%> (+18.43%)` | :arrow_up: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `77.41% <100.00%> (-3.23%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [358 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...6267716](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: WIP: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (47a1293) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.55% -3.25%
==========================================
Files 924 461 -463
Lines 44837 28383 -16454
Branches 4253 0 -4253
==========================================
- Hits 29951 18039 -11912
+ Misses 14777 10344 -4433
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.55% <ø> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.14% <0.00%> (-0.81%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.59% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.62% <0.00%> (-0.14%)` | :arrow_down: |
| ... and [454 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...47a1293](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (a4b2a75) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.48%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.31% -3.49%
==========================================
Files 924 461 -463
Lines 44837 28351 -16486
Branches 4253 0 -4253
==========================================
- Hits 29951 17951 -12000
+ Misses 14777 10400 -4377
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.31% <ø> (-0.85%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.33% <0.00%> (-6.43%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.71% <0.00%> (-3.24%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.25% <0.00%> (-2.81%)` | :arrow_down: |
| ... and [465 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...a4b2a75](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (af13a23) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.02%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.77% -3.03%
==========================================
Files 924 927 +3
Lines 44837 45010 +173
Branches 4253 4309 +56
==========================================
- Hits 29951 28707 -1244
- Misses 14777 16125 +1348
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.15% <42.85%> (+0.11%)` | :arrow_up: |
| python | `64.14% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <0.00%> (-47.28%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `38.66% <0.00%> (-36.68%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `26.22% <ø> (-42.63%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `25.00% <ø> (-33.34%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `11.53% <0.00%> (-33.67%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.00% <ø> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <90.00%> (-22.30%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <100.00%> (-15.06%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [174 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...b6f4fe1](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-737687144
> LGTM. As this feature requires `superset-ui/core: "^0.15.15"`, it won't yet function without the bump. So you may potentially want to wait for the dashboard native filter to merge which should happen shortly (it bumps all relevant deps). If this is urgent, feel free to add the bump to this PR.
It's backward compatible feature so can be merged unrelated `superset-ui`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (a4b2a75) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `2.72%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 64.07% -2.73%
==========================================
Files 924 461 -463
Lines 44837 28353 -16484
Branches 4253 0 -4253
==========================================
- Hits 29951 18167 -11784
+ Misses 14777 10186 -4591
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.07% <ø> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.14% <0.00%> (-0.81%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.31% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.49% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.20% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <0.00%> (ø)` | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | | |
| ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...a4b2a75](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534705132
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -171,11 +171,18 @@ class SliceHeaderControls extends React.PureComponent {
addDangerToast,
isFullSize,
} = this.props;
- const cachedWhen = moment.utc(cachedDttm).fromNow();
+ const cachedWhen = cachedDttm.map(itemCachedDttm =>
+ moment.utc(itemCachedDttm).fromNow(),
+ );
const updatedWhen = updatedDttm ? moment.utc(updatedDttm).fromNow() : '';
- const refreshTooltip = isCached
- ? t('Cached %s', cachedWhen)
- : (updatedWhen && t('Fetched %s', updatedWhen)) || '';
+ const getCachedTitle = itemCached => {
+ return itemCached
+ ? t('Cached %s', cachedWhen)
+ : updatedWhen && t('Fetched %s', updatedWhen);
+ };
+ let refreshTooltip = isCached.map(getCachedTitle) || '';
+ // If all queries have same cache time we can unit them to one
+ refreshTooltip = [...new Set(refreshTooltip)].join(', ');
Review comment:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (a4b2a75) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `5.96%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 60.83% -5.97%
==========================================
Files 924 878 -46
Lines 44837 43028 -1809
Branches 4253 3762 -491
==========================================
- Hits 29951 26177 -3774
- Misses 14777 16851 +2074
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.58% <85.71%> (+5.00%)` | :arrow_up: |
| javascript | `?` | |
| python | `64.07% <ø> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <0.00%> (ø)` | |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `59.01% <ø> (-9.84%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `58.33% <ø> (ø)` | |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `75.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `74.66% <75.00%> (-0.68%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `71.50% <100.00%> (-1.87%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `63.15% <100.00%> (+17.95%)` | :arrow_up: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `77.41% <100.00%> (-3.23%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [350 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...a4b2a75](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (6267716) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.23%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.56% -3.24%
==========================================
Files 924 461 -463
Lines 44837 28365 -16472
Branches 4253 0 -4253
==========================================
- Hits 29951 18029 -11922
+ Misses 14777 10336 -4441
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.56% <ø> (-0.60%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.14% <0.00%> (-0.81%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.59% <0.00%> (-0.61%)` | :arrow_down: |
| ... and [468 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...6267716](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (0d8b758) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **increase** coverage by `0.64%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 63.37% 64.01% +0.64%
==========================================
Files 970 481 -489
Lines 47937 29682 -18255
Branches 4736 0 -4736
==========================================
- Hits 30380 19001 -11379
+ Misses 17370 10681 -6689
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.01% <ø> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.61% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.37% <0.00%> (-0.08%)` | :arrow_down: |
| [...essageToasts/utils/getToastsFromPyFlashMessages.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvdXRpbHMvZ2V0VG9hc3RzRnJvbVB5Rmxhc2hNZXNzYWdlcy5qcw==) | | |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | | |
| [...-frontend/src/dashboard/util/headerStyleOptions.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2hlYWRlclN0eWxlT3B0aW9ucy50cw==) | | |
| ... and [473 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...0d8b758](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (80460ea) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **increase** coverage by `0.45%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 63.37% 63.82% +0.45%
==========================================
Files 970 481 -489
Lines 47937 29673 -18264
Branches 4736 0 -4736
==========================================
- Hits 30380 18939 -11441
+ Misses 17370 10734 -6636
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.82% <ø> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.90% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.97% <0.00%> (-2.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.75% <0.00%> (-1.85%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.44% <0.00%> (-1.84%)` | :arrow_down: |
| ... and [481 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...80460ea](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (0d8b758) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **increase** coverage by `0.79%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 63.37% 64.17% +0.79%
==========================================
Files 970 481 -489
Lines 47937 29682 -18255
Branches 4736 0 -4736
==========================================
- Hits 30380 19048 -11332
+ Misses 17370 10634 -6736
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.17% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.37% <0.00%> (-0.08%)` | :arrow_down: |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | | |
| [...frontend/src/dashboard/util/dropOverflowsParent.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2Ryb3BPdmVyZmxvd3NQYXJlbnQuanM=) | | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | | |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | | |
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | | |
| [...nd/src/dashboard/util/getComponentWidthFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENvbXBvbmVudFdpZHRoRnJvbURyb3AuanM=) | | |
| [...ore/components/controls/DateFilterControl/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC90eXBlcy50cw==) | | |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | | |
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | | |
| ... and [467 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...197ba55](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (b6f4fe1) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `2.74%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 64.05% -2.75%
==========================================
Files 924 461 -463
Lines 44837 28380 -16457
Branches 4253 0 -4253
==========================================
- Hits 29951 18179 -11772
+ Misses 14777 10201 -4576
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.05% <ø> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.14% <0.00%> (-0.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.59% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.31% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.49% <0.00%> (-0.27%)` | :arrow_down: |
| ... and [459 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...b6f4fe1](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (618fbaf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `2.73%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 64.06% -2.74%
==========================================
Files 924 461 -463
Lines 44837 28380 -16457
Branches 4253 0 -4253
==========================================
- Hits 29951 18182 -11769
+ Misses 14777 10198 -4579
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.06% <ø> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.41% <0.00%> (-3.57%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.14% <0.00%> (-0.81%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.59% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.31% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.49% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.20% <0.00%> (-0.27%)` | :arrow_down: |
| ... and [458 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...6267716](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (af13a23) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `3.42%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.79% 63.37% -3.43%
==========================================
Files 924 927 +3
Lines 44837 44995 +158
Branches 4253 4309 +56
==========================================
- Hits 29951 28516 -1435
- Misses 14777 16301 +1524
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.15% <42.85%> (+0.11%)` | :arrow_up: |
| python | `63.50% <ø> (-0.66%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <0.00%> (-47.28%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `38.66% <0.00%> (-36.68%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `26.22% <ø> (-42.63%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `25.00% <ø> (-33.34%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `11.53% <0.00%> (-33.67%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.00% <ø> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <90.00%> (-22.30%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <100.00%> (-15.06%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [194 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...b6f4fe1](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (dc23d64) into [master](https://codecov.io/gh/apache/incubator-superset/commit/90ed3267e498f7c95a34f6703e534d69c9aed2db?el=desc) (90ed326) will **decrease** coverage by `1.98%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.58% 64.59% -1.99%
==========================================
Files 951 471 -480
Lines 46663 29028 -17635
Branches 4571 0 -4571
==========================================
- Hits 31070 18751 -12319
+ Misses 15456 10277 -5179
+ Partials 137 0 -137
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.59% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/components/FacePile/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmFjZVBpbGUvaW5kZXgudHN4) | | |
| [...et-frontend/src/components/ListView/ActionsBar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQWN0aW9uc0Jhci50c3g=) | | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | | |
| [...ontend/src/dashboard/components/menu/HoverMenu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvSG92ZXJNZW51LmpzeA==) | | |
| [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMudHN4) | | |
| [...hboard/components/menu/BackgroundStyleDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvQmFja2dyb3VuZFN0eWxlRHJvcGRvd24uanN4) | | |
| [...perset-frontend/src/messageToasts/actions/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvYWN0aW9ucy9pbmRleC50cw==) | | |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | | |
| [...set-frontend/src/dashboard/util/injectCustomCss.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2luamVjdEN1c3RvbUNzcy5qcw==) | | |
| ... and [456 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [90ed326...dc23d64](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (85a3aa5) into [master](https://codecov.io/gh/apache/incubator-superset/commit/44e80e0175fe084e52453ac5f77ba472922935e9?el=desc) (44e80e0) will **decrease** coverage by `12.47%`.
> The diff coverage is `74.35%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
===========================================
- Coverage 66.79% 54.32% -12.48%
===========================================
Files 924 420 -504
Lines 44837 14806 -30031
Branches 4253 3816 -437
===========================================
- Hits 29951 8043 -21908
+ Misses 14777 6763 -8014
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.32% <74.35%> (+4.74%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `57.14% <0.00%> (-1.04%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `59.01% <0.00%> (-9.84%)` | :arrow_down: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `58.33% <ø> (ø)` | |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.14% <ø> (+1.16%)` | :arrow_up: |
| [...nd/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `75.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `71.35% <75.00%> (-2.02%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `64.19% <92.30%> (+18.99%)` | :arrow_up: |
| ... and [813 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [44e80e0...85a3aa5](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: WIP: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534861251
##########
File path: superset-frontend/src/chart/chartAction.js
##########
@@ -360,28 +360,33 @@ export function exploreJSON(
// problem: response holds a list of results, when before we were just getting one result.
// How to make the entire app compatible with multiple results?
// For now just use the first result.
- const result = response.result[0];
+ const queryResponse = response.result[0]; // deprecated
+ const queriesResponse = response.result;
- dispatch(
- logEvent(LOG_ACTIONS_LOAD_CHART, {
- slice_id: key,
- applied_filters: result.applied_filters,
- is_cached: result.is_cached,
- force_refresh: force,
- row_count: result.rowcount,
- datasource: formData.datasource,
- start_offset: logStart,
- ts: new Date().getTime(),
- duration: Logger.getTimestamp() - logStart,
- has_extra_filters:
- formData.extra_filters && formData.extra_filters.length > 0,
- viz_type: formData.viz_type,
- data_age: result.is_cached
- ? moment(new Date()).diff(moment.utc(result.cached_dttm))
- : null,
- }),
+ queriesResponse.forEach(resultItem =>
+ dispatch(
+ logEvent(LOG_ACTIONS_LOAD_CHART, {
+ slice_id: key,
+ applied_filters: resultItem.applied_filters,
+ is_cached: resultItem.is_cached,
+ force_refresh: force,
+ row_count: resultItem.rowcount,
+ datasource: formData.datasource,
+ start_offset: logStart,
+ ts: new Date().getTime(),
+ duration: Logger.getTimestamp() - logStart,
+ has_extra_filters:
+ formData.extra_filters && formData.extra_filters.length > 0,
+ viz_type: formData.viz_type,
+ data_age: resultItem.is_cached
+ ? moment(new Date()).diff(moment.utc(resultItem.cached_dttm))
+ : null,
+ }),
+ ),
+ );
+ return dispatch(
+ chartUpdateSucceeded(queryResponse, queriesResponse, key),
Review comment:
@robdiciuccio hmm... good point, actually I wanted avoid refactoring of a lot places in code, but now I see I think I can handle it, I also will add someone more to review, where I see that my refactor will affect his parts of code to be sure.
I pushed now refactored code as you proposed and asked @etr2460 to review also...
I also see that affected some code that @suddjian implemented, may be it can be good to add him as reviewer?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (0d8b758) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **increase** coverage by `0.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 63.37% 63.55% +0.17%
==========================================
Files 970 481 -489
Lines 47937 29682 -18255
Branches 4736 0 -4736
==========================================
- Hits 30380 18864 -11516
+ Misses 17370 10818 -6552
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.55% <ø> (-0.60%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.26% <0.00%> (-1.63%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.53%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <0.00%> (-0.27%)` | :arrow_down: |
| ... and [476 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...0d8b758](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (dc23d64) into [master](https://codecov.io/gh/apache/incubator-superset/commit/90ed3267e498f7c95a34f6703e534d69c9aed2db?el=desc) (90ed326) will **decrease** coverage by `1.98%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 66.58% 64.59% -1.99%
==========================================
Files 951 471 -480
Lines 46663 29028 -17635
Branches 4571 0 -4571
==========================================
- Hits 31070 18751 -12319
+ Misses 15456 10277 -5179
+ Partials 137 0 -137
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.59% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/utils/copy.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvcHkudHM=) | | |
| [superset-frontend/src/common/components/Fade.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0ZhZGUudHN4) | | |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | | |
| [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | | |
| [...perset-frontend/src/utils/DebouncedMessageQueue.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL0RlYm91bmNlZE1lc3NhZ2VRdWV1ZS5qcw==) | | |
| [...ntend/src/components/FacePile/FacePile.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmFjZVBpbGUvRmFjZVBpbGUuc3Rvcmllcy50c3g=) | | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | | |
| [...c/components/ErrorMessage/DatabaseErrorMessage.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0RhdGFiYXNlRXJyb3JNZXNzYWdlLnRzeA==) | | |
| [superset-frontend/src/showSavedQuery/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Nob3dTYXZlZFF1ZXJ5L2luZGV4LmpzeA==) | | |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | | |
| ... and [456 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [90ed326...dc23d64](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (197ba55) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **decrease** coverage by `0.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
- Coverage 63.37% 63.25% -0.13%
==========================================
Files 970 481 -489
Lines 47937 29667 -18270
Branches 4736 0 -4736
==========================================
- Hits 30380 18765 -11615
+ Misses 17370 10902 -6468
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.25% <ø> (-0.91%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [497 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...d6ffbf2](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (0d8b758) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **increase** coverage by `0.79%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 63.37% 64.17% +0.79%
==========================================
Files 970 481 -489
Lines 47937 29682 -18255
Branches 4736 0 -4736
==========================================
- Hits 30380 19048 -11332
+ Misses 17370 10634 -6736
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.17% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.37% <0.00%> (-0.08%)` | :arrow_down: |
| [superset-frontend/src/components/Timer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIudHN4) | | |
| [...et-frontend/src/dashboard/util/isDashboardEmpty.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzRGFzaGJvYXJkRW1wdHkudHM=) | | |
| [...perset-frontend/src/dashboard/util/findParentId.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2ZpbmRQYXJlbnRJZC5qcw==) | | |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | | |
| [...set-frontend/src/components/ListViewCard/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL2luZGV4LnRzeA==) | | |
| [superset-frontend/src/messageToasts/constants.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29uc3RhbnRzLnRz) | | |
| [...rc/explore/components/controls/TextAreaControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0QXJlYUNvbnRyb2wuanN4) | | |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | | |
| [superset-frontend/src/components/ListView/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdHlwZXMudHM=) | | |
| ... and [467 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...0d8b758](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (8428c07) into [master](https://codecov.io/gh/apache/incubator-superset/commit/022d7556401750c6bc28a081a6780fce2f4033fd?el=desc) (022d755) will **increase** coverage by `1.07%`.
> The diff coverage is `85.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 66.66% 67.73% +1.07%
==========================================
Files 951 951
Lines 46663 46675 +12
Branches 4571 4576 +5
==========================================
+ Hits 31106 31616 +510
+ Misses 15421 14946 -475
+ Partials 136 113 -23
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.21% <74.35%> (+7.10%)` | :arrow_up: |
| javascript | `62.62% <47.50%> (-0.04%)` | :arrow_down: |
| python | `64.59% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `57.14% <0.00%> (+0.77%)` | :arrow_up: |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `58.33% <ø> (ø)` | |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `75.00% <ø> (+25.00%)` | :arrow_up: |
| [...nd/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `77.27% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `100.00% <ø> (ø)` | |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `63.41% <85.71%> (+1.77%)` | :arrow_up: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.34% <100.00%> (ø)` | |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.23% <100.00%> (+4.28%)` | :arrow_up: |
| ... and [72 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [022d755...8428c07](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#discussion_r534705132
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -171,11 +171,18 @@ class SliceHeaderControls extends React.PureComponent {
addDangerToast,
isFullSize,
} = this.props;
- const cachedWhen = moment.utc(cachedDttm).fromNow();
+ const cachedWhen = cachedDttm.map(itemCachedDttm =>
+ moment.utc(itemCachedDttm).fromNow(),
+ );
const updatedWhen = updatedDttm ? moment.utc(updatedDttm).fromNow() : '';
- const refreshTooltip = isCached
- ? t('Cached %s', cachedWhen)
- : (updatedWhen && t('Fetched %s', updatedWhen)) || '';
+ const getCachedTitle = itemCached => {
+ return itemCached
+ ? t('Cached %s', cachedWhen)
+ : updatedWhen && t('Fetched %s', updatedWhen);
+ };
+ let refreshTooltip = isCached.map(getCachedTitle) || '';
+ // If all queries have same cache time we can unit them to one
+ refreshTooltip = [...new Set(refreshTooltip)].join(', ');
Review comment:
It's only emulation of 2 queries, by code changes, in real case:
1. if all queries have same cache time they will be squashed to one notification like it was before my change
2. if queries will have different time it will be shown like here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-736870437
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=h1) Report
> Merging [#11880](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=desc) (80460ea) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b592cc7e73a81f1ea97ad257d4472b7f48caf447?el=desc) (b592cc7) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11880 +/- ##
==========================================
+ Coverage 63.37% 63.38% +0.01%
==========================================
Files 970 481 -489
Lines 47937 29671 -18266
Branches 4736 0 -4736
==========================================
- Hits 30380 18807 -11573
+ Misses 17370 10864 -6506
+ Partials 187 0 -187
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.38% <ø> (-0.77%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.50% <0.00%> (-25.07%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.73% <0.00%> (-6.87%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [487 more](https://codecov.io/gh/apache/incubator-superset/pull/11880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=footer). Last update [b592cc7...80460ea](https://codecov.io/gh/apache/incubator-superset/pull/11880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on pull request #11880: feat: Support multiple queries per request
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on pull request #11880:
URL: https://github.com/apache/incubator-superset/pull/11880#issuecomment-737531899
Thanks for the context @villebro. Good to know the plan is not to modify the backend here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org