You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/07/13 09:37:29 UTC
[jira] Created: (HARMONY-860) [classlib][nio] Remove some
unnecessary codes and a FIXME from o.a.h.nio.internal.DatagramChannelImpl
[classlib][nio] Remove some unnecessary codes and a FIXME from o.a.h.nio.internal.DatagramChannelImpl
-----------------------------------------------------------------------------------------------------
Key: HARMONY-860
URL: http://issues.apache.org/jira/browse/HARMONY-860
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Andrew Zhang
Priority: Minor
There are some unnecessary codes in o.a.h.nio.internal.DatagramChannelImpl, includes:
1. duplicate exception check
2. an unnecessary FIXME which has been discussed on mailing list. [1]
I'll upload a patch to remove them.
Thanks!
[1] thread: Peek on DatagramChannel.receive(ByteBuffer)?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-860) [classlib][nio] Remove some
unnecessary codes and a FIXME from o.a.h.nio.internal.DatagramChannelImpl
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-860?page=all ]
George Harley resolved HARMONY-860.
-----------------------------------
Resolution: Fixed
Hi Andrew,
Changes committed in revision 421863. Please could you verify that they have been applied as expected.
Best regards,
George
> [classlib][nio] Remove some unnecessary codes and a FIXME from o.a.h.nio.internal.DatagramChannelImpl
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-860
> URL: http://issues.apache.org/jira/browse/HARMONY-860
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: George Harley
> Priority: Minor
> Attachments: DatagramChannelImpl.diff
>
>
> There are some unnecessary codes in o.a.h.nio.internal.DatagramChannelImpl, includes:
> 1. duplicate exception check
> 2. an unnecessary FIXME which has been discussed on mailing list. [1]
> I'll upload a patch to remove them.
> Thanks!
> [1] thread: Peek on DatagramChannel.receive(ByteBuffer)?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-860) [classlib][nio] Remove some
unnecessary codes and a FIXME from o.a.h.nio.internal.DatagramChannelImpl
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-860?page=all ]
Andrew Zhang updated HARMONY-860:
---------------------------------
Attachment: DatagramChannelImpl.diff
Hello,
Would you please try my patch?
Thanks!
Best regards,
Andrew
> [classlib][nio] Remove some unnecessary codes and a FIXME from o.a.h.nio.internal.DatagramChannelImpl
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-860
> URL: http://issues.apache.org/jira/browse/HARMONY-860
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Priority: Minor
> Attachments: DatagramChannelImpl.diff
>
> There are some unnecessary codes in o.a.h.nio.internal.DatagramChannelImpl, includes:
> 1. duplicate exception check
> 2. an unnecessary FIXME which has been discussed on mailing list. [1]
> I'll upload a patch to remove them.
> Thanks!
> [1] thread: Peek on DatagramChannel.receive(ByteBuffer)?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-860) [classlib][nio] Remove some
unnecessary codes and a FIXME from o.a.h.nio.internal.DatagramChannelImpl
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-860?page=all ]
George Harley reassigned HARMONY-860:
-------------------------------------
Assignee: George Harley
> [classlib][nio] Remove some unnecessary codes and a FIXME from o.a.h.nio.internal.DatagramChannelImpl
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-860
> URL: http://issues.apache.org/jira/browse/HARMONY-860
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: George Harley
> Priority: Minor
> Attachments: DatagramChannelImpl.diff
>
>
> There are some unnecessary codes in o.a.h.nio.internal.DatagramChannelImpl, includes:
> 1. duplicate exception check
> 2. an unnecessary FIXME which has been discussed on mailing list. [1]
> I'll upload a patch to remove them.
> Thanks!
> [1] thread: Peek on DatagramChannel.receive(ByteBuffer)?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-860) [classlib][nio] Remove some
unnecessary codes and a FIXME from o.a.h.nio.internal.DatagramChannelImpl
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-860?page=comments#action_12421497 ]
Andrew Zhang commented on HARMONY-860:
--------------------------------------
Hi George,
The fix looks good, thanks!
Best regards,
Andrew
> [classlib][nio] Remove some unnecessary codes and a FIXME from o.a.h.nio.internal.DatagramChannelImpl
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-860
> URL: http://issues.apache.org/jira/browse/HARMONY-860
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: George Harley
> Priority: Minor
> Attachments: DatagramChannelImpl.diff
>
>
> There are some unnecessary codes in o.a.h.nio.internal.DatagramChannelImpl, includes:
> 1. duplicate exception check
> 2. an unnecessary FIXME which has been discussed on mailing list. [1]
> I'll upload a patch to remove them.
> Thanks!
> [1] thread: Peek on DatagramChannel.receive(ByteBuffer)?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-860) [classlib][nio] Remove some
unnecessary codes and a FIXME from o.a.h.nio.internal.DatagramChannelImpl
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-860?page=all ]
George Harley closed HARMONY-860.
---------------------------------
Verified by Andrew.
> [classlib][nio] Remove some unnecessary codes and a FIXME from o.a.h.nio.internal.DatagramChannelImpl
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-860
> URL: http://issues.apache.org/jira/browse/HARMONY-860
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: George Harley
> Priority: Minor
> Attachments: DatagramChannelImpl.diff
>
>
> There are some unnecessary codes in o.a.h.nio.internal.DatagramChannelImpl, includes:
> 1. duplicate exception check
> 2. an unnecessary FIXME which has been discussed on mailing list. [1]
> I'll upload a patch to remove them.
> Thanks!
> [1] thread: Peek on DatagramChannel.receive(ByteBuffer)?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira