You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/01/13 22:44:54 UTC
[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4976: Fix
the exception in server instance when Helix starts a new ZK session
Jackie-Jiang opened a new pull request #4976: Fix the exception in server instance when Helix starts a new ZK session
URL: https://github.com/apache/incubator-pinot/pull/4976
ServerInstance.start() is called when Helix starts a new ZK session, and
can be called multiple times. We only need to start the server instance
once, and simply ignore the following invocations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4976: Fix the
exception in server instance when Helix starts a new ZK session
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged pull request #4976: Fix the exception in server instance when Helix starts a new ZK session
URL: https://github.com/apache/incubator-pinot/pull/4976
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on issue #4976: Fix the
exception in server instance when Helix starts a new ZK session
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4976: Fix the exception in server instance when Helix starts a new ZK session
URL: https://github.com/apache/incubator-pinot/pull/4976#issuecomment-573939599
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4976?src=pr&el=h1) Report
> Merging [#4976](https://codecov.io/gh/apache/incubator-pinot/pull/4976?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/e81e5303a2e6157bb3530c621c3b8ce748788a83?src=pr&el=desc) will **increase** coverage by `15.47%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4976 +/- ##
=============================================
+ Coverage 36.35% 51.82% +15.47%
- Complexity 0 12 +12
=============================================
Files 1174 1174
Lines 62244 62246 +2
Branches 9148 9148
=============================================
+ Hits 22627 32258 +9631
+ Misses 37596 27518 -10078
- Partials 2021 2470 +449
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4976?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/pinot/server/starter/ServerInstance.java](https://codecov.io/gh/apache/incubator-pinot/pull/4976/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9TZXJ2ZXJJbnN0YW5jZS5qYXZh) | `1.49% <0%> (-86.2%)` | `0 <0> (ø)` | |
| [...starter/helix/DefaultHelixStarterServerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4976/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9EZWZhdWx0SGVsaXhTdGFydGVyU2VydmVyQ29uZmlnLmphdmE=) | `0% <0%> (-96.16%)` | `0% <0%> (ø)` | |
| [...converter/stats/RealtimeSegmentStatsContainer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4976/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVTZWdtZW50U3RhdHNDb250YWluZXIuamF2YQ==) | `0% <0%> (-94.45%)` | `0% <0%> (ø)` | |
| [...rg/apache/pinot/tools/utils/KafkaStarterUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4976/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3V0aWxzL0thZmthU3RhcnRlclV0aWxzLmphdmE=) | `0% <0%> (-93.19%)` | `0% <0%> (ø)` | |
| [.../starter/helix/HelixInstanceDataManagerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4976/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeEluc3RhbmNlRGF0YU1hbmFnZXJDb25maWcuamF2YQ==) | `0% <0%> (-92.31%)` | `0% <0%> (ø)` | |
| [...ot/tools/query/comparison/SegmentInfoProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4976/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vU2VnbWVudEluZm9Qcm92aWRlci5qYXZh) | `0% <0%> (-88.68%)` | `0% <0%> (ø)` | |
| [.../transform/function/MapValueTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4976/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vTWFwVmFsdWVUcmFuc2Zvcm1GdW5jdGlvbi5qYXZh) | `0% <0%> (-85.3%)` | `0% <0%> (ø)` | |
| [...pache/pinot/server/starter/helix/SegmentLocks.java](https://codecov.io/gh/apache/incubator-pinot/pull/4976/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9TZWdtZW50TG9ja3MuamF2YQ==) | `0% <0%> (-83.34%)` | `0% <0%> (ø)` | |
| [...tools/query/comparison/StarTreeQueryGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4976/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vU3RhclRyZWVRdWVyeUdlbmVyYXRvci5qYXZh) | `0% <0%> (-82.84%)` | `0% <0%> (ø)` | |
| [...server/starter/helix/HelixInstanceDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4976/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeEluc3RhbmNlRGF0YU1hbmFnZXIuamF2YQ==) | `0% <0%> (-82.82%)` | `0% <0%> (ø)` | |
| ... and [678 more](https://codecov.io/gh/apache/incubator-pinot/pull/4976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4976?src=pr&el=footer). Last update [e81e530...32d476b](https://codecov.io/gh/apache/incubator-pinot/pull/4976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org