You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cactus-dev@jakarta.apache.org by "Jeff Glass (JIRA)" <ca...@jakarta.apache.org> on 2006/01/06 21:23:15 UTC
[jira] Created: (CACTUS-235) TestShareAll suite adds
TestHttpSession tests incorrectly
TestShareAll suite adds TestHttpSession tests incorrectly
---------------------------------------------------------
Key: CACTUS-235
URL: http://issues.apache.org/jira/browse/CACTUS-235
Project: Cactus
Type: Bug
Components: Servlet Sample
Versions: 1.7.1
Environment: Windows XP, WSAD 5.1.2
Reporter: Jeff Glass
Priority: Minor
The method org.apache.cactus.sample.servlet.unit.TestShareAll.suite() adds the TestHttpSession tests to the suite incorrectly. It doesn't call TestHttpSession.suite(), so the tests are not properly set up, and as a result TestHttpSession.beginDependentTestUsingSession2(WebRequest) throws a null-pointer exception (because this.dependentTest is null).
I found this problem when running the Cactus sample tests through a web browser (http://localhost:9080/testweb/ServletTestRunner?suite=org.apache.cactus.sample.servlet.unit.TestShareAll).
The patch follows.
/jeff
--- TestShareAll.java.orig 2006-01-06 14:54:00.663897700 -0500
+++ TestShareAll.java 2006-01-06 14:54:32.600776000 -0500
@@ -55,7 +55,7 @@
suite.addTestSuite(TestHttpUnitIntegration.class);
suite.addTestSuite(TestServletRedirectorOverride.class);
suite.addTestSuite(TestHttpParameters.class);
- suite.addTestSuite(TestHttpSession.class);
+ suite.addTest(TestHttpSession.suite());
suite.addTestSuite(TestHttpResponse.class);
suite.addTestSuite(TestCookie.class);
suite.addTestSuite(TestRequestDispatcher.class);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Closed: (CACTUS-235) TestShareAll suite adds TestHttpSession
tests incorrectly
Posted by "Petar Tahchiev (JIRA)" <ca...@jakarta.apache.org>.
[ https://issues.apache.org/jira/browse/CACTUS-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Petar Tahchiev closed CACTUS-235.
---------------------------------
> TestShareAll suite adds TestHttpSession tests incorrectly
> ---------------------------------------------------------
>
> Key: CACTUS-235
> URL: https://issues.apache.org/jira/browse/CACTUS-235
> Project: Cactus
> Issue Type: Bug
> Components: Servlet Sample
> Affects Versions: 1.7.1
> Environment: Windows XP, WSAD 5.1.2
> Reporter: Jeff Glass
> Assignee: Petar Tahchiev
> Priority: Minor
> Fix For: 1.8
>
>
> The method org.apache.cactus.sample.servlet.unit.TestShareAll.suite() adds the TestHttpSession tests to the suite incorrectly. It doesn't call TestHttpSession.suite(), so the tests are not properly set up, and as a result TestHttpSession.beginDependentTestUsingSession2(WebRequest) throws a null-pointer exception (because this.dependentTest is null).
> I found this problem when running the Cactus sample tests through a web browser (http://localhost:9080/testweb/ServletTestRunner?suite=org.apache.cactus.sample.servlet.unit.TestShareAll).
> The patch follows.
> /jeff
> --- TestShareAll.java.orig 2006-01-06 14:54:00.663897700 -0500
> +++ TestShareAll.java 2006-01-06 14:54:32.600776000 -0500
> @@ -55,7 +55,7 @@
> suite.addTestSuite(TestHttpUnitIntegration.class);
> suite.addTestSuite(TestServletRedirectorOverride.class);
> suite.addTestSuite(TestHttpParameters.class);
> - suite.addTestSuite(TestHttpSession.class);
> + suite.addTest(TestHttpSession.suite());
> suite.addTestSuite(TestHttpResponse.class);
> suite.addTestSuite(TestCookie.class);
> suite.addTestSuite(TestRequestDispatcher.class);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Resolved: (CACTUS-235) TestShareAll suite adds
TestHttpSession tests incorrectly
Posted by "Petar Tahchiev (JIRA)" <ca...@jakarta.apache.org>.
[ https://issues.apache.org/jira/browse/CACTUS-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Petar Tahchiev resolved CACTUS-235.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.8
Assignee: Petar Tahchiev
Applied Jeff's patch and everything works fine, so I am closing this issue.
> TestShareAll suite adds TestHttpSession tests incorrectly
> ---------------------------------------------------------
>
> Key: CACTUS-235
> URL: https://issues.apache.org/jira/browse/CACTUS-235
> Project: Cactus
> Issue Type: Bug
> Components: Servlet Sample
> Affects Versions: 1.7.1
> Environment: Windows XP, WSAD 5.1.2
> Reporter: Jeff Glass
> Assignee: Petar Tahchiev
> Priority: Minor
> Fix For: 1.8
>
>
> The method org.apache.cactus.sample.servlet.unit.TestShareAll.suite() adds the TestHttpSession tests to the suite incorrectly. It doesn't call TestHttpSession.suite(), so the tests are not properly set up, and as a result TestHttpSession.beginDependentTestUsingSession2(WebRequest) throws a null-pointer exception (because this.dependentTest is null).
> I found this problem when running the Cactus sample tests through a web browser (http://localhost:9080/testweb/ServletTestRunner?suite=org.apache.cactus.sample.servlet.unit.TestShareAll).
> The patch follows.
> /jeff
> --- TestShareAll.java.orig 2006-01-06 14:54:00.663897700 -0500
> +++ TestShareAll.java 2006-01-06 14:54:32.600776000 -0500
> @@ -55,7 +55,7 @@
> suite.addTestSuite(TestHttpUnitIntegration.class);
> suite.addTestSuite(TestServletRedirectorOverride.class);
> suite.addTestSuite(TestHttpParameters.class);
> - suite.addTestSuite(TestHttpSession.class);
> + suite.addTest(TestHttpSession.suite());
> suite.addTestSuite(TestHttpResponse.class);
> suite.addTestSuite(TestCookie.class);
> suite.addTestSuite(TestRequestDispatcher.class);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Commented: (CACTUS-235) TestShareAll suite adds
TestHttpSession tests incorrectly
Posted by "Petar Tahchiev (JIRA)" <ca...@jakarta.apache.org>.
[ https://issues.apache.org/jira/browse/CACTUS-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574295#action_12574295 ]
Petar Tahchiev commented on CACTUS-235:
---------------------------------------
Hi Jeff,
Thanks for the patch - I have already applied it in the trunk.
> TestShareAll suite adds TestHttpSession tests incorrectly
> ---------------------------------------------------------
>
> Key: CACTUS-235
> URL: https://issues.apache.org/jira/browse/CACTUS-235
> Project: Cactus
> Issue Type: Bug
> Components: Servlet Sample
> Affects Versions: 1.7.1
> Environment: Windows XP, WSAD 5.1.2
> Reporter: Jeff Glass
> Priority: Minor
> Fix For: 1.8
>
>
> The method org.apache.cactus.sample.servlet.unit.TestShareAll.suite() adds the TestHttpSession tests to the suite incorrectly. It doesn't call TestHttpSession.suite(), so the tests are not properly set up, and as a result TestHttpSession.beginDependentTestUsingSession2(WebRequest) throws a null-pointer exception (because this.dependentTest is null).
> I found this problem when running the Cactus sample tests through a web browser (http://localhost:9080/testweb/ServletTestRunner?suite=org.apache.cactus.sample.servlet.unit.TestShareAll).
> The patch follows.
> /jeff
> --- TestShareAll.java.orig 2006-01-06 14:54:00.663897700 -0500
> +++ TestShareAll.java 2006-01-06 14:54:32.600776000 -0500
> @@ -55,7 +55,7 @@
> suite.addTestSuite(TestHttpUnitIntegration.class);
> suite.addTestSuite(TestServletRedirectorOverride.class);
> suite.addTestSuite(TestHttpParameters.class);
> - suite.addTestSuite(TestHttpSession.class);
> + suite.addTest(TestHttpSession.suite());
> suite.addTestSuite(TestHttpResponse.class);
> suite.addTestSuite(TestCookie.class);
> suite.addTestSuite(TestRequestDispatcher.class);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org