You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/21 23:00:35 UTC

[GitHub] [spark] gengliangwang commented on a diff in pull request #39108: [SPARK-41428][UI] Protobuf serializer for SpeculationStageSummaryWrapper

gengliangwang commented on code in PR #39108:
URL: https://github.com/apache/spark/pull/39108#discussion_r1054918539


##########
core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto:
##########
@@ -244,3 +244,17 @@ message RDDStorageInfoWrapper {
 message ResourceProfileWrapper {
   ResourceProfileInfo rpInfo = 1;
 }
+
+message SpeculationStageSummary {
+  int32 num_tasks = 1;
+  int32 num_active_tasks = 2;
+  int32 num_completed_tasks = 3;
+  int32 num_failed_tasks = 4;
+  int32 num_killed_tasks = 5;
+}
+
+message SpeculationStageSummaryWrapper {
+  int32 stage_id = 1;

Review Comment:
   As per @mridulm , let's set all the stage/job/task id as int64 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org