You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Ashutosh Chauhan (JIRA)" <ji...@apache.org> on 2011/06/27 07:24:47 UTC

[jira] [Created] (HIVE-2239) Up the commons-codec version from 1.3 to 1.4

Up the commons-codec version from 1.3 to 1.4
--------------------------------------------

                 Key: HIVE-2239
                 URL: https://issues.apache.org/jira/browse/HIVE-2239
             Project: Hive
          Issue Type: Task
          Components: Contrib
            Reporter: Ashutosh Chauhan
            Assignee: Ashutosh Chauhan


Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2239) Up the commons-codec version from 1.3 to 1.4

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057029#comment-13057029 ] 

Ashutosh Chauhan commented on HIVE-2239:
----------------------------------------

Any word on this one?

> Up the commons-codec version from 1.3 to 1.4
> --------------------------------------------
>
>                 Key: HIVE-2239
>                 URL: https://issues.apache.org/jira/browse/HIVE-2239
>             Project: Hive
>          Issue Type: Task
>          Components: Contrib
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: commons-codec-1.4.jar
>
>
> Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2239) Up the commons-codec version from 1.3 to 1.4

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-2239:
-----------------------------

    Status: Patch Available  (was: Open)

> Up the commons-codec version from 1.3 to 1.4
> --------------------------------------------
>
>                 Key: HIVE-2239
>                 URL: https://issues.apache.org/jira/browse/HIVE-2239
>             Project: Hive
>          Issue Type: Task
>          Components: Build Infrastructure, Contrib
>    Affects Versions: 0.7.0, 0.6.0, 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: HIVE-2239.2.patch, hive-2239.patch
>
>
> Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2239) Up the commons-codec version from 1.3 to 1.4

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan updated HIVE-2239:
-----------------------------------

          Component/s: Build Infrastructure
    Affects Version/s: 0.8.0
                       0.6.0
                       0.7.0

> Up the commons-codec version from 1.3 to 1.4
> --------------------------------------------
>
>                 Key: HIVE-2239
>                 URL: https://issues.apache.org/jira/browse/HIVE-2239
>             Project: Hive
>          Issue Type: Task
>          Components: Build Infrastructure, Contrib
>    Affects Versions: 0.6.0, 0.7.0, 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: hive-2239.patch
>
>
> Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2239) Use the version commons-codec from Hadoop

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062685#comment-13062685 ] 

Carl Steinbach commented on HIVE-2239:
--------------------------------------

This patch broke the eclipse integration scripts.

bq. Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

Hive's execution mechanism ensures that Hadoop's classpath get's preference over Hive's. Since Hive seems to work with both version 1.3 and 1.4 of commons-codec, I'm having trouble seeing how this can cause problems.

> Use the version commons-codec from Hadoop
> -----------------------------------------
>
>                 Key: HIVE-2239
>                 URL: https://issues.apache.org/jira/browse/HIVE-2239
>             Project: Hive
>          Issue Type: Task
>          Components: Build Infrastructure, Contrib
>    Affects Versions: 0.6.0, 0.7.0, 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: HIVE-2239.2.patch, hive-2239.patch
>
>
> Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2239) Up the commons-codec version from 1.3 to 1.4

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-2239:
-----------------------------

    Attachment: HIVE-2239.2.patch

I was thinking we could just use the one from Hadoop directly (instead of fetching another copy from ivy), as in the attached HIVE-2239.2.patch.  I verified build as well as TestContribCliDriver with qfile=fileformat_base64.q.


> Up the commons-codec version from 1.3 to 1.4
> --------------------------------------------
>
>                 Key: HIVE-2239
>                 URL: https://issues.apache.org/jira/browse/HIVE-2239
>             Project: Hive
>          Issue Type: Task
>          Components: Build Infrastructure, Contrib
>    Affects Versions: 0.6.0, 0.7.0, 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: HIVE-2239.2.patch, hive-2239.patch
>
>
> Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2239) Up the commons-codec version from 1.3 to 1.4

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan updated HIVE-2239:
-----------------------------------

    Attachment:     (was: commons-codec-1.4.jar)

> Up the commons-codec version from 1.3 to 1.4
> --------------------------------------------
>
>                 Key: HIVE-2239
>                 URL: https://issues.apache.org/jira/browse/HIVE-2239
>             Project: Hive
>          Issue Type: Task
>          Components: Build Infrastructure, Contrib
>    Affects Versions: 0.6.0, 0.7.0, 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: hive-2239.patch
>
>
> Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2239) Up the commons-codec version from 1.3 to 1.4

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan updated HIVE-2239:
-----------------------------------

    Attachment: commons-codec-1.4.jar

I tested with commons-codec-1.4 and all the tests in contrib passed.

> Up the commons-codec version from 1.3 to 1.4
> --------------------------------------------
>
>                 Key: HIVE-2239
>                 URL: https://issues.apache.org/jira/browse/HIVE-2239
>             Project: Hive
>          Issue Type: Task
>          Components: Contrib
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: commons-codec-1.4.jar
>
>
> Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2239) Use the version commons-codec from Hadoop

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-2239:
-----------------------------

    Summary: Use the version commons-codec from Hadoop  (was: Up the commons-codec version from 1.3 to 1.4)

> Use the version commons-codec from Hadoop
> -----------------------------------------
>
>                 Key: HIVE-2239
>                 URL: https://issues.apache.org/jira/browse/HIVE-2239
>             Project: Hive
>          Issue Type: Task
>          Components: Build Infrastructure, Contrib
>    Affects Versions: 0.6.0, 0.7.0, 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: HIVE-2239.2.patch, hive-2239.patch
>
>
> Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2239) Use the version commons-codec from Hadoop

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060942#comment-13060942 ] 

Hudson commented on HIVE-2239:
------------------------------

Integrated in Hive-trunk-h0.21 #813 (See [https://builds.apache.org/job/Hive-trunk-h0.21/813/])
    HIVE-2239. Use the version of commons-codec from Hadoop
(Ashutosh Chauhan via jvs)

jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1143565
Files : 
* /hive/trunk/lib/commons-codec-1.3.jar
* /hive/trunk/lib/commons-codec-1.3.LICENSE
* /hive/trunk/build-common.xml


> Use the version commons-codec from Hadoop
> -----------------------------------------
>
>                 Key: HIVE-2239
>                 URL: https://issues.apache.org/jira/browse/HIVE-2239
>             Project: Hive
>          Issue Type: Task
>          Components: Build Infrastructure, Contrib
>    Affects Versions: 0.6.0, 0.7.0, 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: HIVE-2239.2.patch, hive-2239.patch
>
>
> Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2239) Up the commons-codec version from 1.3 to 1.4

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060131#comment-13060131 ] 

John Sichi commented on HIVE-2239:
----------------------------------

OK, will commit when tests pass.

> Up the commons-codec version from 1.3 to 1.4
> --------------------------------------------
>
>                 Key: HIVE-2239
>                 URL: https://issues.apache.org/jira/browse/HIVE-2239
>             Project: Hive
>          Issue Type: Task
>          Components: Build Infrastructure, Contrib
>    Affects Versions: 0.6.0, 0.7.0, 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: HIVE-2239.2.patch, hive-2239.patch
>
>
> Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2239) Up the commons-codec version from 1.3 to 1.4

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan updated HIVE-2239:
-----------------------------------

    Attachment: hive-2239.patch

Ok, at runtime we don't want to include any jar file which hadoop anyway will include in its classpath. For that we simply need to delete the existing jar file from ${hive-root}/lib and we will be good. However, doing so will make hive fail to compile. So, this patch retrieves the jar and put it in the build/ivy/lib/default so that it could be used at compile time (and also while running tests). This I think is the cleanest approach, since hive doesn't force any version and whichever hadoop is running it will use its version of jar file. I upped the version in ivy/libraries.properties since we need to up it one day in any case, but strictly that is not required. After applying this patch, please necessarily delete lib/common-codecs-1.3.jar

> Up the commons-codec version from 1.3 to 1.4
> --------------------------------------------
>
>                 Key: HIVE-2239
>                 URL: https://issues.apache.org/jira/browse/HIVE-2239
>             Project: Hive
>          Issue Type: Task
>          Components: Contrib
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: commons-codec-1.4.jar, hive-2239.patch
>
>
> Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2239) Up the commons-codec version from 1.3 to 1.4

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060126#comment-13060126 ] 

Ashutosh Chauhan commented on HIVE-2239:
----------------------------------------

Yup, your approach is cleaner then mine. 
+1

> Up the commons-codec version from 1.3 to 1.4
> --------------------------------------------
>
>                 Key: HIVE-2239
>                 URL: https://issues.apache.org/jira/browse/HIVE-2239
>             Project: Hive
>          Issue Type: Task
>          Components: Build Infrastructure, Contrib
>    Affects Versions: 0.6.0, 0.7.0, 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: HIVE-2239.2.patch, hive-2239.patch
>
>
> Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2239) Up the commons-codec version from 1.3 to 1.4

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055330#comment-13055330 ] 

Ashutosh Chauhan commented on HIVE-2239:
----------------------------------------

It was introduced as a dependency in https://issues.apache.org/jira/browse/HIVE-639 Seems like its not used in core hive anywhere only in contrib. Contrib dependencies in main build perhaps should not be there in first place, but now before removing we need to deprecate them. 
Its there in 0.21 https://issues.apache.org/jira/browse/HADOOP-6579 and has been backported to 20.203 as well http://hadoop.apache.org/common/docs/r0.20.203.0/changes.html so its a good time to upgrade this jar. 


> Up the commons-codec version from 1.3 to 1.4
> --------------------------------------------
>
>                 Key: HIVE-2239
>                 URL: https://issues.apache.org/jira/browse/HIVE-2239
>             Project: Hive
>          Issue Type: Task
>          Components: Contrib
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>
> Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2239) Up the commons-codec version from 1.3 to 1.4

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058738#comment-13058738 ] 

John Sichi commented on HIVE-2239:
----------------------------------

In the 0.20.1 Hadoop version we currently pull in for default Hive builds, the version is currently 1.3.  To avoid conflicts there, would it be possible to instead do a patch which just uses the version from Hadoop via commons-codec-*.jar (and then also delete the one from Hive as part of this commit)?


> Up the commons-codec version from 1.3 to 1.4
> --------------------------------------------
>
>                 Key: HIVE-2239
>                 URL: https://issues.apache.org/jira/browse/HIVE-2239
>             Project: Hive
>          Issue Type: Task
>          Components: Contrib
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: commons-codec-1.4.jar
>
>
> Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2239) Use the version commons-codec from Hadoop

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-2239:
-----------------------------

       Resolution: Fixed
    Fix Version/s: 0.8.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

Committed (+1 on my own final changes since they were trivial), thanks Ashutosh!


> Use the version commons-codec from Hadoop
> -----------------------------------------
>
>                 Key: HIVE-2239
>                 URL: https://issues.apache.org/jira/browse/HIVE-2239
>             Project: Hive
>          Issue Type: Task
>          Components: Build Infrastructure, Contrib
>    Affects Versions: 0.6.0, 0.7.0, 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: HIVE-2239.2.patch, hive-2239.patch
>
>
> Hadoop upgraded from 1.3 to 1.4. Since, hive is launched from hadoop scripts, it gets 1.4 from there and then it includes 1.3 itself. Having two different versions of same jar causes unwanted grief.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira