You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by "Hiram Chirino (JIRA)" <ji...@apache.org> on 2012/11/12 12:31:12 UTC
[jira] [Created] (PROTON-126) Sender.send should return 0 once it
has exceeded the credit window
Hiram Chirino created PROTON-126:
------------------------------------
Summary: Sender.send should return 0 once it has exceeded the credit window
Key: PROTON-126
URL: https://issues.apache.org/jira/browse/PROTON-126
Project: Qpid Proton
Issue Type: Bug
Components: proton-j
Reporter: Hiram Chirino
No flow control is in place. You can easily OOM a JVM since Sender.send continues to accept more bytes even if the peer is not accepting anymore data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-126) Sender.send should return 0 once it
has exceeded the credit window
Posted by "Rafael H. Schloming (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495224#comment-13495224 ]
Rafael H. Schloming commented on PROTON-126:
--------------------------------------------
This behaviour is by design. The idea is that you can choose to have the engine buffer message data for you if you wish. This is very useful for certain kinds of implementations (e.g. clients). If you want to avoid this you can check the credit level before you call send or alternatively (for a slightly different effect) you could check how many queued messages the sender is holding and choose whether or not you want to queue more.
> Sender.send should return 0 once it has exceeded the credit window
> ------------------------------------------------------------------
>
> Key: PROTON-126
> URL: https://issues.apache.org/jira/browse/PROTON-126
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Reporter: Hiram Chirino
>
> No flow control is in place. You can easily OOM a JVM since Sender.send continues to accept more bytes even if the peer is not accepting anymore data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-126) Sender.send should return 0 once it
has exceeded the credit window
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495287#comment-13495287 ]
Hiram Chirino commented on PROTON-126:
--------------------------------------
Ok, makes sense. Would be nice to also get the queued size in bytes and not just messages. That way I can flow control myself after a couple queued message if they are large.
> Sender.send should return 0 once it has exceeded the credit window
> ------------------------------------------------------------------
>
> Key: PROTON-126
> URL: https://issues.apache.org/jira/browse/PROTON-126
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Reporter: Hiram Chirino
>
> No flow control is in place. You can easily OOM a JVM since Sender.send continues to accept more bytes even if the peer is not accepting anymore data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-126) Sender.send should return void
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated PROTON-126:
---------------------------------
Summary: Sender.send should return void (was: Sender.send should return 0 once it has exceeded the credit window)
> Sender.send should return void
> ------------------------------
>
> Key: PROTON-126
> URL: https://issues.apache.org/jira/browse/PROTON-126
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Reporter: Hiram Chirino
>
> No flow control is in place. You can easily OOM a JVM since Sender.send continues to accept more bytes even if the peer is not accepting anymore data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-126) Sender.send should return 0 once it
has exceeded the credit window
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495362#comment-13495362 ]
Hiram Chirino commented on PROTON-126:
--------------------------------------
Opened up PROTON-128 for that. Perhaps send should return void if it's always supposed to fully consume the full it's given.
> Sender.send should return 0 once it has exceeded the credit window
> ------------------------------------------------------------------
>
> Key: PROTON-126
> URL: https://issues.apache.org/jira/browse/PROTON-126
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Reporter: Hiram Chirino
>
> No flow control is in place. You can easily OOM a JVM since Sender.send continues to accept more bytes even if the peer is not accepting anymore data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-126) Sender.send should return 0 once it
has exceeded the credit window
Posted by "Rafael H. Schloming (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495339#comment-13495339 ]
Rafael H. Schloming commented on PROTON-126:
--------------------------------------------
That's a good point. Want me to change this to said RFE or should we file that separately?
> Sender.send should return 0 once it has exceeded the credit window
> ------------------------------------------------------------------
>
> Key: PROTON-126
> URL: https://issues.apache.org/jira/browse/PROTON-126
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Reporter: Hiram Chirino
>
> No flow control is in place. You can easily OOM a JVM since Sender.send continues to accept more bytes even if the peer is not accepting anymore data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira