You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by bufferoverflow <gi...@git.apache.org> on 2015/05/15 12:06:29 UTC

[GitHub] thrift pull request: THRIFT-2850 CMake: improve Windows support

GitHub user bufferoverflow opened a pull request:

    https://github.com/apache/thrift/pull/494

    THRIFT-2850 CMake: improve Windows support

    use YY_NO_UNISTD_H and remove --wincompat
    
    Signed-off-by: Roger Meier <ro...@apache.org>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bufferoverflow/thrift THRIFT-2850

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/494.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #494
    
----
commit 847ccf8b378eeea2e03682d93cb063293af0c7e3
Author: Roger Meier <ro...@apache.org>
Date:   2015-05-15T10:01:38Z

    THRIFT-2850 CMake: improve Windows support
    
    use YY_NO_UNISTD_H and remove --wincompat
    
    Signed-off-by: Roger Meier <ro...@apache.org>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2850 CMake: improve Windows support

Posted by bufferoverflow <gi...@git.apache.org>.
Github user bufferoverflow closed the pull request at:

    https://github.com/apache/thrift/pull/494


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2850 CMake: improve Windows support

Posted by bufferoverflow <gi...@git.apache.org>.
Github user bufferoverflow commented on the pull request:

    https://github.com/apache/thrift/pull/494#issuecomment-102401826
  
    committed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---