You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/01/01 01:33:13 UTC
[GitHub] [pulsar] sijie commented on a change in pull request #5942: Avoid
using same OpAddEntry between different ledger handles
sijie commented on a change in pull request #5942: Avoid using same OpAddEntry between different ledger handles
URL: https://github.com/apache/pulsar/pull/5942#discussion_r362297612
##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java
##########
@@ -43,12 +43,14 @@
*
*/
class OpAddEntry extends SafeRunnable implements AddCallback, CloseCallback {
- private ManagedLedgerImpl ml;
+ protected ManagedLedgerImpl ml;
LedgerHandle ledger;
private long entryId;
@SuppressWarnings("unused")
- private volatile AddEntryCallback callback;
+ private static final AtomicReferenceFieldUpdater<OpAddEntry, AddEntryCallback> callbackUpdater =
Review comment:
do we need the change here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services