You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/28 12:49:28 UTC

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #417: [FLINK-29655] Split Flink CRD from flink-kubernates-operator module

gyfora commented on code in PR #417:
URL: https://github.com/apache/flink-kubernetes-operator/pull/417#discussion_r1008028628


##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/crd/status/ReconciliationMetadata.java:
##########
@@ -15,10 +15,9 @@
  * limitations under the License.
  */
 
-package org.apache.flink.kubernetes.operator.reconciler;
+package org.apache.flink.kubernetes.operator.crd.status;

Review Comment:
   I suggest keeping this out of the `crd` package. It is internal to the operator logic and moving it under the CRD pollutes the CRD ref docs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org