[GitHub] [cassandra] maedhroz commented on a change in pull request #666: CASSANDRA-15907 Operational Improvements & Hardening for Replica Filtering Protection

[GitBox <gi...@apache.org>]

maedhroz commented on a change in pull request #666:
URL: https://github.com/apache/cassandra/pull/666#discussion_r461969628



##########
File path: src/java/org/apache/cassandra/service/reads/ReplicaFilteringProtection.java
##########
@@ -510,23 +482,69 @@ public Unfiltered next()
             };
         }
 
-        private UnfilteredRowIterator protectedPartition(int source)
+        private UnfilteredRowIterator protectedPartition()
         {
             UnfilteredRowIterator original = originalPartition();
 
             if (toFetch != null)
             {
-                UnfilteredPartitionIterator fetchedPartition = querySourceOnKey(source, partitionKey, toFetch);
-                if (fetchedPartition.hasNext())
+                try (UnfilteredPartitionIterator partitions = fetchFromSource())

Review comment:
       @adelapena This is a separate tiny commit in the 3.11 PR, FYI




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org