You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "phongn (via GitHub)" <gi...@apache.org> on 2023/11/17 21:23:18 UTC

[PR] Remove HAVE_MALLOC_H and HAVE_MCHECK_H headers [trafficserver]

phongn opened a new pull request, #10822:
URL: https://github.com/apache/trafficserver/pull/10822

   Replace automake-style `HAVE_INCLUDE_H` compile flags with `#if __has_include` preprocessor directives.
   
   This PR does so for `malloc.h` and `mcheck.h`. In addition, the search path for `malloc.h` is extended to add `<malloc/malloc.h>` (on macOS) and the symbol flag `HAVE_MALLOC_USABLE_SIZE` now looks for `malloc_np.h` (commonly used on FreeBSD). 
   
   Addendum: More recent version of macOS include a `malloc_size` call similar to `malloc_usable_size` on other architectures. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove HAVE_MALLOC_H and HAVE_MCHECK_H build vars [trafficserver]

Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on PR #10822:
URL: https://github.com/apache/trafficserver/pull/10822#issuecomment-1885103153

   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove HAVE_MALLOC_H and HAVE_MCHECK_H build vars [trafficserver]

Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on PR #10822:
URL: https://github.com/apache/trafficserver/pull/10822#issuecomment-1885203402

   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove HAVE_MALLOC_H and HAVE_MCHECK_H build vars [trafficserver]

Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on PR #10822:
URL: https://github.com/apache/trafficserver/pull/10822#issuecomment-1889681107

   @cmcfarlen this had to be rebased, your approval got tossed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove HAVE_MALLOC_H and HAVE_MCHECK_H build vars [trafficserver]

Posted by "phongn (via GitHub)" <gi...@apache.org>.
phongn commented on PR #10822:
URL: https://github.com/apache/trafficserver/pull/10822#issuecomment-1830539055

   [approve ci ubuntu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove HAVE_MALLOC_H and HAVE_MCHECK_H build vars [trafficserver]

Posted by "phongn (via GitHub)" <gi...@apache.org>.
phongn closed pull request #10822: Remove HAVE_MALLOC_H and HAVE_MCHECK_H build vars
URL: https://github.com/apache/trafficserver/pull/10822


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove HAVE_MALLOC_H and HAVE_MCHECK_H build vars [trafficserver]

Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10822:
URL: https://github.com/apache/trafficserver/pull/10822#issuecomment-1889625562

   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org