[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #2083: Support sql mode

[GitBox <gi...@apache.org>]

kangpinghuang commented on a change in pull request #2083: Support sql mode
URL: https://github.com/apache/incubator-doris/pull/2083#discussion_r339516599
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/SysVariableDesc.java
 ##########
 @@ -63,6 +67,13 @@ public Expr clone() {
     @Override
     public void analyzeImpl(Analyzer analyzer) throws AnalysisException {
         VariableMgr.fillValue(analyzer.getContext().getSessionVariable(), this);
+        if (!Strings.isNullOrEmpty(name) && name.equalsIgnoreCase(SessionVariable.SQL_MODE)) {
+            if (!SqlModeHelper.checkValid(intValue)) {
+                throw new AnalysisException("Unsupported sql mode found in session variables");
 
 Review comment:
   add intValue to Exception msg

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org