You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/29 09:08:05 UTC
[GitHub] [incubator-doris] SWJTU-ZhangLei opened a new pull request, #9318: [fix](backports) fix memory leak in VDataStreamRecvr::SenderQueue (#8643)
SWJTU-ZhangLei opened a new pull request, #9318:
URL: https://github.com/apache/incubator-doris/pull/9318
backports from https://github.com/apache/incubator-doris/pull/8643
After `VDataStreamRecvr::SenderQueue::close` clears `_block_queue`, calling
`VDataStreamRecvr::SenderQueue::add_block` again will cause a memory leak.
So, change the lock position, like the other add_block and add_batch.
(cherry picked from commit ea45940ef0c0b893f48b09320f248f8e44505c2a)
Signed-off-by: SWJTU-ZhangLei <10...@qq.com>
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] SWJTU-ZhangLei commented on pull request #9318: [fix](backports) fix memory leak in VDataStreamRecvr::SenderQueue (#8643)
Posted by GitBox <gi...@apache.org>.
SWJTU-ZhangLei commented on PR #9318:
URL: https://github.com/apache/incubator-doris/pull/9318#issuecomment-1113128104
@morningman i will close this pr soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei closed pull request #9318: [fix](backports) fix memory leak in VDataStreamRecvr::SenderQueue (#8643)
Posted by GitBox <gi...@apache.org>.
yiguolei closed pull request #9318: [fix](backports) fix memory leak in VDataStreamRecvr::SenderQueue (#8643)
URL: https://github.com/apache/incubator-doris/pull/9318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9318: [fix](backports) fix memory leak in VDataStreamRecvr::SenderQueue (#8643)
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9318:
URL: https://github.com/apache/incubator-doris/pull/9318#issuecomment-1113123503
hi @SWJTU-ZhangLei , you need to merge to master branch , not dev-1.0.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org