[GitHub] [pinot] walterddr commented on a change in pull request #8103: fix check before creating a table

[GitBox <gi...@apache.org>]

walterddr commented on a change in pull request #8103:
URL: https://github.com/apache/pinot/pull/8103#discussion_r798889003



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1261,13 +1261,12 @@ public void addTable(TableConfig tableConfig)
     validateTableTenantConfig(tableConfig);
     String tableNameWithType = tableConfig.getTableName();
     SegmentsValidationAndRetentionConfig segmentsConfig = tableConfig.getValidationConfig();
-
     TableType tableType = tableConfig.getTableType();
     switch (tableType) {
       case OFFLINE:
         // existing tooling relies on this check not existing for realtime table (to migrate to LLC)

Review comment:
       is this issue fixed? we should probably do this check on all table types. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org