You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/09/02 21:32:27 UTC
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 7:32 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
Diff: https://reviews.apache.org/r/37282/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/#review98181
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Sept. 3, 2015, 3:32 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37282/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2015, 3:32 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
> src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
> src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
> src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
> src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
>
> Diff: https://reviews.apache.org/r/37282/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 12:54 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Changes
-------
Added new-line.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
Diff: https://reviews.apache.org/r/37282/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/#review98802
-----------------------------------------------------------
Ship it!
Still a Ship It, just a minor nit.
src/messages/messages.proto (line 171)
<https://reviews.apache.org/r/37282/#comment155397>
Can we put a newline above this please? Thanks!
- Benjamin Hindman
On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37282/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2015, 8:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
> src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
> src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
> src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
> src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
>
> Diff: https://reviews.apache.org/r/37282/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/
-----------------------------------------------------------
(Updated Sept. 13, 2015, 8:33 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
Diff: https://reviews.apache.org/r/37282/diff/
Testing
-------
Thanks,
Joris Van Remoortere