You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "artemlivshits (via GitHub)" <gi...@apache.org> on 2024/12/25 00:22:56 UTC
[PR] KAFKA-15370: Support Participation in 2PC (KIP-939) (2/N) [kafka]
artemlivshits opened a new pull request, #18316:
URL: https://github.com/apache/kafka/pull/18316
Update producer id request / response formats and transaction log value format. There is no functional change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15370: Support Participation in 2PC (KIP-939) (2/N) [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan merged PR #18316:
URL: https://github.com/apache/kafka/pull/18316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15370: Support Participation in 2PC (KIP-939) (2/N) [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #18316:
URL: https://github.com/apache/kafka/pull/18316#discussion_r1897014037
##########
clients/src/main/resources/common/message/InitProducerIdResponse.json:
##########
@@ -36,6 +38,10 @@
{ "name": "ProducerId", "type": "int64", "versions": "0+", "entityType": "producerId",
"default": -1, "about": "The current producer id." },
{ "name": "ProducerEpoch", "type": "int16", "versions": "0+",
- "about": "The current epoch associated with the producer id." }
+ "about": "The current epoch associated with the producer id." },
+ { "name": "OngoingTxnProducerId", "type": "int64", "versions": "6+", "entityType": "producerId",
+ "default": -1, "about": "The producer id for ongoing transaction when KeepPreparedTxn is used, -1 if there is no transaction ongoing." },
+ { "name": "OngoingTxnProducerEpoch", "type": "int16", "versions": "6+",
Review Comment:
Did we want to explicitly set the default to -1 for both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org