You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/07/14 20:32:13 UTC
[GitHub] [cordova-android] brodybits commented on issue #767: npm test fails
on Node 12
brodybits commented on issue #767: npm test fails on Node 12
URL: https://github.com/apache/cordova-android/issues/767#issuecomment-511233173
The explanation is that the following lines will lead to different results depending on what order `Array.prototype.sort()` follows when comparing the elements: https://github.com/apache/cordova-android/blob/rel/8.0.0/bin/templates/cordova/lib/builders/ProjectBuilder.js#L304-L318
I just raised PR #779 which gives consistent order on Node.js versions 6, 8, 10, and 12.
Thanks to @breautek for reporting this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org