You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/03/22 23:46:59 UTC
[kudu-CR] [thirdparty] upgrade bison up to 3.8.2
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21192
Change subject: [thirdparty] upgrade bison up to 3.8.2
......................................................................
[thirdparty] upgrade bison up to 3.8.2
This patch updates the bison library in Kudu's 3rd-party from 3.5.4 to
3.8.2 version.
The rationale behind the upgrade was getting the following build error
on macOS when building with clang 15.0.0 which comes with Xcode 15.3:
kudu/thirdparty/src/bison-3.5.4/lib/obstack.c:351:31: error: incompatible function pointer types initializing 'void (*)(void) __attribute__((noreturn))' with an expression of type 'void (void)' [-Wincompatible-function-pointer-types]
__attribute_noreturn__ void (*obstack_alloc_failed_handler) (void)
^
1 error generated.
make[2]: *** [lib/libbison_a-obstack.o] Error 1
Change-Id: I93382dd06fcc86d34b5f63b02fb6e52859dcc558
---
M thirdparty/vars.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/21192/1
--
To view, visit http://gerrit.cloudera.org:8080/21192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93382dd06fcc86d34b5f63b02fb6e52859dcc558
Gerrit-Change-Number: 21192
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [thirdparty] upgrade bison up to 3.8.2
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21192 )
Change subject: [thirdparty] upgrade bison up to 3.8.2
......................................................................
[thirdparty] upgrade bison up to 3.8.2
This patch updates the bison library in Kudu's 3rd-party from 3.5.4 to
3.8.2 version.
The rationale behind the upgrade was getting the following build error
on macOS when building with clang 15.0.0 which comes with Xcode 15.3:
kudu/thirdparty/src/bison-3.5.4/lib/obstack.c:351:31: error: incompatible function pointer types initializing 'void (*)(void) __attribute__((noreturn))' with an expression of type 'void (void)' [-Wincompatible-function-pointer-types]
__attribute_noreturn__ void (*obstack_alloc_failed_handler) (void)
^
1 error generated.
make[2]: *** [lib/libbison_a-obstack.o] Error 1
Change-Id: I93382dd06fcc86d34b5f63b02fb6e52859dcc558
Reviewed-on: http://gerrit.cloudera.org:8080/21192
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M thirdparty/vars.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/21192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I93382dd06fcc86d34b5f63b02fb6e52859dcc558
Gerrit-Change-Number: 21192
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] upgrade bison up to 3.8.2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21192 )
Change subject: [thirdparty] upgrade bison up to 3.8.2
......................................................................
Patch Set 1: Verified+1
unrelated test failures
--
To view, visit http://gerrit.cloudera.org:8080/21192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93382dd06fcc86d34b5f63b02fb6e52859dcc558
Gerrit-Change-Number: 21192
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 23 Mar 2024 15:22:47 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade bison up to 3.8.2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [thirdparty] upgrade bison up to 3.8.2
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I93382dd06fcc86d34b5f63b02fb6e52859dcc558
Gerrit-Change-Number: 21192
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] upgrade bison up to 3.8.2
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21192 )
Change subject: [thirdparty] upgrade bison up to 3.8.2
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93382dd06fcc86d34b5f63b02fb6e52859dcc558
Gerrit-Change-Number: 21192
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 25 Mar 2024 16:32:11 +0000
Gerrit-HasComments: No