You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Randy Abernethy (JIRA)" <ji...@apache.org> on 2013/09/06 10:10:52 UTC
[jira] [Comment Edited] (THRIFT-2167) nodejs lib throws error if
options argument isn't passed
[ https://issues.apache.org/jira/browse/THRIFT-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13760037#comment-13760037 ]
Randy Abernethy edited comment on THRIFT-2167 at 9/6/13 8:08 AM:
-----------------------------------------------------------------
Hi Red,
I have see this before. The option problem is in connection.js. There is also another problem with the client/server examples not working which has to do with the compiler generated node client. This bug was recently introduced. The attached patch fixes both issues. If you apply the patch you should be able to run the client/server examples again. Let me know if you have any problems.
Best,
Randy
was (Author: codesf):
Hi Red,
I have see this before. The option problem is in connection.js. There is also another problem with the client/server examples not working which has to do with the compiler generated node client. A bug was recently introduced the attached patch fixes both. If you apply the patch you should be able to run the client/server examples again. Let me know if you have any problems.
Best,
Randy
> nodejs lib throws error if options argument isn't passed
> --------------------------------------------------------
>
> Key: THRIFT-2167
> URL: https://issues.apache.org/jira/browse/THRIFT-2167
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Reporter: Red Daly
> Priority: Trivial
> Attachments: 0001-fix-for-undefined-options-and-undefined-seq_id-bugs.patch, thrift-2167-fix-options.patch
>
> Original Estimate: 2m
> Remaining Estimate: 2m
>
> exports.Connection is a function of two arguments: stream and options. Options is an optional argument, but the function fails if it is omitted. This behavior (function failing) is a bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira