You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2012/09/20 16:26:07 UTC
[jira] [Created] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Robbie Gemmell created QPID-4334:
------------------------------------
Summary: [Java broker] move the Firewall functionality into the ACL plugin
Key: QPID-4334
URL: https://issues.apache.org/jira/browse/QPID-4334
Project: Qpid
Issue Type: Improvement
Components: Java Broker
Reporter: Robbie Gemmell
Fix For: 0.19
Firewall rules are currently expressed separately from ACls, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey updated QPID-4334:
--------------------------------
Attachment: 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
attached docbook patch
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch, 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
>
>
> Firewall rules are currently expressed separately from ACls, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey updated QPID-4334:
--------------------------------
Attachment: 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
attached docbook patch
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Philip Harvey
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-addressed-Keith-s-review-comments.-Also-mo.patch, 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch, 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
>
>
> Firewall rules are currently expressed separately from ACLs, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey reassigned QPID-4334:
-----------------------------------
Assignee: Philip Harvey
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Philip Harvey
> Fix For: 0.19
>
>
> Firewall rules are currently expressed separately from ACls, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465580#comment-13465580 ]
Keith Wall commented on QPID-4334:
----------------------------------
Patch applied. Reassigning back to Phil for the completion of the docs.
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-addressed-Keith-s-review-comments.-Also-mo.patch, 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch, 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
>
>
> Firewall rules are currently expressed separately from ACls, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey updated QPID-4334:
--------------------------------
Attachment: 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
attached docbook patch (not yet complete)
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch, 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
>
>
> Firewall rules are currently expressed separately from ACls, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey updated QPID-4334:
--------------------------------
Attachment: (was: 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch)
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch, 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
>
>
> Firewall rules are currently expressed separately from ACls, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465491#comment-13465491 ]
Keith Wall commented on QPID-4334:
----------------------------------
Hi Phil
Looks good, I just have a couple of comments, I think most of which are actually against the original implementation.
AclRulePredicates.java
64 - Guard debug logging
Action.java
77 - public setOperation, setObjectType, setProperties could be private and members final
107 - comment re compareTo seems spurious
112 - the refactoring means we now always evaluate operation, objectType and properties rather than potentially short circuiting earlier. Also could properties ever end up being null?
PlainConfiguration.jav
75 - load should be closing the underlying reader
HostnameFirewallRule.java
68 - Add the IP that failed to lookup to the text of the AccessControlFirewallException
100 - I think we should be logging at warn the case where rDNS lookups are failing/timing out. I worry that a sporadic DNS failure might lead to mysterious Java Broker defect reports.
{code}
public String call()
{
boolean success = false;
try
{
String hn = remote.getCanonicalHostName();
success = true;
return hn;
}
finally
{
if (!success)
{
log.warn("Failed to get canonical for " + ip + ", DNS timeout or error.");.
}
}
}
{code}
InetAddress.java
100 - confusing braces
177 - seemingly unnecessary use of reflection. InetAddress.getByAddress has been part of the API since 1.4
AccessControlFirewallException.java/InetNetwork.java
code style (brace positions)
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch, 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
>
>
> Firewall rules are currently expressed separately from ACls, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Closed] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall closed QPID-4334.
----------------------------
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Philip Harvey
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-addressed-Keith-s-review-comments.-Also-mo.patch, 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch, 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
>
>
> Firewall rules are currently expressed separately from ACLs, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465645#comment-13465645 ]
Keith Wall commented on QPID-4334:
----------------------------------
Patch applied. No comments.
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Philip Harvey
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-addressed-Keith-s-review-comments.-Also-mo.patch, 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch, 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
>
>
> Firewall rules are currently expressed separately from ACLs, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Resolved] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall resolved QPID-4334.
------------------------------
Resolution: Fixed
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Philip Harvey
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-addressed-Keith-s-review-comments.-Also-mo.patch, 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch, 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
>
>
> Firewall rules are currently expressed separately from ACLs, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey updated QPID-4334:
--------------------------------
Attachment: 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
attached docbook patch
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Philip Harvey
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-addressed-Keith-s-review-comments.-Also-mo.patch, 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch, 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
>
>
> Firewall rules are currently expressed separately from ACLs, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-4334:
--------------------------------
Assignee: Keith Wall (was: Philip Harvey)
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch
>
>
> Firewall rules are currently expressed separately from ACls, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-4334:
--------------------------------
Assignee: Philip Harvey (was: Keith Wall)
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Philip Harvey
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-addressed-Keith-s-review-comments.-Also-mo.patch, 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch, 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
>
>
> Firewall rules are currently expressed separately from ACls, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey updated QPID-4334:
--------------------------------
Attachment: 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch
Attached patch for review.
Note that the corresponding docbook updates are outstanding. I will attach a patch for these separately.
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Philip Harvey
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch
>
>
> Firewall rules are currently expressed separately from ACls, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4334:
-----------------------------
Status: Ready To Review (was: In Progress)
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Philip Harvey
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch
>
>
> Firewall rules are currently expressed separately from ACls, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465581#comment-13465581 ]
Keith Wall commented on QPID-4334:
----------------------------------
Patch applied. Reassigning back to Phil for the completion of the docs.
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-addressed-Keith-s-review-comments.-Also-mo.patch, 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch, 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
>
>
> Firewall rules are currently expressed separately from ACls, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey updated QPID-4334:
--------------------------------
Attachment: 0001-QPID-4334-addressed-Keith-s-review-comments.-Also-mo.patch
Thanks for the review comments Keith. Here is a further patch that addresses your feedback.
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-addressed-Keith-s-review-comments.-Also-mo.patch, 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch, 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
>
>
> Firewall rules are currently expressed separately from ACls, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4334:
-----------------------------
Description:
Firewall rules are currently expressed separately from ACLs, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
was:
Firewall rules are currently expressed separately from ACls, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Philip Harvey
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-addressed-Keith-s-review-comments.-Also-mo.patch, 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch, 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
>
>
> Firewall rules are currently expressed separately from ACLs, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey updated QPID-4334:
--------------------------------
Attachment: (was: 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch)
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Philip Harvey
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-addressed-Keith-s-review-comments.-Also-mo.patch, 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch
>
>
> Firewall rules are currently expressed separately from ACLs, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4334) [Java broker] move the Firewall
functionality into the ACL plugin
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey updated QPID-4334:
--------------------------------
Attachment: (was: 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch)
> [Java broker] move the Firewall functionality into the ACL plugin
> -----------------------------------------------------------------
>
> Key: QPID-4334
> URL: https://issues.apache.org/jira/browse/QPID-4334
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Philip Harvey
> Fix For: 0.19
>
> Attachments: 0001-QPID-4334-addressed-Keith-s-review-comments.-Also-mo.patch, 0001-QPID-4334-removed-the-firewall-plugin-and-moved-its-.patch, 0001-QPID-4334-updated-the-Java-ACL-docbook-to-mention-it.patch
>
>
> Firewall rules are currently expressed separately from ACLs, but this plugin is effectively an access control plugin and it is felt that the functionality would thus be better expressed using ACL rules. Such request has been made in the past, including a patch for the C++ broker as in use by a user.
> The firewall functionality will be moved into the ACL plugin, and the firewall plugin removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org