[jira] Commented: (OFBIZ-431) Editting Order goes recursive with promotions...

["Scott Gray (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462190 ] 

Scott Gray commented on OFBIZ-431:
----------------------------------

Hi Jacques

Sorry, I must have missed your comment above.  
I gave up on fixing this as it was a little too complex for me, but if no one is going to look at this any time soon I will have another go.  So please anyone, if you are planning on working on this let me know so that I don't start on it in vain.

Thanks
Scott

> Editting Order goes recursive with promotions...
> ------------------------------------------------
>
>                 Key: OFBIZ-431
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-431
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: N/A - clean default
>            Reporter: Ray Barlow
>         Assigned To: Jacopo Cappellato
>            Priority: Critical
>
> With the standard demo data raise an order for admin with 1 GZ-1000 and 1 GZ-7000, 3 promotional products will be added to the order which is fine.
> Find and view the newly created order in the order application. Click on the edit link and then try to increase the order quantity of the GZ-1000 from 1 to 2, the system will thrash away for a while and then fail with a transaction error, timed out.
> Once the dust has settled you can see that the party has also been sent 100 +/-5 email notification changes, which is were I'm getting the feeling that recursion is the problem!
> Trying to cancel a line item can also cause the same effect, in general editting orders with promotions seems to cause lots of problems at the moment.
> PS: I'd advise this only gets tested on local development machines as the impact is quite an intense load on the server and can result in DoS style problems. That said I did execute this once on the "demo.dejc.com" server (sorry David) just to check it wasn't anything I'd changed, the admin account now has a lot of order change notifications (at least until the next reload of the site!).
> PPS: This can also be triggered via the customer facing site, when cancelling a line item from the order history page, bit of an exposure for live sites to DoS from malicious users.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira