You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/09 19:02:36 UTC
[GitHub] [airflow] jmcarp opened a new pull request #14685: Add job labels to bigquery check operators.
jmcarp opened a new pull request #14685:
URL: https://github.com/apache/airflow/pull/14685
Add optional job labels to bigquery check operators. Checks can be expensive, so it would be useful to be able to annotate check queries with job labels for later analysis as with other bigquery operators.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmcarp merged pull request #14685: Add job labels to bigquery check operators.
Posted by GitBox <gi...@apache.org>.
jmcarp merged pull request #14685:
URL: https://github.com/apache/airflow/pull/14685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14685: Add job labels to bigquery check operators.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14685:
URL: https://github.com/apache/airflow/pull/14685#issuecomment-796267356
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmcarp commented on pull request #14685: Add job labels to bigquery check operators.
Posted by GitBox <gi...@apache.org>.
jmcarp commented on pull request #14685:
URL: https://github.com/apache/airflow/pull/14685#issuecomment-795482861
Does this approach make sense @kaxil @ashb? There's a lot of indirection from the check operators to the base class and mixin to the bigquery dbapi shim, and this was the simplest thing I could think of.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14685: Add job labels to bigquery check operators.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14685:
URL: https://github.com/apache/airflow/pull/14685#issuecomment-794498650
[The Workflow run](https://github.com/apache/airflow/actions/runs/637251288) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org