You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Carlos Rovira <ca...@apache.org> on 2018/01/07 17:51:45 UTC
Re: Slider Component
Hi Peter
I could at last try the new slider and works far way better. Thanks for the
great work!.
I notice the problems raised by Justin. I think one of the problem is that
thumb is not considering the mouse exact point of interaction and that
cause the thumb "moves" or adapts to the mouse. I think this is right when
mouse is outside the thumb, but when is "inside" I think thumb should start
moving when user start dragging.
I think this is so close to a functional slider so thanks for working on
this!
Carlos
2017-12-15 4:12 GMT+01:00 Justin Mclean <ju...@classsoftware.com>:
> HI,
>
> Look like the new slider code has introduced a few new issues and one in
> particular in easily discoverable by users [1]. Can someone take a look at
> this PR please. [2]
>
> Thanks,
> Justin
>
> 1. https://github.com/apache/royale-asjs/issues/102
> 2. https://github.com/apache/royale-asjs/pull/104
--
Carlos Rovira
http://about.me/carlosrovira
Re: Slider Component
Posted by Peter Ent <pe...@adobe.com.INVALID>.
I compared Justin's suggested change with what was already in the repo and
changed the code to remove an unnecessary offset. To me, it now works
correctly.
‹peter
On 1/9/18, 7:14 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>> I've tried the slider with Safari, Chrome, and Firefox. I guess I am
>>not understanding the problem.
>
>I describe the issue and how to reproduce here [1] and have provided a
>fix for it here [2] it would be nice if someone reviewed it as this has
>been open for a month.
>
>The fix just committed BTW doesn¹t seem to solve the problem above.
>
>Thanks,
>Justin
>
>1.
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co
>m%2Fapache%2Froyale-asjs%2Fissues%2F102&data=02%7C01%7Cpent%40adobe.com%7C
>7f6b0faed43b409baa2208d557bf28a0%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
>0%7C636511400892762769&sdata=fz8uWl78eqreC%2F06%2BMmZy661cqmRGmwCqHrb86661
>4Q%3D&reserved=0
>2.
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co
>m%2Fapache%2Froyale-asjs%2Fpull%2F104&data=02%7C01%7Cpent%40adobe.com%7C7f
>6b0faed43b409baa2208d557bf28a0%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
>7C636511400892762769&sdata=1DyM59kd6Rh%2BySRMj00zupF5eFgp4WUV9MxLbozjjH8%3
>D&reserved=0
Re: Slider Component
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I've tried the slider with Safari, Chrome, and Firefox. I guess I am not understanding the problem.
I describe the issue and how to reproduce here [1] and have provided a fix for it here [2] it would be nice if someone reviewed it as this has been open for a month.
The fix just committed BTW doesn’t seem to solve the problem above.
Thanks,
Justin
1. https://github.com/apache/royale-asjs/issues/102
2. https://github.com/apache/royale-asjs/pull/104
Re: Slider Component
Posted by Peter Ent <pe...@adobe.com.INVALID>.
Hi
I've pushed a change to the slider mouse controllers that should make it
better. Now clicking on the thumb will not move it. If you drag the thumb
it should reposition centered under the mouse cursor. But doing it quickly
(ie, normally) it tracks a little off. I think that's because the events
just aren't being processed fast enough. This may be as best as we can get
it.
—peter
On 1/9/18, 2:47 PM, "Peter Ent" <pe...@adobe.com> wrote:
>Thanks for the video! That was great. I do see what you are describing.
>I'll look into it.
>
>—peter
>
>On 1/9/18, 1:49 PM, "carlos.rovira@gmail.com on behalf of Carlos Rovira"
><carlos.rovira@gmail.com on behalf of carlosrovira@apache.org> wrote:
>
>>Hi Peter,
>>
>>I think the best way to show you the problems is with a video. I uploaded
>>a
>>hidden video here:
>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fyoutu.be
>>%
>>2Fm1SnCyHeUzc&data=02%7C01%7Cpent%40adobe.com%7Cc0b9c449b8b84ed3d86f08d55
>>7
>>91c1d2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636511205892654628&sd
>>a
>>ta=8VwCCicx6YYD%2Bi2E3CHYSl38FnWBNhD1pUvpyj2NBtM%3D&reserved=0
>>Please, let me know when you see it, I could remove it in some days or if
>>you want left it more time
>>
>>I'm on Mac/Safari, I think here you can see some problems here:
>>* When you click on thumb and then click again thumb moves (two times to
>>the right and the goes again to origin), this is the one Justin reported
>>* Another one is when you click on thumb and then drag, the slider goes
>>directly to match mouse pointer position
>>
>>Thanks
>>
>>2018-01-09 17:32 GMT+01:00 Peter Ent <pe...@adobe.com.invalid>:
>>
>>> I've tried the slider with Safari, Chrome, and Firefox. I guess I am
>>>not
>>> understanding the problem. When I move the mouse into the slider thumb
>>> control, press the mouse button down and drag, the thumb follows the
>>>mouse
>>> immediately. It may snap to step positions along the track if the range
>>> isn't very big (eg, 0..5). Is the problem that it snaps and doesn't
>>>glide
>>> smoothly?
>>>
>>> I've looked at sliders in other UIs and they do glide smoothly and most
>>> often just stop where you leave them. Which can lead to readings like
>>>3.25
>>> on a scale of 0..5. Mostly those sliders only range from 0..1 and then
>>>the
>>> app developer has to interpolate.
>>>
>>> Let me know how to proceed.
>>>
>>> ‹peter
>>>
>>> On 1/7/18, 12:51 PM, "carlos.rovira@gmail.com on behalf of Carlos
>>>Rovira"
>>> <carlos.rovira@gmail.com on behalf of carlosrovira@apache.org> wrote:
>>>
>>> >Hi Peter
>>> >
>>> >I could at last try the new slider and works far way better. Thanks
>>>for
>>> >the
>>> >great work!.
>>> >
>>> >I notice the problems raised by Justin. I think one of the problem is
>>>that
>>> >thumb is not considering the mouse exact point of interaction and that
>>> >cause the thumb "moves" or adapts to the mouse. I think this is right
>>>when
>>> >mouse is outside the thumb, but when is "inside" I think thumb should
>>> >start
>>> >moving when user start dragging.
>>> >
>>> >I think this is so close to a functional slider so thanks for working
>>>on
>>> >this!
>>> >
>>> >Carlos
>>> >
>>> >
>>> >
>>> >2017-12-15 4:12 GMT+01:00 Justin Mclean <ju...@classsoftware.com>:
>>> >
>>> >> HI,
>>> >>
>>> >> Look like the new slider code has introduced a few new issues and
>>>one in
>>> >> particular in easily discoverable by users [1]. Can someone take a
>>>look
>>> >>at
>>> >> this PR please. [2]
>>> >>
>>> >> Thanks,
>>> >> Justin
>>> >>
>>> >> 1.
>>> >>https://na01.safelinks.protection.outlook.com/?url=
>>> https%3A%2F%2Fgithub.c
>>>
>>>>>om%2Fapache%2Froyale-asjs%2Fissues%2F102&data=02%7C01%7Cpent%40adobe.c
>>>>>o
>>>>>m
>>> %
>>> >>7Cc37586e268914b061c2c08d555f76079%7Cfa7b1b5a7b34438794aed2c178de
>>> cee1%7C0
>>> >>%7C0%7C636509443332572042&sdata=ILU1l099EOgRcquay0yTvg%
>>> 2Fmtms9jBSfoj12jlK
>>> >>JreA%3D&reserved=0
>>> >> 2.
>>> >>https://na01.safelinks.protection.outlook.com/?url=
>>> https%3A%2F%2Fgithub.c
>>>
>>>>>om%2Fapache%2Froyale-asjs%2Fpull%2F104&data=02%7C01%7Cpent%40adobe.com
>>> %7C
>>> >>c37586e268914b061c2c08d555f76079%7Cfa7b1b5a7b34438794aed2c178de
>>> cee1%7C0%7
>>> >>C0%7C636509443332572042&sdata=MU0G1ExYtSMUw3yta2pWKcr7HCXSRO
>>> 467d2CUseQyAU
>>> >>%3D&reserved=0
>>> >
>>> >
>>> >
>>> >
>>> >--
>>> >Carlos Rovira
>>> >https://na01.safelinks.protection.outlook.com/?url=
>>> http%3A%2F%2Fabout.me%2
>>> >Fcarlosrovira&data=02%7C01%7Cpent%40adobe.com%
>>> 7Cc37586e268914b061c2c08d555
>>> >f76079%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
>>> 7C636509443332572042&sda
>>> >ta=Nin8sgwiGcjK0whqN7cscKZxN1baBwqJ5ylcveDW76E%3D&reserved=0
>>>
>>>
>>
>>
>>--
>>Carlos Rovira
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%
>>2
>>Fcarlosrovira&data=02%7C01%7Cpent%40adobe.com%7Cc0b9c449b8b84ed3d86f08d55
>>7
>>91c1d2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636511205892654628&sd
>>a
>>ta=S%2BZhm6gnH8KEEPrrOhkMyWcxfw1ro7dMI6t6Ox242E0%3D&reserved=0
>
Re: Slider Component
Posted by Peter Ent <pe...@adobe.com.INVALID>.
Thanks for the video! That was great. I do see what you are describing.
I'll look into it.
—peter
On 1/9/18, 1:49 PM, "carlos.rovira@gmail.com on behalf of Carlos Rovira"
<carlos.rovira@gmail.com on behalf of carlosrovira@apache.org> wrote:
>Hi Peter,
>
>I think the best way to show you the problems is with a video. I uploaded
>a
>hidden video here:
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fyoutu.be%
>2Fm1SnCyHeUzc&data=02%7C01%7Cpent%40adobe.com%7Cc0b9c449b8b84ed3d86f08d557
>91c1d2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636511205892654628&sda
>ta=8VwCCicx6YYD%2Bi2E3CHYSl38FnWBNhD1pUvpyj2NBtM%3D&reserved=0
>Please, let me know when you see it, I could remove it in some days or if
>you want left it more time
>
>I'm on Mac/Safari, I think here you can see some problems here:
>* When you click on thumb and then click again thumb moves (two times to
>the right and the goes again to origin), this is the one Justin reported
>* Another one is when you click on thumb and then drag, the slider goes
>directly to match mouse pointer position
>
>Thanks
>
>2018-01-09 17:32 GMT+01:00 Peter Ent <pe...@adobe.com.invalid>:
>
>> I've tried the slider with Safari, Chrome, and Firefox. I guess I am not
>> understanding the problem. When I move the mouse into the slider thumb
>> control, press the mouse button down and drag, the thumb follows the
>>mouse
>> immediately. It may snap to step positions along the track if the range
>> isn't very big (eg, 0..5). Is the problem that it snaps and doesn't
>>glide
>> smoothly?
>>
>> I've looked at sliders in other UIs and they do glide smoothly and most
>> often just stop where you leave them. Which can lead to readings like
>>3.25
>> on a scale of 0..5. Mostly those sliders only range from 0..1 and then
>>the
>> app developer has to interpolate.
>>
>> Let me know how to proceed.
>>
>> ‹peter
>>
>> On 1/7/18, 12:51 PM, "carlos.rovira@gmail.com on behalf of Carlos
>>Rovira"
>> <carlos.rovira@gmail.com on behalf of carlosrovira@apache.org> wrote:
>>
>> >Hi Peter
>> >
>> >I could at last try the new slider and works far way better. Thanks for
>> >the
>> >great work!.
>> >
>> >I notice the problems raised by Justin. I think one of the problem is
>>that
>> >thumb is not considering the mouse exact point of interaction and that
>> >cause the thumb "moves" or adapts to the mouse. I think this is right
>>when
>> >mouse is outside the thumb, but when is "inside" I think thumb should
>> >start
>> >moving when user start dragging.
>> >
>> >I think this is so close to a functional slider so thanks for working
>>on
>> >this!
>> >
>> >Carlos
>> >
>> >
>> >
>> >2017-12-15 4:12 GMT+01:00 Justin Mclean <ju...@classsoftware.com>:
>> >
>> >> HI,
>> >>
>> >> Look like the new slider code has introduced a few new issues and
>>one in
>> >> particular in easily discoverable by users [1]. Can someone take a
>>look
>> >>at
>> >> this PR please. [2]
>> >>
>> >> Thanks,
>> >> Justin
>> >>
>> >> 1.
>> >>https://na01.safelinks.protection.outlook.com/?url=
>> https%3A%2F%2Fgithub.c
>>
>>>>om%2Fapache%2Froyale-asjs%2Fissues%2F102&data=02%7C01%7Cpent%40adobe.co
>>>>m
>> %
>> >>7Cc37586e268914b061c2c08d555f76079%7Cfa7b1b5a7b34438794aed2c178de
>> cee1%7C0
>> >>%7C0%7C636509443332572042&sdata=ILU1l099EOgRcquay0yTvg%
>> 2Fmtms9jBSfoj12jlK
>> >>JreA%3D&reserved=0
>> >> 2.
>> >>https://na01.safelinks.protection.outlook.com/?url=
>> https%3A%2F%2Fgithub.c
>> >>om%2Fapache%2Froyale-asjs%2Fpull%2F104&data=02%7C01%7Cpent%40adobe.com
>> %7C
>> >>c37586e268914b061c2c08d555f76079%7Cfa7b1b5a7b34438794aed2c178de
>> cee1%7C0%7
>> >>C0%7C636509443332572042&sdata=MU0G1ExYtSMUw3yta2pWKcr7HCXSRO
>> 467d2CUseQyAU
>> >>%3D&reserved=0
>> >
>> >
>> >
>> >
>> >--
>> >Carlos Rovira
>> >https://na01.safelinks.protection.outlook.com/?url=
>> http%3A%2F%2Fabout.me%2
>> >Fcarlosrovira&data=02%7C01%7Cpent%40adobe.com%
>> 7Cc37586e268914b061c2c08d555
>> >f76079%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
>> 7C636509443332572042&sda
>> >ta=Nin8sgwiGcjK0whqN7cscKZxN1baBwqJ5ylcveDW76E%3D&reserved=0
>>
>>
>
>
>--
>Carlos Rovira
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2
>Fcarlosrovira&data=02%7C01%7Cpent%40adobe.com%7Cc0b9c449b8b84ed3d86f08d557
>91c1d2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636511205892654628&sda
>ta=S%2BZhm6gnH8KEEPrrOhkMyWcxfw1ro7dMI6t6Ox242E0%3D&reserved=0
Re: Slider Component
Posted by Carlos Rovira <ca...@apache.org>.
Hi Peter,
I think the best way to show you the problems is with a video. I uploaded a
hidden video here: https://youtu.be/m1SnCyHeUzc
Please, let me know when you see it, I could remove it in some days or if
you want left it more time
I'm on Mac/Safari, I think here you can see some problems here:
* When you click on thumb and then click again thumb moves (two times to
the right and the goes again to origin), this is the one Justin reported
* Another one is when you click on thumb and then drag, the slider goes
directly to match mouse pointer position
Thanks
2018-01-09 17:32 GMT+01:00 Peter Ent <pe...@adobe.com.invalid>:
> I've tried the slider with Safari, Chrome, and Firefox. I guess I am not
> understanding the problem. When I move the mouse into the slider thumb
> control, press the mouse button down and drag, the thumb follows the mouse
> immediately. It may snap to step positions along the track if the range
> isn't very big (eg, 0..5). Is the problem that it snaps and doesn't glide
> smoothly?
>
> I've looked at sliders in other UIs and they do glide smoothly and most
> often just stop where you leave them. Which can lead to readings like 3.25
> on a scale of 0..5. Mostly those sliders only range from 0..1 and then the
> app developer has to interpolate.
>
> Let me know how to proceed.
>
> ‹peter
>
> On 1/7/18, 12:51 PM, "carlos.rovira@gmail.com on behalf of Carlos Rovira"
> <carlos.rovira@gmail.com on behalf of carlosrovira@apache.org> wrote:
>
> >Hi Peter
> >
> >I could at last try the new slider and works far way better. Thanks for
> >the
> >great work!.
> >
> >I notice the problems raised by Justin. I think one of the problem is that
> >thumb is not considering the mouse exact point of interaction and that
> >cause the thumb "moves" or adapts to the mouse. I think this is right when
> >mouse is outside the thumb, but when is "inside" I think thumb should
> >start
> >moving when user start dragging.
> >
> >I think this is so close to a functional slider so thanks for working on
> >this!
> >
> >Carlos
> >
> >
> >
> >2017-12-15 4:12 GMT+01:00 Justin Mclean <ju...@classsoftware.com>:
> >
> >> HI,
> >>
> >> Look like the new slider code has introduced a few new issues and one in
> >> particular in easily discoverable by users [1]. Can someone take a look
> >>at
> >> this PR please. [2]
> >>
> >> Thanks,
> >> Justin
> >>
> >> 1.
> >>https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.c
> >>om%2Fapache%2Froyale-asjs%2Fissues%2F102&data=02%7C01%7Cpent%40adobe.com
> %
> >>7Cc37586e268914b061c2c08d555f76079%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0
> >>%7C0%7C636509443332572042&sdata=ILU1l099EOgRcquay0yTvg%
> 2Fmtms9jBSfoj12jlK
> >>JreA%3D&reserved=0
> >> 2.
> >>https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.c
> >>om%2Fapache%2Froyale-asjs%2Fpull%2F104&data=02%7C01%7Cpent%40adobe.com
> %7C
> >>c37586e268914b061c2c08d555f76079%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7
> >>C0%7C636509443332572042&sdata=MU0G1ExYtSMUw3yta2pWKcr7HCXSRO
> 467d2CUseQyAU
> >>%3D&reserved=0
> >
> >
> >
> >
> >--
> >Carlos Rovira
> >https://na01.safelinks.protection.outlook.com/?url=
> http%3A%2F%2Fabout.me%2
> >Fcarlosrovira&data=02%7C01%7Cpent%40adobe.com%
> 7Cc37586e268914b061c2c08d555
> >f76079%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636509443332572042&sda
> >ta=Nin8sgwiGcjK0whqN7cscKZxN1baBwqJ5ylcveDW76E%3D&reserved=0
>
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: Slider Component
Posted by Peter Ent <pe...@adobe.com.INVALID>.
I've tried the slider with Safari, Chrome, and Firefox. I guess I am not
understanding the problem. When I move the mouse into the slider thumb
control, press the mouse button down and drag, the thumb follows the mouse
immediately. It may snap to step positions along the track if the range
isn't very big (eg, 0..5). Is the problem that it snaps and doesn't glide
smoothly?
I've looked at sliders in other UIs and they do glide smoothly and most
often just stop where you leave them. Which can lead to readings like 3.25
on a scale of 0..5. Mostly those sliders only range from 0..1 and then the
app developer has to interpolate.
Let me know how to proceed.
‹peter
On 1/7/18, 12:51 PM, "carlos.rovira@gmail.com on behalf of Carlos Rovira"
<carlos.rovira@gmail.com on behalf of carlosrovira@apache.org> wrote:
>Hi Peter
>
>I could at last try the new slider and works far way better. Thanks for
>the
>great work!.
>
>I notice the problems raised by Justin. I think one of the problem is that
>thumb is not considering the mouse exact point of interaction and that
>cause the thumb "moves" or adapts to the mouse. I think this is right when
>mouse is outside the thumb, but when is "inside" I think thumb should
>start
>moving when user start dragging.
>
>I think this is so close to a functional slider so thanks for working on
>this!
>
>Carlos
>
>
>
>2017-12-15 4:12 GMT+01:00 Justin Mclean <ju...@classsoftware.com>:
>
>> HI,
>>
>> Look like the new slider code has introduced a few new issues and one in
>> particular in easily discoverable by users [1]. Can someone take a look
>>at
>> this PR please. [2]
>>
>> Thanks,
>> Justin
>>
>> 1.
>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c
>>om%2Fapache%2Froyale-asjs%2Fissues%2F102&data=02%7C01%7Cpent%40adobe.com%
>>7Cc37586e268914b061c2c08d555f76079%7Cfa7b1b5a7b34438794aed2c178decee1%7C0
>>%7C0%7C636509443332572042&sdata=ILU1l099EOgRcquay0yTvg%2Fmtms9jBSfoj12jlK
>>JreA%3D&reserved=0
>> 2.
>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c
>>om%2Fapache%2Froyale-asjs%2Fpull%2F104&data=02%7C01%7Cpent%40adobe.com%7C
>>c37586e268914b061c2c08d555f76079%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7
>>C0%7C636509443332572042&sdata=MU0G1ExYtSMUw3yta2pWKcr7HCXSRO467d2CUseQyAU
>>%3D&reserved=0
>
>
>
>
>--
>Carlos Rovira
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2
>Fcarlosrovira&data=02%7C01%7Cpent%40adobe.com%7Cc37586e268914b061c2c08d555
>f76079%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636509443332572042&sda
>ta=Nin8sgwiGcjK0whqN7cscKZxN1baBwqJ5ylcveDW76E%3D&reserved=0