You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@impala.apache.org by "Tim Armstrong (JIRA)" <ji...@apache.org> on 2018/01/19 17:08:01 UTC

[jira] [Resolved] (IMPALA-6368) test_chars.py races with itself when run in parallel

     [ https://issues.apache.org/jira/browse/IMPALA-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Armstrong resolved IMPALA-6368.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: Impala 2.12.0


IMPALA-6368: make test_chars parallel

Previously it had to be executed serially because it modified tables in
the functional database.

This change separates out tests that use temporary tables and runs those
in a unique_database.

Testing:
Ran locally in a loop with parallelism of 4 for a while.

Change-Id: I2f62ede90f619b8cebbb1276bab903e7555d9744
Reviewed-on: http://gerrit.cloudera.org:8080/9022
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins

> test_chars.py races with itself when run in parallel
> ----------------------------------------------------
>
>                 Key: IMPALA-6368
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6368
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: Impala 2.11.0
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>             Fix For: Impala 2.12.0
>
>
> There are a handful of test tables like test_char_tmp that can be inserted into from multiple tests in parallel.
> {noformat}
>  TestStringQueries.test_varchar[exec_option: {'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 0, 'disable_codegen': True, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] 
> [gw3] linux2 -- Python 2.7.12 /home/tarmstrong/Impala/incubator-impala/bin/../infra/python/env/bin/python
> tests/query_test/test_chars.py:82: in test_varchar
>     self.run_test_case('QueryTest/chars', vector)
> tests/common/impala_test_suite.py:424: in run_test_case
>     self.__verify_results_and_errors(vector, test_section, result, use_db)
> tests/common/impala_test_suite.py:297: in __verify_results_and_errors
>     replace_filenames_with_placeholder)
> tests/common/test_result_verifier.py:404: in verify_raw_results
>     VERIFIER_MAP[verifier](expected, actual)
> tests/common/test_result_verifier.py:231: in verify_query_result_is_equal
>     assert expected_results == actual_results
> E   assert Comparing QueryTestResults (expected vs actual):
> E     'hello' == 'hello'
> E     None != 'hello'
> E     Number of rows returned (expected vs actual): 1 != 2
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)