You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by x461909066 <gi...@git.apache.org> on 2018/05/07 05:28:26 UTC

[GitHub] incubator-weex pull request #1153: [WEEX-340][iOS]fix the window problem whe...

GitHub user x461909066 opened a pull request:

    https://github.com/apache/incubator-weex/pull/1153

    [WEEX-340][iOS]fix the window problem where weex toast is displayed

    Weex toast should be displayed in the window where weex is located. 
    If the window does not exist, it is displayed on the weex root view.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/x461909066/incubator-weex bugFix/toast_window

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1153
    
----
commit 1e88b7d54d7462f2da29d683c89e6e04dbe75d21
Author: jinxiaotong <ji...@...>
Date:   2018-05-04T03:32:50Z

    [iOS]bugfix: toast should display on weex window

----


---

[GitHub] incubator-weex issue #1153: [WEEX-340][iOS]fix the window problem where weex...

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1153
  
    
    <!--
      0 failure: 
      0 warning: 
      2 messages
      
    -->
    
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>has no jsfm file changed.</td>
        </tr>
      
    <tr>
          <td>:book:</td>
          <td>jsfm test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---

[GitHub] incubator-weex pull request #1153: [WEEX-340][iOS]fix the window problem whe...

Posted by x461909066 <gi...@git.apache.org>.
Github user x461909066 closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1153


---