[GitHub] spark pull request #17848: [SPARK-20586] [SQL] Add deterministic to ScalaUDF...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17848#discussion_r127635707
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala ---
    @@ -103,4 +110,19 @@ case class UserDefinedFunction protected[sql] (
           udf
         }
       }
    +
    +  /**
    +   * Updates UserDefinedFunction to non-deterministic.
    +   *
    +   * @since 2.3.0
    +   */
    +  def nonDeterministic(): UserDefinedFunction = {
    --- End diff --
    
    shall we follow existing naming style and make it `def withDeterministic(deterministic: Boolean)`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org