You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/19 10:27:12 UTC
[GitHub] [incubator-druid] pjain1 commented on a change in pull request
#7306: Reconcile terminology and method naming to 'used/unused segments';
Rename MetadataSegmentManager to MetadataSegments
pjain1 commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments
URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r315064787
##########
File path: server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
##########
@@ -178,29 +273,25 @@ public void start()
final List<Interval> intervals
)
{
- if (intervals == null || intervals.isEmpty()) {
Review comment:
This check has been shifted to `retrieveUsedSegmentsForIntervals`, however this method itself is called from one more `createNewSegment` method also so please make sure that it does not reply on this for something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org