You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/03/23 17:39:48 UTC
[Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6463
Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
......................................................................
IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
Add a note that idle_session_timeout and idle_query_timeout
might take up to 50% longer than the specified interval
before cancellation occurs.
Also rearrange the text a little to put QUERY_TIMEOUT_S
explanation adjacent to the idle_query_timeout explanation.
This results in an indentation change that makes the diff
look bigger than it really is. The <note> element is the
only actual added content.
Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
---
M docs/topics/impala_timeouts.xml
1 file changed, 32 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/6463/1
--
To view, visit http://gerrit.cloudera.org:8080/6463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6463/2/docs/topics/impala_timeouts.xml
File docs/topics/impala_timeouts.xml:
PS2, Line 118: ide_query_timeout
> typo: idle
Done
PS2, Line 118: represents an effectively
: infinite timeout interval.
> how about "disables query timeouts"
Done
--
To view, visit http://gerrit.cloudera.org:8080/6463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
......................................................................
Patch Set 1:
(3 comments)
Looks pretty good - just a couple of nits.
http://gerrit.cloudera.org:8080/#/c/6463/1/docs/topics/impala_timeouts.xml
File docs/topics/impala_timeouts.xml:
Line 116: query option. Any value specified for the <codeph>--idle_query_timeout</codeph> startup
non-zero? If it's zero, the default timeout is effectively infinite.
PS1, Line 141: and queries
I just looked - queries are checked every second.
PS1, Line 141: To avoid excessive polling,
No need to add justification.
--
To view, visit http://gerrit.cloudera.org:8080/6463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6463/1/docs/topics/impala_timeouts.xml
File docs/topics/impala_timeouts.xml:
PS1, Line 141: and queries
> Did you need me to make any distinction between the checking for sessions a
I thought the "every second" tidbit would get confusing when placed alongside the example of a query or session taking >1 min to get cancelled, so I didn't add any wording around the 1 second business.
--
To view, visit http://gerrit.cloudera.org:8080/6463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6463/1/docs/topics/impala_timeouts.xml
File docs/topics/impala_timeouts.xml:
Line 116: query option. Any value specified for the <codeph>--idle_query_timeout</codeph> startup
> non-zero? If it's zero, the default timeout is effectively infinite.
Done
PS1, Line 141: and queries
> I just looked - queries are checked every second.
Did you need me to make any distinction between the checking for sessions and queries? E.g. if I add the detail "by default, Impala checks every second", does that apply both for sessions and queries?
PS1, Line 141: To avoid excessive polling,
> No need to add justification.
Done
--
To view, visit http://gerrit.cloudera.org:8080/6463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6463/2/docs/topics/impala_timeouts.xml
File docs/topics/impala_timeouts.xml:
PS2, Line 118: ide_query_timeout
typo: idle
PS2, Line 118: represents an effectively
: infinite timeout interval.
how about "disables query timeouts"
--
To view, visit http://gerrit.cloudera.org:8080/6463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
......................................................................
Patch Set 3:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/113/
--
To view, visit http://gerrit.cloudera.org:8080/6463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has submitted this change and it was merged.
Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
......................................................................
IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
Add a note that idle_session_timeout and idle_query_timeout
might take up to 50% longer than the specified interval
before cancellation occurs.
Also rearrange the text a little to put QUERY_TIMEOUT_S
explanation adjacent to the idle_query_timeout explanation.
This results in an indentation change that makes the diff
look bigger than it really is. The <note> element is the
only actual added content.
Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
Reviewed-on: http://gerrit.cloudera.org:8080/6463
Tested-by: Impala Public Jenkins
Reviewed-by: Michael Brown <mi...@cloudera.com>
---
M docs/topics/impala_timeouts.xml
1 file changed, 33 insertions(+), 19 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Michael Brown: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6463
to look at the new patch set (#3).
Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
......................................................................
IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
Add a note that idle_session_timeout and idle_query_timeout
might take up to 50% longer than the specified interval
before cancellation occurs.
Also rearrange the text a little to put QUERY_TIMEOUT_S
explanation adjacent to the idle_query_timeout explanation.
This results in an indentation change that makes the diff
look bigger than it really is. The <note> element is the
only actual added content.
Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
---
M docs/topics/impala_timeouts.xml
1 file changed, 33 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/6463/3
--
To view, visit http://gerrit.cloudera.org:8080/6463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).
Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
......................................................................
IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
Add a note that idle_session_timeout and idle_query_timeout
might take up to 50% longer than the specified interval
before cancellation occurs.
Also rearrange the text a little to put QUERY_TIMEOUT_S
explanation adjacent to the idle_query_timeout explanation.
This results in an indentation change that makes the diff
look bigger than it really is. The <note> element is the
only actual added content.
Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
---
M docs/topics/impala_timeouts.xml
1 file changed, 34 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/6463/2
--
To view, visit http://gerrit.cloudera.org:8080/6463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>