You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/29 06:13:35 UTC

[GitHub] [apisix] membphis opened a new issue #2557: chore: merge the similar code in plugins

membphis opened a new issue #2557:
URL: https://github.com/apache/apisix/issues/2557


   https://github.com/apache/apisix/pull/2389/files#r513940449
   
   we can move funtion `try_read_attr` to `apisix.core.table`, then we can reuse this function between different plugin.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #2557: chore: merge the similar code in plugins

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2557:
URL: https://github.com/apache/apisix/issues/2557#issuecomment-718483457


   @starsz 
   Sure. Go for it!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] starsz commented on issue #2557: chore: merge the similar code in plugins

Posted by GitBox <gi...@apache.org>.
starsz commented on issue #2557:
URL: https://github.com/apache/apisix/issues/2557#issuecomment-718477960


   May I pick up this?  ^_^


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org