You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2017/07/06 12:46:17 UTC

[GitHub] spark pull request #18487: [SPARK-21243][Core] Limit no. of map outputs in a...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18487#discussion_r125888006
  
    --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala ---
    @@ -321,6 +321,16 @@ package object config {
           .intConf
           .createWithDefault(3)
     
    +  private[spark] val REDUCER_MAX_BLOCKS_IN_FLIGHT_PER_ADDRESS =
    +    ConfigBuilder("spark.reducer.maxBlocksInFlightPerAddress")
    --- End diff --
    
    I'm not sure if it's a good idea to do this at reducer side, because there may be a lot of reducers fetching data from one shuffle service at the same time, and you wouldn't know that at reducer side. cc @jinxing64 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org