[jira] [Commented] (ZOOKEEPER-1203) Zookeeper systest is missing Junit Classes

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114134#comment-13114134 ] 

Hadoop QA commented on ZOOKEEPER-1203:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12496378/ZK-1203-patch.txt
  against trunk revision 1173949.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/587//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/587//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/587//console

This message is automatically generated.

> Zookeeper systest is missing Junit Classes 
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1203
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1203
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: tests
>            Reporter: Prashant Gokhale
>         Attachments: ZK-1203-patch.txt
>
>
> For running these tests, I am following instructions on https://github.com/apache/zookeeper/blob/trunk/src/java/systest/README.txt 
> In Step 4, when I try to run java -jar build/contrib/fatjar/zookeeper-<version>-fatjar.jar systest org.apache.zookeeper.test.system.SimpleSysTest , it throws the following error,
> Exception in thread "main" java.lang.NoClassDefFoundError: junit/framework/TestCase
> The problem is that zookeeper-dev-fatjar.jar does not contain the TestCase class.
> Patrick Hunt suggested that adding <zipgroupfileset dir="${zk.root}/build/test/lib" includes="*.jar" /> to fatjar/build.xml should solve the problem and it does.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira