You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/07/26 21:19:28 UTC

Review Request 36826: Removed common/factory as it is not used.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36826/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.


Bugs: MESOS-3120
    https://issues.apache.org/jira/browse/MESOS-3120


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 
  src/common/factory.hpp bdddcf872eae1a4ed78ca8b35864ee59bbaecb65 

Diff: https://reviews.apache.org/r/36826/diff/


Testing
-------

make check


Thanks,

Joris Van Remoortere


Re: Review Request 36826: Removed common/factory as it is not used.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36826/#review93164
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On July 26, 2015, 7:19 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36826/
> -----------------------------------------------------------
> 
> (Updated July 26, 2015, 7:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.
> 
> 
> Bugs: MESOS-3120
>     https://issues.apache.org/jira/browse/MESOS-3120
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 
>   src/common/factory.hpp bdddcf872eae1a4ed78ca8b35864ee59bbaecb65 
> 
> Diff: https://reviews.apache.org/r/36826/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Re: Review Request 36826: Removed common/factory as it is not used.

Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36826/#review93081
-----------------------------------------------------------

Ship it!


Ship It!

- Artem Harutyunyan


On July 26, 2015, 12:19 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36826/
> -----------------------------------------------------------
> 
> (Updated July 26, 2015, 12:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.
> 
> 
> Bugs: MESOS-3120
>     https://issues.apache.org/jira/browse/MESOS-3120
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 
>   src/common/factory.hpp bdddcf872eae1a4ed78ca8b35864ee59bbaecb65 
> 
> Diff: https://reviews.apache.org/r/36826/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>