You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/06 23:56:52 UTC

[GitHub] [incubator-tvm] comaniac edited a comment on issue #4637: [RUNTIME][DSO] Improve TVMBackendPackedCFunc to allow return val

comaniac edited a comment on issue #4637: [RUNTIME][DSO] Improve TVMBackendPackedCFunc to allow return val
URL: https://github.com/apache/incubator-tvm/pull/4637#issuecomment-571367737
 
 
   Thanks for the PR. The macros are indeed helpful for customized runtimes and can reduce the developer efforts. I'll file another PR to make use of them in [this example](https://github.com/apache/incubator-tvm/blob/master/src/runtime/contrib/example_ext_runtime/example_ext_runtime.cc) after this one have been merged. 
   
   The change are LGTM. Since I may not be aware of some concerns in backend APIs, I am leaving it for others.
   
   btw, you may need to fix the failure cases in CI.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services