You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/29 07:08:20 UTC

[GitHub] [rocketmq] xiaoyifang commented on issue #5738: [code optimization] simplify the method updateFaultItem

xiaoyifang commented on issue #5738:
URL: https://github.com/apache/rocketmq/issues/5738#issuecomment-1367115511

   > Your code create a new FaultItem every time, I think it's not necessary when old item exists.
   
   update the old existed item is a little complex in concurrent situations as the original code just did. 
   the code did create new item every time ,but the GC should ease the trouble at last. 
   
   At last I think your concern is reasonable 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org