You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/30 04:51:02 UTC
[GitHub] [flink] leonardBang opened a new pull request #11954: [FLINK-17420][table sql / api]Cannot alias Tuple and Row fields when converting DataStream to Table
leonardBang opened a new pull request #11954:
URL: https://github.com/apache/flink/pull/11954
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*This pull request fix `byPosition` mode judgement in FieldInfoUtils to support reorder and reorder field properly.*
## Brief change log
- *update file org/apache/flink/table/typeutils/FieldInfoUtils.java*
## Verifying this change
- Add related unit tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): ( no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11954: [FLINK-17420][table sql / api]Cannot alias Tuple and Row fields when converting DataStream to Table
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11954:
URL: https://github.com/apache/flink/pull/11954#issuecomment-621615631
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6a37ff126c35f1d7b35fb50ccff89f200967b2da",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162875532",
"triggerID" : "6a37ff126c35f1d7b35fb50ccff89f200967b2da",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a37ff126c35f1d7b35fb50ccff89f200967b2da Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162875532)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11954: [FLINK-17420][table sql / api]Cannot alias Tuple and Row fields when converting DataStream to Table
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11954:
URL: https://github.com/apache/flink/pull/11954#issuecomment-621615631
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6a37ff126c35f1d7b35fb50ccff89f200967b2da",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162875532",
"triggerID" : "6a37ff126c35f1d7b35fb50ccff89f200967b2da",
"triggerType" : "PUSH"
}, {
"hash" : "c5e67bf6cfb59353b1109c060b82820920d30ff8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c5e67bf6cfb59353b1109c060b82820920d30ff8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a37ff126c35f1d7b35fb50ccff89f200967b2da Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162875532)
* c5e67bf6cfb59353b1109c060b82820920d30ff8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11954: [FLINK-17420][table sql / api]Cannot alias Tuple and Row fields when converting DataStream to Table
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11954:
URL: https://github.com/apache/flink/pull/11954#issuecomment-621615631
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6a37ff126c35f1d7b35fb50ccff89f200967b2da",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162875532",
"triggerID" : "6a37ff126c35f1d7b35fb50ccff89f200967b2da",
"triggerType" : "PUSH"
}, {
"hash" : "c5e67bf6cfb59353b1109c060b82820920d30ff8",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/164108249",
"triggerID" : "c5e67bf6cfb59353b1109c060b82820920d30ff8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c5e67bf6cfb59353b1109c060b82820920d30ff8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/164108249)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11954: [FLINK-17420][table sql / api]Cannot alias Tuple and Row fields when converting DataStream to Table
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11954:
URL: https://github.com/apache/flink/pull/11954#issuecomment-621615631
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6a37ff126c35f1d7b35fb50ccff89f200967b2da",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162875532",
"triggerID" : "6a37ff126c35f1d7b35fb50ccff89f200967b2da",
"triggerType" : "PUSH"
}, {
"hash" : "c5e67bf6cfb59353b1109c060b82820920d30ff8",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/164108249",
"triggerID" : "c5e67bf6cfb59353b1109c060b82820920d30ff8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a37ff126c35f1d7b35fb50ccff89f200967b2da Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162875532)
* c5e67bf6cfb59353b1109c060b82820920d30ff8 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/164108249)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a change in pull request #11954: [FLINK-17420][table sql / api]Cannot alias Tuple and Row fields when converting DataStream to Table
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #11954:
URL: https://github.com/apache/flink/pull/11954#discussion_r420492664
##########
File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/typeutils/FieldInfoUtilsTest.java
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.typeutils;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeinfo.Types;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.expressions.Expression;
+import org.apache.flink.table.expressions.UnresolvedCallExpression;
+import org.apache.flink.table.expressions.UnresolvedReferenceExpression;
+import org.apache.flink.table.expressions.ValueLiteralExpression;
+import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
+import org.apache.flink.table.functions.FunctionIdentifier;
+import org.apache.flink.table.types.DataType;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.Arrays;
+
+/**
+ * Test suite for {@link FieldInfoUtils}.
+ */
+public class FieldInfoUtilsTest {
+
+ private static final RowTypeInfo typeInfo = new RowTypeInfo(
Review comment:
sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #11954: [FLINK-17420][table sql / api]Cannot alias Tuple and Row fields when converting DataStream to Table
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #11954:
URL: https://github.com/apache/flink/pull/11954#discussion_r420158210
##########
File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/typeutils/FieldInfoUtilsTest.java
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.typeutils;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeinfo.Types;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.expressions.Expression;
+import org.apache.flink.table.expressions.UnresolvedCallExpression;
+import org.apache.flink.table.expressions.UnresolvedReferenceExpression;
+import org.apache.flink.table.expressions.ValueLiteralExpression;
+import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
+import org.apache.flink.table.functions.FunctionIdentifier;
+import org.apache.flink.table.types.DataType;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.Arrays;
+
+/**
+ * Test suite for {@link FieldInfoUtils}.
+ */
+public class FieldInfoUtilsTest {
+
+ private static final RowTypeInfo typeInfo = new RowTypeInfo(
Review comment:
Could you backport the tests from the master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11954: [FLINK-17420][table sql / api]Cannot alias Tuple and Row fields when converting DataStream to Table
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11954:
URL: https://github.com/apache/flink/pull/11954#issuecomment-621611564
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6a37ff126c35f1d7b35fb50ccff89f200967b2da (Thu Apr 30 04:53:23 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11954: [FLINK-17420][table sql / api]Cannot alias Tuple and Row fields when converting DataStream to Table
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11954:
URL: https://github.com/apache/flink/pull/11954#issuecomment-621615631
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6a37ff126c35f1d7b35fb50ccff89f200967b2da",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162875532",
"triggerID" : "6a37ff126c35f1d7b35fb50ccff89f200967b2da",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a37ff126c35f1d7b35fb50ccff89f200967b2da Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162875532)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11954: [FLINK-17420][table sql / api]Cannot alias Tuple and Row fields when converting DataStream to Table
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11954:
URL: https://github.com/apache/flink/pull/11954#issuecomment-621615631
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6a37ff126c35f1d7b35fb50ccff89f200967b2da",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6a37ff126c35f1d7b35fb50ccff89f200967b2da",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a37ff126c35f1d7b35fb50ccff89f200967b2da UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org