[jira] [Commented] (ARTEMIS-598) Incorrect message id in NativeLogger.java

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359564#comment-15359564 ] 

ASF GitHub Bot commented on ARTEMIS-598:
----------------------------------------

GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/615

    ARTEMIS-598 fix native logger code

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-598

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/615.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #615
    
----
commit 2a144bc4eec59390bc792bcba75992a7db4787b4
Author: jbertram <jb...@apache.org>
Date:   2016-07-01T20:14:15Z

    ARTEMIS-598 fix native logger code

----


> Incorrect message id in NativeLogger.java
> -----------------------------------------
>
>                 Key: ARTEMIS-598
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-598
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 1.3.0
>            Reporter: Lionel Cons
>            Assignee: Justin Bertram
>
> All the message ids are 6 digits long except in {{artemis-native/src/main/java/org/apache/activemq/artemis/jlibaio/NativeLogger.java}} where the code contains:
> {code}
> /**
>  * Logger Code 14
>  *
>  * each message id must be 6 digits long starting with 14, the 3rd digit donates the level so
>  *
>  * INF0  1
>  * WARN  2
>  * DEBUG 3
>  * ERROR 4
>  * TRACE 5
>  * FATAL 6
>  *
>  * so an INFO message would be 1000 to 6000
>  */
> {code}
> but also:
> {code}
>    @Message(id = 1001, value = "You have a native library with a different version than expected", format = Message.Format.MESSAGE_FORMAT)
> {code}
> So this message id seems to be incorrect.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)