You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/17 10:09:50 UTC

[GitHub] [flink] shuiqiangchen commented on a change in pull request #13155: [FLINK-18947][python] Support partitionCustom() operation for Python …

shuiqiangchen commented on a change in pull request #13155:
URL: https://github.com/apache/flink/pull/13155#discussion_r471377102



##########
File path: flink-python/src/main/java/org/apache/flink/streaming/api/operators/python/AbstractPythonFunctionOperator.java
##########
@@ -344,7 +345,7 @@ protected PythonEnvironmentManager createPythonEnvironmentManager() throws IOExc
 			return new ProcessPythonEnvironmentManager(
 				dependencyInfo,
 				getContainingTask().getEnvironment().getTaskManagerInfo().getTmpDirectories(),
-				System.getenv());
+				new HashMap<>(System.getenv()));

Review comment:
       Because System.getenv() returns a Collections.unmodifiableMap that we can not set any new env variables, therefore we will put it into a new HashMap.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org