You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/22 20:36:39 UTC

[GitHub] [tvm] Wheest commented on pull request #7142: Asymmetric padding in conv2d workload

Wheest commented on pull request #7142:
URL: https://github.com/apache/tvm/pull/7142#issuecomment-749763887


   Happy to add a test case if necessary, though I'm still to get familiar with the testing infrastructure for TVM.
   
   Existing specific TOPI conv2d implementations are tested with asymmetric padding under `tests/python/topi/python/` (e.g. [test_topi_conv2d_nchw.py#L227](https://github.com/apache/tvm/blob/main/tests/python/topi/python/test_topi_conv2d_nchw.py#L227)).
   
   This change is just ensuring that data is held in the workload too.  If all of the existing tests pass, is that sufficient? 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org