[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10151: [python] Fix process definition attr release state not work

[GitBox <gi...@apache.org>]

zhongjiajie commented on code in PR #10151:
URL: https://github.com/apache/dolphinscheduler/pull/10151#discussion_r880001470


##########
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/core/process_definition.py:
##########
@@ -381,6 +400,7 @@ def submit(self) -> int:
             self.timeout,
             self.worker_group,
             self._tenant,
+            self.release_state,

Review Comment:
   It should be `self._release_state`, because we want to covert the input string `online` or `offline` to output int `0` or `1`. So we have a `property` named `release_state` to do it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org