You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/07 16:58:31 UTC
[GitHub] [superset] codecov-io edited a comment on pull request #12992: feat(native-filters): Time native filter
codecov-io edited a comment on pull request #12992:
URL: https://github.com/apache/superset/pull/12992#issuecomment-774707860
# [Codecov](https://codecov.io/gh/apache/superset/pull/12992?src=pr&el=h1) Report
> Merging [#12992](https://codecov.io/gh/apache/superset/pull/12992?src=pr&el=desc) (56c5fc4) into [master](https://codecov.io/gh/apache/superset/commit/76c225db7ee464d5b642cf7e0aa6c990df88f99d?el=desc) (76c225d) will **decrease** coverage by `2.90%`.
> The diff coverage is `39.39%`.
[](https://codecov.io/gh/apache/superset/pull/12992?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12992 +/- ##
==========================================
- Coverage 69.14% 66.23% -2.91%
==========================================
Files 1025 542 -483
Lines 48765 20193 -28572
Branches 5188 5269 +81
==========================================
- Hits 33718 13375 -20343
+ Misses 14913 6642 -8271
- Partials 134 176 +42
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `38.48% <62.50%> (-12.35%)` | :arrow_down: |
| javascript | `61.63% <3.03%> (-0.21%)` | :arrow_down: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12992?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12992/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `51.70% <ø> (-0.69%)` | :arrow_down: |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12992/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.89% <ø> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12992/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `83.60% <ø> (ø)` | |
| [...end/src/filters/components/Time/AntdTimeFilter.tsx](https://codecov.io/gh/apache/superset/pull/12992/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL0FudGRUaW1lRmlsdGVyLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...tend/src/filters/components/Time/transformProps.ts](https://codecov.io/gh/apache/superset/pull/12992/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL3RyYW5zZm9ybVByb3BzLnRz) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/filters/components/index.ts](https://codecov.io/gh/apache/superset/pull/12992/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/12992/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/filters/components/Time/index.ts](https://codecov.io/gh/apache/superset/pull/12992/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL2luZGV4LnRz) | `33.33% <33.33%> (ø)` | |
| [...ontend/src/filters/components/Time/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/12992/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL2NvbnRyb2xQYW5lbC50cw==) | `50.00% <50.00%> (ø)` | |
| [...s/controls/DateFilterControl/DateFilterControl.tsx](https://codecov.io/gh/apache/superset/pull/12992/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyQ29udHJvbC50c3g=) | `69.35% <70.37%> (-14.27%)` | :arrow_down: |
| ... and [619 more](https://codecov.io/gh/apache/superset/pull/12992/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12992?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12992?src=pr&el=footer). Last update [76c225d...56c5fc4](https://codecov.io/gh/apache/superset/pull/12992?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org