You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Vikas Mayur (JIRA)" <ji...@apache.org> on 2008/03/08 10:29:46 UTC
[jira] Created: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
----------------------------------------------------------------------------------------------------------------------------------------
Key: OFBIZ-1700
URL: https://issues.apache.org/jira/browse/OFBIZ-1700
Project: OFBiz
Issue Type: New Feature
Reporter: Vikas Mayur
We can put OFBiz Revision Number :
1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
2) In the footer file. Refer to screenshot2 a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-1700) To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
Posted by Jacques Le Roux <ja...@les7arts.com>.
Yes this seems wiser/simpler indeed.
The "unknown" generation should not be only in "ant build"' I guess, at least "ant run-install" as well and surely more (I use
mostly these 2)
Jacques
From: "Bruno Busco" <br...@gmail.com>
> Yes,
> this is a good point.
> I agree but I then suggest to have the svninfo.ftl not committed.
> It will be created by a "ant build" command (with "unknown") and/or by the
> "ant svinfo" (with the correct version).
>
> If this is ok I will proceed to update the patch.
> -Bruno
>
> 2009/2/3 Jacques Le Roux (JIRA) <ji...@apache.org>
>
>>
>> [
>> https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670010#action_12670010]
>>
>> Jacques Le Roux commented on OFBIZ-1700:
>> ----------------------------------------
>>
>> Hi Bruno,
>>
>> It's great, but I see a problem with this approach : if for a reason or
>> another svninfo is not run, then svninfo.ftl will contain a wrong release
>> number.
>> I suggest that
>> * we put "unknown" in place of ??? by default (more clear)
>> * we put back "unknown" in svninfo.ftl when "build", or a "run-" target is
>> run (maybe did not look into details)
>>
>> My 2cts
>>
>> > To show Current Revision number of OFBiz on its home site that will
>> facilate in testing and comparing things with a local copy of OFBiz
>> >
>> ----------------------------------------------------------------------------------------------------------------------------------------
>> >
>> > Key: OFBIZ-1700
>> > URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>> > Project: OFBiz
>> > Issue Type: New Feature
>> > Reporter: Vikas Mayur
>> > Assignee: Jacques Le Roux
>> > Attachments: about_app.zip, about_ss.JPG, screenshot1.png,
>> screenshot2.png, svninfo.patch, svninfo.patch, svninfo_ss1.gif,
>> svninfo_ss2.gif
>> >
>> >
>> > We can put OFBiz Revision Number :
>> > 1) along with the Trunk and Release labels under Demo Sites section in
>> OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
>> > 2) In the footer file. Refer to screenshot2 & a discussion started by
>> Jacques at
>> http://www.nabble.com/Mention-of-version---in-release-to13078575.html
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
Re: [jira] Commented: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by Bruno Busco <br...@gmail.com>.
Yes,
this is a good point.
I agree but I then suggest to have the svninfo.ftl not committed.
It will be created by a "ant build" command (with "unknown") and/or by the
"ant svinfo" (with the correct version).
If this is ok I will proceed to update the patch.
-Bruno
2009/2/3 Jacques Le Roux (JIRA) <ji...@apache.org>
>
> [
> https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670010#action_12670010]
>
> Jacques Le Roux commented on OFBIZ-1700:
> ----------------------------------------
>
> Hi Bruno,
>
> It's great, but I see a problem with this approach : if for a reason or
> another svninfo is not run, then svninfo.ftl will contain a wrong release
> number.
> I suggest that
> * we put "unknown" in place of ??? by default (more clear)
> * we put back "unknown" in svninfo.ftl when "build", or a "run-" target is
> run (maybe did not look into details)
>
> My 2cts
>
> > To show Current Revision number of OFBiz on its home site that will
> facilate in testing and comparing things with a local copy of OFBiz
> >
> ----------------------------------------------------------------------------------------------------------------------------------------
> >
> > Key: OFBIZ-1700
> > URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> > Project: OFBiz
> > Issue Type: New Feature
> > Reporter: Vikas Mayur
> > Assignee: Jacques Le Roux
> > Attachments: about_app.zip, about_ss.JPG, screenshot1.png,
> screenshot2.png, svninfo.patch, svninfo.patch, svninfo_ss1.gif,
> svninfo_ss2.gif
> >
> >
> > We can put OFBiz Revision Number :
> > 1) along with the Trunk and Release labels under Demo Sites section in
> OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> > 2) In the footer file. Refer to screenshot2 & a discussion started by
> Jacques at
> http://www.nabble.com/Mention-of-version---in-release-to13078575.html
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610339#action_12610339 ]
Jacques Le Roux commented on OFBIZ-1700:
----------------------------------------
Should we close this issue ? No one seems really interested...
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670818#action_12670818 ]
Jacques Le Roux commented on OFBIZ-1700:
----------------------------------------
There is a problem with this approach : if the svninfo.ftl does not exist you get
Error rendering included template at location [component://bluelight/includes/footer.ftl]: java.lang.IllegalArgumentException: FreeMarker file not found at location: component://common/webcommon/includes/../../../../runtime/svninfo.ftl
Not sure how to test the file existence in footer.ftl ([I checked : no option in include|http://freemarker.org/docs/ref_directive_include.html])
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux updated OFBIZ-1700:
-----------------------------------
Attachment: svninfo.patch
Something like last patch
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reopened OFBIZ-1700:
------------------------------------
We need that !
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1700.
----------------------------------
Resolution: Fixed
Assignee: Bruno Busco (was: Jacques Le Roux)
Thanks Bruno,
Your patch is un trunk at revision: 744841
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Bruno Busco
> Fix For: SVN trunk
>
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_build.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670704#action_12670704 ]
Jacopo Cappellato commented on OFBIZ-1700:
------------------------------------------
>From the dev list:
Bruno,
I like the approach you are taking (an ant target that writes the rev id into a text file that is then included into the footer).
However, it would be great if you would address the following scenarios/:
1) svn is not available: the build process should proceed without errors
2) the ant svn plugin is not available (I think it is an optional lib): the build process should proceed without errors
3) internate connection is not available when the ant target is invoked: the build process should proceed without errors
4) evaluate possible license issues (if any) with the ant svn plugin
5) (as Tim mentioned) the trunk was exported instead of checked out
Ideally, in all these situations the footer should show an empty rev id.
Also, where should we place the text file with the rev number in it? I'd suggest in the runtime folder (so that we don't write files inside the framework).
Just my 2 cents,
Jacopo
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-1700:
-------------------------------
Attachment: svninfo_build.patch
Please find attached a new patch (svninfo_build.patch) that contains mysolution proposal:
- The "run" target is not anymore dependent on the "build" target
I do not know it this breaks something but this will allow to have the build and run separated so that the standard procedure after a SVN update should be:
ant run-install
ant svninfo
ant run
Hope this is a good solution.
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_build.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-1700:
-------------------------------
Attachment: svninfo_ss2.gif
svninfo_ss1.gif
In the attached files you can see how the link looks like in the footer (svninfo_ss1.gif) and what you get when you click on it (svninfo_ss2.gif)
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Attachments: screenshot1.png, screenshot2.png, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur updated OFBIZ-1700:
-------------------------------
Attachment: screenshot2.png
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Attachments: screenshot1.png, screenshot2.png
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672075#action_12672075 ]
Jacques Le Roux commented on OFBIZ-1700:
----------------------------------------
Bruno,
It seems that your last comment does not correspond with the changes to build.xml in your patch. Because it's not the svninfo target which is run at the end of the build target but svninfo-clean. Hence we have a problem there because we can't force the build and run-install targets to run the target svninfo (in case there is no svn there as Tim and Jacopo outlined). The effects of the problem we have are currently visible on the demo server...
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670739#action_12670739 ]
Bruno Busco commented on OFBIZ-1700:
------------------------------------
Hi Jacopo,
please find hereafter how it should work in the different scenarios:
1) svn is not available: the build process should proceed without errors
- OK if svn is not available the and svn-info should not be invoked the build batch file should only call the "ant run-install" and not the "ant svninfo"
2) the ant svn plugin is not available (I think it is an optional lib): the build process should proceed without errors
- The patch does not use any ant svn plugin. It is based on a "exec" task that calls the "svn" command through the os shell
3) internate connection is not available when the ant target is invoked: the build process should proceed without errors
- Again the svninfo is a different task that should be called separately by a batch file. If the connection is not available, only this will fail and the svn version will be "unknoun"
4) evaluate possible license issues (if any) with the ant svn plugin
- Please see 2)
5) (as Tim mentioned) the trunk was exported instead of checked out
- Please see 1)
I agree, may be it is better to have and empty default value instead of the last proposed "Rev: unknown (run "ant svninfo" to show your version)"
OK, I think it is better to have it in runtime folder.
I will update the patch accordingly.
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1700.
----------------------------------
Resolution: Later
Assignee: Jacques Le Roux
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670840#action_12670840 ]
Bruno Busco commented on OFBIZ-1700:
------------------------------------
Jacques,
the svninfo.ftl is created (empty) as soon as the build target is run.
So I do not see this problem.
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur updated OFBIZ-1700:
-------------------------------
Attachment: screenshot1.png
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Attachments: screenshot1.png, screenshot2.png
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-1700:
-------------------------------
Attachment: svninfo.patch
Hi All,
please find attached an updated patch with the following changes:
1) the svninfo.ftl file is created and included from the runtime folder
2) the svn-clean task now clears the svninfo.ftl file so that no revision info are there
3) the path is also displayed to the string would be "Rev: trunk 741088" of for example "Rev: release9.3 741088"
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur updated OFBIZ-1700:
-------------------------------
Description:
We can put OFBiz Revision Number :
1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
was:
We can put OFBiz Revision Number :
1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
2) In the footer file. Refer to screenshot2 a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Attachments: screenshot1.png, screenshot2.png
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672447#action_12672447 ]
Jacques Le Roux commented on OFBIZ-1700:
----------------------------------------
# : +1
# : This explains why it's not showing on Demo server. On Windows I can't see that since I use .bat commands. I rely on you for a solution :)
Thanks
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux updated OFBIZ-1700:
-----------------------------------
Attachment: svninfo.patch
patch with : (run "ant svninfo" to show your version)
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670010#action_12670010 ]
Jacques Le Roux commented on OFBIZ-1700:
----------------------------------------
Hi Bruno,
It's great, but I see a problem with this approach : if for a reason or another svninfo is not run, then svninfo.ftl will contain a wrong release number.
I suggest that
* we put "unknown" in place of ??? by default (more clear)
* we put back "unknown" in svninfo.ftl when "build", or a "run-" target is run (maybe did not look into details)
My 2cts
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670555#action_12670555 ]
Jacques Le Roux commented on OFBIZ-1700:
----------------------------------------
I think, it's always better to keep comments in issue and not diverging on dev ML
{quote}Yes this seems wiser/simpler indeed.
The "unknown" generation should not be only in "ant build"' I guess, at least "ant run-install" as well and surely more (I use
mostly these 2)
Jacques
From: "Bruno Busco" <br...@gmail.com>
> Yes,
> this is a good point.
> I agree but I then suggest to have the svninfo.ftl not committed.
> It will be created by a "ant build" command (with "unknown") and/or by the
> "ant svinfo" (with the correct version).
>
> If this is ok I will proceed to update the patch.
> -Bruno
{quote}
Finally I thought about that a bit more and I think it's easier to do it as I did : you don't have to worry about existing and future targets. In any case, if svninfo was not run, "unknown" will be shown. We may even put an information about that in svinfo.ftl : instead of only
unknwon
put
unknwon (run "ant svninfo" to show your version)
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1700.
----------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Thanks to All!
The last patch is in trunk, I just moved the "- " string into svninfo.ft to not show a when there is no information. I also ignored svninfo.ftl in runtime
One think which is cool with these new feature is that it's dynamic. OFBiz running if you run "ant svninfo" and refresh screen you get the R.r information in footer :)
On demo server we just need to run svninfo target after build.
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670852#action_12670852 ]
Jacques Le Roux commented on OFBIZ-1700:
----------------------------------------
Right, except when you update without building (like I did, because building was not needed - only ftl file changes ;)) I agree that this is marginal.
So IMO, if we agree that It is the "admin" responsability to build or to use svninfo-clean each time an svn update is done (else a wrong information will stay) this patch is ok to be commited.
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-1700:
-------------------------------
Attachment: about_ss.JPG
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671083#action_12671083 ]
Jacques Le Roux commented on OFBIZ-1700:
----------------------------------------
Commited in revision: 741514
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672434#action_12672434 ]
Bruno Busco commented on OFBIZ-1700:
------------------------------------
Better looking at the build.xml file we have now I noted this:
1) the "svninfo-clean" target should read "clean-svninfo" because this is the common pattern living into build.xml
2) when the "run" target is used to start OFBiz this triggers the "build" target also and we have made the "build" target to clear the version info in the svn-info.ftl file. I normally use startofbiz.bat and startofbiz.sh to start ofbiz and it works well but using the "run" target will invalidate any "ant svn-info" command and the version will never be displayed.
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-1700:
-------------------------------
Attachment: svninfo.patch
A very simple solution could be the following: (implemented in the attached "svninfo.patch")
The footer.ftl includes a link to an external file (/images/svninfo.txt).
This file is generated with a new ant task that can be run with "ant svninfo".
The ant task uses the "svn info" command and captures the output.
In the patch there is a default svninfo.txt file that should be committed that contains the following:
-----------------------
**** SVN info not present !!! ****
**** Please run "ant svninfo" ****
-----------------------
When the ant task is run it is overwritten and the correct svn information are displayed as follows:
-----------------------
Percorso: .
URL: http://svn.apache.org/repos/asf/ofbiz/trunk
Repository: http://svn.apache.org/repos/asf
UUID del Repository: 13f79535-47bb-0310-9956-ffa450edef68
Revisione: 634426
Tipo di Nodo: directory
Azione: normale
Autore dell'Ultimo Cambiamento: chrisg
Revisione dell'Ultimo Cambiamento: 634226
Data dell'Ultimo Cambiamento: 2008-03-06 12:33:26 +0100 (gio, 06 mar 2008)
-----------------------
The best would be IMHO to have the additional link in the footer only if a configuration property is set so that could be disabled for production installations.
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Attachments: screenshot1.png, screenshot2.png, svninfo.patch
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco reopened OFBIZ-1700:
--------------------------------
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-1700:
-------------------------------
Attachment: svninfo.patch
Please find attached a new patch.
This solution is much simpler:
The ant svninfo task does everithing. The Abouut application is not necessary.
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-1700:
-------------------------------
Attachment: about_app.zip
Hi,
I have worked a little bit on this issue and have set up a little application that you can find in the about_app.zip attachment. (see about_ss.jpg for a sample screenshot). Hereafter i post the content of the readme.txt file that is also included in the app.
Hope this helps!
--------------------------------------------------------
This application can be used to show to the OFBiz user information about the SVN revision that has originated the running release.
Requisite:
- The "svn" command line Subversion client must present in the system and available on the execution path.
- The OFBiz ant build task must be executed from a valid SVN working copy (.svn directories must be present)
Installation:
- Copy the About application in the OFBiz hot-deploy directory
Usage:
- Every time the OFBiz working copy is updated from the SVN repository the ant "build" target must be executed. This can be done
simply running the "ant refresh" command on the OFBiz
- The information are shown selecting the About application
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673392#action_12673392 ]
Jacques Le Roux commented on OFBIZ-1700:
----------------------------------------
Before commiting this patch I would like to know if someone care about run no longer depends on build...
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_build.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670024#action_12670024 ]
Adrian Crum commented on OFBIZ-1700:
------------------------------------
It's unfortunate we don't have a way to set up the repository so that each revision number is stored in a file in the OFBiz home folder. The current revision could be read from the file during OFBiz startup, stored internally, and then accessed for display.
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1700) To show Current Revision number of
OFBiz on its home site that will facilate in testing and comparing things
with a local copy of OFBiz
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672078#action_12672078 ]
Jacques Le Roux commented on OFBIZ-1700:
----------------------------------------
Hi Bruno,
Please forget my last comment : tired :(
> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1700
> URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Vikas Mayur
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
> We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.