You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2023/04/23 03:18:53 UTC
[GitHub] [doris] Mryange opened a new pull request, #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Mryange opened a new pull request, #18942:
URL: https://github.com/apache/doris/pull/18942
# Proposed changes
In the past code, we could determine the type at compile time by "type.is_string_or_fixed_string()".
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1540303617
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1520191147
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1527657686
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1518931182
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1523476753
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #18942:
URL: https://github.com/apache/doris/pull/18942#discussion_r1177164136
##########
be/src/vec/exprs/vbloom_predicate.cpp:
##########
@@ -94,18 +94,34 @@ Status VBloomPredicate::execute(VExprContext* context, Block* block, int* result
if (type.is_string_or_fixed_string()) {
// When _be_exec_version is equal to or greater than 2, we use the new hash method.
// This is only to be used if the be_exec_version may be less than 2. If updated, please delete it.
+ // remove virtual function call in get_data_at to improve performance (argument_column->get_data_at(i)).
+ auto column_nested = reinterpret_cast<const ColumnNullable*>(argument_column.get())
+ ->get_nested_column_ptr();
+ auto column_nullmap = reinterpret_cast<const ColumnNullable*>(argument_column.get())
+ ->get_null_map_column_ptr();
if (_be_exec_version >= 2) {
for (size_t i = 0; i < sz; i++) {
- /// TODO: remove virtual function call in get_data_at to improve performance
- auto ele = argument_column->get_data_at(i);
- const StringRef v(ele.data, ele.size);
Review Comment:
why not do the cast in line 98 and 100 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1520912783
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1539654134
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1518930733
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1519386394
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1539649296
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1539477581
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1521439130
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1521553534
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1523469427
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1518976460
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1519193922
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1519675746
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1519195590
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1521551051
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1521692234
run builall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1519195034
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1519498316
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1520976004
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1519031225
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1519030477
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange closed pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange closed pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
URL: https://github.com/apache/doris/pull/18942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1519681743
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1521092588
run clickbench
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zclllyybb commented on a diff in pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #18942:
URL: https://github.com/apache/doris/pull/18942#discussion_r1176150300
##########
be/src/vec/exprs/vbloom_predicate.cpp:
##########
@@ -94,18 +94,34 @@ Status VBloomPredicate::execute(VExprContext* context, Block* block, int* result
if (type.is_string_or_fixed_string()) {
// When _be_exec_version is equal to or greater than 2, we use the new hash method.
// This is only to be used if the be_exec_version may be less than 2. If updated, please delete it.
+ // remove virtual function call in get_data_at to improve performance (argument_column->get_data_at(i)).
+ auto column_nested = reinterpret_cast<const ColumnNullable*>(argument_column.get())
+ ->get_nested_column_ptr();
+ auto column_nullmap = reinterpret_cast<const ColumnNullable*>(argument_column.get())
+ ->get_null_map_column_ptr();
if (_be_exec_version >= 2) {
for (size_t i = 0; i < sz; i++) {
- /// TODO: remove virtual function call in get_data_at to improve performance
- auto ele = argument_column->get_data_at(i);
- const StringRef v(ele.data, ele.size);
- ptr[i] = _filter->find_crc32_hash(reinterpret_cast<const void*>(&v));
+ if (assert_cast<const ColumnUInt8&>(*column_nullmap).get_data()[i] != 0) {
+ StringRef v((const char*)nullptr, 0);
+ ptr[i] = _filter->find_crc32_hash(reinterpret_cast<const void*>(&v));
+ } else {
+ auto ele = assert_cast<const ColumnString*>(column_nested.get())
+ ->get_string_data_at(i);
Review Comment:
do not add this, just use `get_data_at`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1521432817
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1521784752
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1522695579
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18942:
URL: https://github.com/apache/doris/pull/18942#issuecomment-1524202678
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #18942:
URL: https://github.com/apache/doris/pull/18942#discussion_r1187560813
##########
be/src/vec/exprs/vbloom_predicate.cpp:
##########
@@ -94,18 +94,34 @@ Status VBloomPredicate::execute(VExprContext* context, Block* block, int* result
if (type.is_string_or_fixed_string()) {
// When _be_exec_version is equal to or greater than 2, we use the new hash method.
// This is only to be used if the be_exec_version may be less than 2. If updated, please delete it.
+ // remove virtual function call in get_data_at to improve performance (argument_column->get_data_at(i)).
+ auto column_nested = reinterpret_cast<const ColumnNullable*>(argument_column.get())
Review Comment:
why the column is nullable? maybe the column is not null column ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org