You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Morio Ramdenbourg via Review Board <no...@reviews.apache.org> on 2019/03/20 17:07:38 UTC
Review Request 70256: HIVE-21480: Fixed flaky and broken test
TestHiveMetaStore.testJDOPersistenceManagerCleanup
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70256/
-----------------------------------------------------------
Review request for hive, Adam Holley, Karthik Manamcheri, Karen Coppage, and Vihang Karajgaonkar.
Repository: hive-git
Description
-------
This test was not correctly counting the number of
objects in the PersistenceManager cache before and after HiveMetaStoreClient.close(). The
getJDOPersistenceManagerCacheSize() internal helper method did not use
the updated fields present in the metastore classes, and was
consistently returning -1. Additionally, there was a chance to cause
flakiness since the object count before and after close() could
differ depending on lingering objects from previous
tests or setup.
Modified the helper method to use the new
fields, and fixed the flakiness on this test.
Diffs
-----
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 77e0c98265e7b561f2eb39536e3251dd92e9cab0
Diff: https://reviews.apache.org/r/70256/diff/1/
Testing
-------
Unit tests run
Thanks,
Morio Ramdenbourg
Re: Review Request 70256: HIVE-21480: Fixed flaky and broken test
TestHiveMetaStore.testJDOPersistenceManagerCleanup
Posted by Morio Ramdenbourg via Review Board <no...@reviews.apache.org>.
> On March 20, 2019, 6:41 p.m., Karthik Manamcheri wrote:
> > LGTM. get someone else a little more familiar with the tests (vihang, pvary or someone) to also do a quick review. thanks.
Thanks for the review :)
- Morio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70256/#review213843
-----------------------------------------------------------
On March 20, 2019, 6:43 p.m., Morio Ramdenbourg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70256/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 6:43 p.m.)
>
>
> Review request for hive, Adam Holley, Karthik Manamcheri, Karen Coppage, Peter Vary, and Vihang Karajgaonkar.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> This test was not correctly counting the number of
> objects in the PersistenceManager cache before and after HiveMetaStoreClient.close(). The
> getJDOPersistenceManagerCacheSize() internal helper method did not use
> the updated fields present in the metastore classes, and was
> consistently returning -1. Additionally, there was a chance to cause
> flakiness since the object count before and after close() could
> differ depending on lingering objects from previous
> tests or setup.
>
> Modified the helper method to use the new
> fields, and fixed the flakiness on this test.
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 77e0c98265e7b561f2eb39536e3251dd92e9cab0
>
>
> Diff: https://reviews.apache.org/r/70256/diff/1/
>
>
> Testing
> -------
>
> Unit tests run
>
>
> Thanks,
>
> Morio Ramdenbourg
>
>
Re: Review Request 70256: HIVE-21480: Fixed flaky and broken test
TestHiveMetaStore.testJDOPersistenceManagerCleanup
Posted by Karthik Manamcheri via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70256/#review213843
-----------------------------------------------------------
Ship it!
LGTM. get someone else a little more familiar with the tests (vihang, pvary or someone) to also do a quick review. thanks.
- Karthik Manamcheri
On March 20, 2019, 5:07 p.m., Morio Ramdenbourg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70256/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 5:07 p.m.)
>
>
> Review request for hive, Adam Holley, Karthik Manamcheri, Karen Coppage, and Vihang Karajgaonkar.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> This test was not correctly counting the number of
> objects in the PersistenceManager cache before and after HiveMetaStoreClient.close(). The
> getJDOPersistenceManagerCacheSize() internal helper method did not use
> the updated fields present in the metastore classes, and was
> consistently returning -1. Additionally, there was a chance to cause
> flakiness since the object count before and after close() could
> differ depending on lingering objects from previous
> tests or setup.
>
> Modified the helper method to use the new
> fields, and fixed the flakiness on this test.
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 77e0c98265e7b561f2eb39536e3251dd92e9cab0
>
>
> Diff: https://reviews.apache.org/r/70256/diff/1/
>
>
> Testing
> -------
>
> Unit tests run
>
>
> Thanks,
>
> Morio Ramdenbourg
>
>