You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2015/06/12 18:10:29 UTC
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/830
[legal] Updates LICENSE/NOTICE file of source and binary distribution
I went through the dependencies of our source and binary distribution and updated the corresponding LICENSE/NOTICE files. I would appreciate if a second pair of eyes could verify my changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixLicense
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/830.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #830
----
commit c87302129fa57176984cdfc9baf36145c82b3c25
Author: Till Rohrmann <tr...@apache.org>
Date: 2015-06-11T13:00:07Z
[legal] Updates LICENSE/NOTICE file of source and binary distribution
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/830#discussion_r32501126
--- Diff: flink-dist/src/main/flink-bin/NOTICE ---
@@ -407,3 +391,86 @@ LongAdder), which was released with the following comments:
http://creativecommons.org/publicdomain/zero/1.0/
+-----------------------------------------------------------------------
+ Snappy-Java
+-----------------------------------------------------------------------
+
+This product includes software developed by Google
+ Snappy: http://code.google.com/p/snappy/ (New BSD License)
+
+This product includes software developed by Apache
+ PureJavaCrc32C from apache-hadoop-common http://hadoop.apache.org/
+ (Apache 2.0 license)
+
+This library containd statically linked libstdc++. This inclusion is allowed by
+"GCC RUntime Library Exception"
+http://gcc.gnu.org/onlinedocs/libstdc++/manual/license.html
+
+== Contributors ==
+ * Tatu Saloranta
+ * Providing benchmark suite
+ * Alec Wysoker
+ * Performance and memory usage improvement
+
+
+-----------------------------------------------------------------------
+ Apache Commmons Compress
+-----------------------------------------------------------------------
+
+Apache Commons Compress
+Copyright 2002-2015 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+The files in the package org.apache.commons.compress.archivers.sevenz
+were derived from the LZMA SDK, version 9.20 (C/ and CPP/7zip/),
+which has been placed in the public domain:
+
+"LZMA SDK is placed in the public domain." (http://www.7-zip.org/sdk.html)
+
+
+-----------------------------------------------------------------------
+ Httpclient
+-----------------------------------------------------------------------
+
+Apache HttpComponents Client
+Copyright 1999-2015 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+
+-----------------------------------------------------------------------
+ Httpcore
--- End diff --
Check :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/830#discussion_r32500834
--- Diff: LICENSE ---
@@ -218,13 +218,9 @@ conditions of their respective licenses.
The Apache Flink project bundles the following files under the MIT License:
- jQuery v2.1.0. (http://jquery.com) - Copyright 2014 jQuery Foundation and other contributors
- - jQuery resize event v1.1 (http://benalman.com/projects/jquery-resize-plugin/) - Copyright (c) 2010 "Cowboy" Ben Alman
--- End diff --
I'm not a JavaScript expert but I can neither find parts of Ben's non-minified code [1] nor parts of the minified code [2] in our repository. But maybe we're using a different version somewhere.
[1] https://raw.githubusercontent.com/cowboy/jquery-resize/v1.1/jquery.ba-resize.js
[2] https://raw.githubusercontent.com/cowboy/jquery-resize/v1.1/jquery.ba-resize.min.js
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/830#discussion_r32488023
--- Diff: flink-dist/src/main/flink-bin/NOTICE ---
@@ -407,3 +391,86 @@ LongAdder), which was released with the following comments:
http://creativecommons.org/publicdomain/zero/1.0/
+-----------------------------------------------------------------------
+ Snappy-Java
+-----------------------------------------------------------------------
+
+This product includes software developed by Google
+ Snappy: http://code.google.com/p/snappy/ (New BSD License)
+
+This product includes software developed by Apache
+ PureJavaCrc32C from apache-hadoop-common http://hadoop.apache.org/
+ (Apache 2.0 license)
+
+This library containd statically linked libstdc++. This inclusion is allowed by
+"GCC RUntime Library Exception"
+http://gcc.gnu.org/onlinedocs/libstdc++/manual/license.html
+
+== Contributors ==
+ * Tatu Saloranta
+ * Providing benchmark suite
+ * Alec Wysoker
+ * Performance and memory usage improvement
+
+
+-----------------------------------------------------------------------
+ Apache Commmons Compress
+-----------------------------------------------------------------------
+
+Apache Commons Compress
+Copyright 2002-2015 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+The files in the package org.apache.commons.compress.archivers.sevenz
+were derived from the LZMA SDK, version 9.20 (C/ and CPP/7zip/),
+which has been placed in the public domain:
+
+"LZMA SDK is placed in the public domain." (http://www.7-zip.org/sdk.html)
+
+
+-----------------------------------------------------------------------
--- End diff --
I think that Till is right, we need to include the NOTICE files from the bundled dependencies. The binary NOTICE file is for convenience anyways, but if we provide it, it needs to forward the dependencies' NOTICE files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/830#discussion_r32452060
--- Diff: flink-dist/src/main/flink-bin/NOTICE ---
@@ -407,3 +391,86 @@ LongAdder), which was released with the following comments:
http://creativecommons.org/publicdomain/zero/1.0/
+-----------------------------------------------------------------------
+ Snappy-Java
+-----------------------------------------------------------------------
+
+This product includes software developed by Google
+ Snappy: http://code.google.com/p/snappy/ (New BSD License)
+
+This product includes software developed by Apache
+ PureJavaCrc32C from apache-hadoop-common http://hadoop.apache.org/
+ (Apache 2.0 license)
+
+This library containd statically linked libstdc++. This inclusion is allowed by
+"GCC RUntime Library Exception"
+http://gcc.gnu.org/onlinedocs/libstdc++/manual/license.html
+
+== Contributors ==
+ * Tatu Saloranta
+ * Providing benchmark suite
+ * Alec Wysoker
+ * Performance and memory usage improvement
+
+
+-----------------------------------------------------------------------
+ Apache Commmons Compress
+-----------------------------------------------------------------------
+
+Apache Commons Compress
+Copyright 2002-2015 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+The files in the package org.apache.commons.compress.archivers.sevenz
+were derived from the LZMA SDK, version 9.20 (C/ and CPP/7zip/),
+which has been placed in the public domain:
+
+"LZMA SDK is placed in the public domain." (http://www.7-zip.org/sdk.html)
+
+
+-----------------------------------------------------------------------
--- End diff --
Is no harm to add it here, but I think if the dependent project requires the NOTICE to be included then we should. Lets keep it here for safe side
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/830
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/830#discussion_r32487483
--- Diff: LICENSE ---
@@ -218,13 +218,9 @@ conditions of their respective licenses.
The Apache Flink project bundles the following files under the MIT License:
- jQuery v2.1.0. (http://jquery.com) - Copyright 2014 jQuery Foundation and other contributors
- - jQuery resize event v1.1 (http://benalman.com/projects/jquery-resize-plugin/) - Copyright (c) 2010 "Cowboy" Ben Alman
--- End diff --
tl:dr - I think we should keep these entries, actually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/830#discussion_r32355322
--- Diff: flink-dist/src/main/flink-bin/NOTICE ---
@@ -407,3 +391,86 @@ LongAdder), which was released with the following comments:
http://creativecommons.org/publicdomain/zero/1.0/
+-----------------------------------------------------------------------
+ Snappy-Java
+-----------------------------------------------------------------------
+
+This product includes software developed by Google
+ Snappy: http://code.google.com/p/snappy/ (New BSD License)
+
+This product includes software developed by Apache
+ PureJavaCrc32C from apache-hadoop-common http://hadoop.apache.org/
+ (Apache 2.0 license)
+
+This library containd statically linked libstdc++. This inclusion is allowed by
+"GCC RUntime Library Exception"
+http://gcc.gnu.org/onlinedocs/libstdc++/manual/license.html
+
+== Contributors ==
+ * Tatu Saloranta
+ * Providing benchmark suite
+ * Alec Wysoker
+ * Performance and memory usage improvement
+
+
+-----------------------------------------------------------------------
+ Apache Commmons Compress
+-----------------------------------------------------------------------
+
+Apache Commons Compress
+Copyright 2002-2015 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+The files in the package org.apache.commons.compress.archivers.sevenz
+were derived from the LZMA SDK, version 9.20 (C/ and CPP/7zip/),
+which has been placed in the public domain:
+
+"LZMA SDK is placed in the public domain." (http://www.7-zip.org/sdk.html)
+
+
+-----------------------------------------------------------------------
+ Httpclient
+-----------------------------------------------------------------------
+
+Apache HttpComponents Client
+Copyright 1999-2015 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+
+-----------------------------------------------------------------------
+ Httpcore
--- End diff --
I don't think we need to include separate NOTICE section for another Apache projects. We could keep it but I think not necessary
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/830#discussion_r32407281
--- Diff: flink-dist/src/main/flink-bin/NOTICE ---
@@ -407,3 +391,86 @@ LongAdder), which was released with the following comments:
http://creativecommons.org/publicdomain/zero/1.0/
+-----------------------------------------------------------------------
+ Snappy-Java
+-----------------------------------------------------------------------
+
+This product includes software developed by Google
+ Snappy: http://code.google.com/p/snappy/ (New BSD License)
+
+This product includes software developed by Apache
+ PureJavaCrc32C from apache-hadoop-common http://hadoop.apache.org/
+ (Apache 2.0 license)
+
+This library containd statically linked libstdc++. This inclusion is allowed by
+"GCC RUntime Library Exception"
+http://gcc.gnu.org/onlinedocs/libstdc++/manual/license.html
+
+== Contributors ==
+ * Tatu Saloranta
+ * Providing benchmark suite
+ * Alec Wysoker
+ * Performance and memory usage improvement
+
+
+-----------------------------------------------------------------------
+ Apache Commmons Compress
+-----------------------------------------------------------------------
+
+Apache Commons Compress
+Copyright 2002-2015 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+The files in the package org.apache.commons.compress.archivers.sevenz
+were derived from the LZMA SDK, version 9.20 (C/ and CPP/7zip/),
+which has been placed in the public domain:
+
+"LZMA SDK is placed in the public domain." (http://www.7-zip.org/sdk.html)
+
+
+-----------------------------------------------------------------------
--- End diff --
Hmm I thought that if an Apache-2.0 dependency contains a NOTICE file then we have to include the content it in our NOTICE file as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/830#discussion_r32489670
--- Diff: flink-dist/src/main/flink-bin/NOTICE ---
@@ -407,3 +391,86 @@ LongAdder), which was released with the following comments:
http://creativecommons.org/publicdomain/zero/1.0/
+-----------------------------------------------------------------------
+ Snappy-Java
+-----------------------------------------------------------------------
+
+This product includes software developed by Google
+ Snappy: http://code.google.com/p/snappy/ (New BSD License)
+
+This product includes software developed by Apache
+ PureJavaCrc32C from apache-hadoop-common http://hadoop.apache.org/
+ (Apache 2.0 license)
+
+This library containd statically linked libstdc++. This inclusion is allowed by
+"GCC RUntime Library Exception"
+http://gcc.gnu.org/onlinedocs/libstdc++/manual/license.html
+
+== Contributors ==
+ * Tatu Saloranta
+ * Providing benchmark suite
+ * Alec Wysoker
+ * Performance and memory usage improvement
+
+
+-----------------------------------------------------------------------
+ Apache Commmons Compress
+-----------------------------------------------------------------------
+
+Apache Commons Compress
+Copyright 2002-2015 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+The files in the package org.apache.commons.compress.archivers.sevenz
+were derived from the LZMA SDK, version 9.20 (C/ and CPP/7zip/),
+which has been placed in the public domain:
+
+"LZMA SDK is placed in the public domain." (http://www.7-zip.org/sdk.html)
+
+
+-----------------------------------------------------------------------
--- End diff --
Sounds good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/830#discussion_r32487473
--- Diff: LICENSE ---
@@ -218,13 +218,9 @@ conditions of their respective licenses.
The Apache Flink project bundles the following files under the MIT License:
- jQuery v2.1.0. (http://jquery.com) - Copyright 2014 jQuery Foundation and other contributors
- - jQuery resize event v1.1 (http://benalman.com/projects/jquery-resize-plugin/) - Copyright (c) 2010 "Cowboy" Ben Alman
--- End diff --
I think the here deleted lines are "transitively" includes, because their contents has been copied into one of the other files we include (by that files' authors). I therefore added them, because I was under the impression that those files were actually not respecting the license conditions properly, and that we should mention these dependencies to be correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/830#discussion_r32501088
--- Diff: flink-dist/src/main/flink-bin/LICENSE ---
@@ -254,20 +285,18 @@ under the Apache License (v 2.0):
The Apache Flink project bundles the following components under the MIT License:
- - SLF4J (http://www.slf4j.org) - Copyright (c) 2004-2013 QOS.ch
+ - SLF4J (org.slf4j:slf4j-api:1.7.7 - http://www.slf4j.org) - Copyright (c) 2004-2013 QOS.ch
+ - SLF4J-LOG4J Bridge (org.slf4j:slf4j-log4j12:1.7.7 - http://www.slf4j.org) - Copyright (c) 2004-2013 QOS.ch
- jQuery v2.1.0. (http://jquery.com) - Copyright 2014 jQuery Foundation and other contributors
- - jQuery resize event v1.1 (http://benalman.com/projects/jquery-resize-plugin/) - Copyright (c) 2010 "Cowboy" Ben Alman
--- End diff --
If this dependency is part of the source distribution (which I couldn't find) it shouldn't be removed.
If this dependency is not part of the source distribution but included in the binary distribution because it is a transitive dependency, then it shouldn't be removed.
In any other case, IMO it's ok to remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/830#issuecomment-111620221
Did a pass and other than small comments, LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/830#discussion_r32487493
--- Diff: flink-dist/src/main/flink-bin/LICENSE ---
@@ -254,20 +285,18 @@ under the Apache License (v 2.0):
The Apache Flink project bundles the following components under the MIT License:
- - SLF4J (http://www.slf4j.org) - Copyright (c) 2004-2013 QOS.ch
+ - SLF4J (org.slf4j:slf4j-api:1.7.7 - http://www.slf4j.org) - Copyright (c) 2004-2013 QOS.ch
+ - SLF4J-LOG4J Bridge (org.slf4j:slf4j-log4j12:1.7.7 - http://www.slf4j.org) - Copyright (c) 2004-2013 QOS.ch
- jQuery v2.1.0. (http://jquery.com) - Copyright 2014 jQuery Foundation and other contributors
- - jQuery resize event v1.1 (http://benalman.com/projects/jquery-resize-plugin/) - Copyright (c) 2010 "Cowboy" Ben Alman
--- End diff --
Same here, see above...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/830#discussion_r32452097
--- Diff: flink-dist/src/main/flink-bin/NOTICE ---
@@ -407,3 +391,86 @@ LongAdder), which was released with the following comments:
http://creativecommons.org/publicdomain/zero/1.0/
+-----------------------------------------------------------------------
+ Snappy-Java
+-----------------------------------------------------------------------
+
+This product includes software developed by Google
+ Snappy: http://code.google.com/p/snappy/ (New BSD License)
+
+This product includes software developed by Apache
+ PureJavaCrc32C from apache-hadoop-common http://hadoop.apache.org/
+ (Apache 2.0 license)
+
+This library containd statically linked libstdc++. This inclusion is allowed by
+"GCC RUntime Library Exception"
+http://gcc.gnu.org/onlinedocs/libstdc++/manual/license.html
+
+== Contributors ==
+ * Tatu Saloranta
+ * Providing benchmark suite
+ * Alec Wysoker
+ * Performance and memory usage improvement
+
+
+-----------------------------------------------------------------------
+ Apache Commmons Compress
+-----------------------------------------------------------------------
+
+Apache Commons Compress
+Copyright 2002-2015 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+The files in the package org.apache.commons.compress.archivers.sevenz
+were derived from the LZMA SDK, version 9.20 (C/ and CPP/7zip/),
+which has been placed in the public domain:
+
+"LZMA SDK is placed in the public domain." (http://www.7-zip.org/sdk.html)
+
+
+-----------------------------------------------------------------------
+ Httpclient
+-----------------------------------------------------------------------
+
+Apache HttpComponents Client
+Copyright 1999-2015 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+
+-----------------------------------------------------------------------
+ Httpcore
--- End diff --
Add update comment that should be ok to add it here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/830#discussion_r32500606
--- Diff: LICENSE ---
@@ -218,13 +218,9 @@ conditions of their respective licenses.
The Apache Flink project bundles the following files under the MIT License:
- jQuery v2.1.0. (http://jquery.com) - Copyright 2014 jQuery Foundation and other contributors
- - jQuery resize event v1.1 (http://benalman.com/projects/jquery-resize-plugin/) - Copyright (c) 2010 "Cowboy" Ben Alman
--- End diff --
Do you know which files include the jquery resize event?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/830#discussion_r32355306
--- Diff: flink-dist/src/main/flink-bin/NOTICE ---
@@ -407,3 +391,86 @@ LongAdder), which was released with the following comments:
http://creativecommons.org/publicdomain/zero/1.0/
+-----------------------------------------------------------------------
+ Snappy-Java
+-----------------------------------------------------------------------
+
+This product includes software developed by Google
+ Snappy: http://code.google.com/p/snappy/ (New BSD License)
+
+This product includes software developed by Apache
+ PureJavaCrc32C from apache-hadoop-common http://hadoop.apache.org/
+ (Apache 2.0 license)
+
+This library containd statically linked libstdc++. This inclusion is allowed by
+"GCC RUntime Library Exception"
+http://gcc.gnu.org/onlinedocs/libstdc++/manual/license.html
+
+== Contributors ==
+ * Tatu Saloranta
+ * Providing benchmark suite
+ * Alec Wysoker
+ * Performance and memory usage improvement
+
+
+-----------------------------------------------------------------------
+ Apache Commmons Compress
+-----------------------------------------------------------------------
+
+Apache Commons Compress
+Copyright 2002-2015 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+The files in the package org.apache.commons.compress.archivers.sevenz
+were derived from the LZMA SDK, version 9.20 (C/ and CPP/7zip/),
+which has been placed in the public domain:
+
+"LZMA SDK is placed in the public domain." (http://www.7-zip.org/sdk.html)
+
+
+-----------------------------------------------------------------------
--- End diff --
I don't think we need to include separate NOTICE section for another Apache projects. We could keep it but I think not necessary
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/830#discussion_r32332619
--- Diff: flink-dist/src/main/flink-bin/LICENSE ---
@@ -218,35 +218,66 @@ licenses.
The Apache Flink project bundles the following components
under the Apache License (v 2.0):
- - Apache Commons Logging (http://commons.apache.org/proper/commons-logging/)
- - Apache Commons Codec (http://commons.apache.org/proper/commons-codec/)
- - Apache Commons Collections (http://commons.apache.org/collections/)
- - Apache Commons CLI (http://commons.apache.org/cli/)
- - Apache Commons FileUpload (http://commons.apache.org/fileupload/)
- - Apache Commons IO (http://commons.apache.org/io/)
- - Apache Commons Lang 3 v.3.3.2 (http://commons.apache.org/proper/commons-lang/)
- - Apache Commons Math (http://commons.apache.org/proper/commons-math/)
- - Apache log4j 1.2 (http://logging.apache.org/log4j/1.2/)
- - Apache Avro v1.7.6 (http://avro.apache.org)
+ - Apache Commons Logging (commons-logging:commons-logging:1.1.1 - http://commons.apache.org/proper/commons-logging/)
+ - Apache Commons Codec (commons-codec:commons-codec:1.3 - http://commons.apache.org/proper/commons-codec/)
+ - Apache Commons Collections (commons-collections:commons-collections:3.2.1 - http://commons.apache.org/collections/)
+ - Apache Commons CLI (commons-cli:commons-cli:1.2 - http://commons.apache.org/cli/)
+ - Apache Commons FileUpload (commons-fileupload:commons-fileupload:1.3.1 - http://commons.apache.org/fileupload/)
+ - Apache Commons IO (commons-io:commons-io:2.4 - http://commons.apache.org/io/)
+ - Apache Commons Lang 3 (org.apache.commons:commons-lang3:3.3.2 - http://commons.apache.org/proper/commons-lang/)
+ - Apache Commons Math (org.apache.commons:commons-math:2.2 - http://commons.apache.org/proper/commons-math/)
+ - Apache Commons Compress (org.apache.commons:commons-compress:1.4.1 - http://commons.apache.org/proper/commons-compress/)
+ - Apache log4j (log4j:log4j:1.2.17 - http://logging.apache.org/log4j/1.2/)
+ - Apache Avro (org.apache.avro:avro:1.7.6 - http://avro.apache.org)
- Apache Hadoop (http://hadoop.apache.org)
--- End diff --
Technically, we don't include Hadoop any more in our binary distribution. The reason is, because it is contained in `org.apache.flink:flink-shaded-include-yarn` which contains the shaded Hadoop dependencies. Thus, what we actually have to include here is the `org.apache.flink:flink-shaded-include-yarn` dependency and add its NOTICE file to the NOTICE file of the binary distribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [legal] Updates LICENSE/NOTICE file of source ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/830#issuecomment-112497483
If there are no objections, I'd like to merge it this evening. Then we can create the next release candidate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---