[jira] [Commented] (PHOENIX-5922) IndexUpgradeTool should always re-enable tables on failure

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118258#comment-17118258 ] 

Hadoop QA commented on PHOENIX-5922:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/13004180/PHOENIX-5922-4.x.v1.patch
  against 4.x branch at commit 85724aae4bbe1420333a3301861668549a772c83.
  ATTACHMENT ID: 13004180

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +                SchemaUtil.getPhysicalHBaseTableName(SchemaUtil.getSchemaNameFromFullName(tableName),
+                    "Original exception that caused the rollback: [" + e.toString() + " " + "]", ex);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinLocalIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DropTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.txn.RollbackIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.tx.FlappingTransactionIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.SubqueryUsingSortMergeJoinIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.LocalImmutableNonTxIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.SortMergeJoinGlobalIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.util.IndexScrutinyIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3899//testReport/
Code Coverage results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3899//artifact/phoenix-core/target/site/jacoco/index.html
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3899//console

This message is automatically generated.

> IndexUpgradeTool should always re-enable tables on failure
> ----------------------------------------------------------
>
>                 Key: PHOENIX-5922
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5922
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Major
>         Attachments: PHOENIX-5922-4.x.v1.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> If an error occurs while doing an index upgrade, the IndexUpgradeTool will try to rollback the upgrade operations to leave the cluster in its initial state. However, if the rollback fails, it will give up. This can leave tables disabled for long periods until operators manually re-enable them.
> If rollback fails, the IndexUpgradeTool should always re-enable the affected tables at the HBase level.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)