You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Santhosh Srinivasan (JIRA)" <ji...@apache.org> on 2009/03/20 01:13:50 UTC
[jira] Created: (PIG-728) All backend error messages must be logged
to preserve the original error messages
All backend error messages must be logged to preserve the original error messages
---------------------------------------------------------------------------------
Key: PIG-728
URL: https://issues.apache.org/jira/browse/PIG-728
Project: Pig
Issue Type: Bug
Affects Versions: 1.0.1
Reporter: Santhosh Srinivasan
Assignee: Santhosh Srinivasan
Priority: Minor
Fix For: 1.0.1
The current error handling framework logs backend error messages only when Pig is not able to parse the error message. Instead, Pig should log the backend error message irrespective of Pig's ability to parse backend error messages. On a side note, the use of instantiateFuncFromSpec in Launcher.java is not consistent and should avoid the use of class_name + "(" + string_constructor_args + ")".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-728) All backend error messages must be logged
to preserve the original error messages
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santhosh Srinivasan updated PIG-728:
------------------------------------
Attachment: (was: PIG-728.patch)
> All backend error messages must be logged to preserve the original error messages
> ---------------------------------------------------------------------------------
>
> Key: PIG-728
> URL: https://issues.apache.org/jira/browse/PIG-728
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Priority: Minor
> Fix For: 0.4.0
>
>
> The current error handling framework logs backend error messages only when Pig is not able to parse the error message. Instead, Pig should log the backend error message irrespective of Pig's ability to parse backend error messages. On a side note, the use of instantiateFuncFromSpec in Launcher.java is not consistent and should avoid the use of class_name + "(" + string_constructor_args + ")".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-728) All backend error messages must be
logged to preserve the original error messages
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731760#action_12731760 ]
Hadoop QA commented on PIG-728:
-------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12413606/PIG-728.patch
against trunk revision 793750.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/127/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/127/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/127/console
This message is automatically generated.
> All backend error messages must be logged to preserve the original error messages
> ---------------------------------------------------------------------------------
>
> Key: PIG-728
> URL: https://issues.apache.org/jira/browse/PIG-728
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: PIG-728.patch
>
>
> The current error handling framework logs backend error messages only when Pig is not able to parse the error message. Instead, Pig should log the backend error message irrespective of Pig's ability to parse backend error messages. On a side note, the use of instantiateFuncFromSpec in Launcher.java is not consistent and should avoid the use of class_name + "(" + string_constructor_args + ")".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-728) All backend error messages must be
logged to preserve the original error messages
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732211#action_12732211 ]
Hadoop QA commented on PIG-728:
-------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12413711/PIG-728_1.patch
against trunk revision 793750.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/131/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/131/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/131/console
This message is automatically generated.
> All backend error messages must be logged to preserve the original error messages
> ---------------------------------------------------------------------------------
>
> Key: PIG-728
> URL: https://issues.apache.org/jira/browse/PIG-728
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: PIG-728_1.patch
>
>
> The current error handling framework logs backend error messages only when Pig is not able to parse the error message. Instead, Pig should log the backend error message irrespective of Pig's ability to parse backend error messages. On a side note, the use of instantiateFuncFromSpec in Launcher.java is not consistent and should avoid the use of class_name + "(" + string_constructor_args + ")".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-728) All backend error messages must be logged
to preserve the original error messages
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santhosh Srinivasan updated PIG-728:
------------------------------------
Status: In Progress (was: Patch Available)
> All backend error messages must be logged to preserve the original error messages
> ---------------------------------------------------------------------------------
>
> Key: PIG-728
> URL: https://issues.apache.org/jira/browse/PIG-728
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Priority: Minor
> Fix For: 0.4.0
>
>
> The current error handling framework logs backend error messages only when Pig is not able to parse the error message. Instead, Pig should log the backend error message irrespective of Pig's ability to parse backend error messages. On a side note, the use of instantiateFuncFromSpec in Launcher.java is not consistent and should avoid the use of class_name + "(" + string_constructor_args + ")".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-728) All backend error messages must be
logged to preserve the original error messages
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732281#action_12732281 ]
Santhosh Srinivasan commented on PIG-728:
-----------------------------------------
Patch has been committed.
> All backend error messages must be logged to preserve the original error messages
> ---------------------------------------------------------------------------------
>
> Key: PIG-728
> URL: https://issues.apache.org/jira/browse/PIG-728
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: PIG-728_1.patch
>
>
> The current error handling framework logs backend error messages only when Pig is not able to parse the error message. Instead, Pig should log the backend error message irrespective of Pig's ability to parse backend error messages. On a side note, the use of instantiateFuncFromSpec in Launcher.java is not consistent and should avoid the use of class_name + "(" + string_constructor_args + ")".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-728) All backend error messages must be logged
to preserve the original error messages
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santhosh Srinivasan updated PIG-728:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Issue has been resolved.
> All backend error messages must be logged to preserve the original error messages
> ---------------------------------------------------------------------------------
>
> Key: PIG-728
> URL: https://issues.apache.org/jira/browse/PIG-728
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: PIG-728_1.patch
>
>
> The current error handling framework logs backend error messages only when Pig is not able to parse the error message. Instead, Pig should log the backend error message irrespective of Pig's ability to parse backend error messages. On a side note, the use of instantiateFuncFromSpec in Launcher.java is not consistent and should avoid the use of class_name + "(" + string_constructor_args + ")".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-728) All backend error messages must be
logged to preserve the original error messages
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719617#action_12719617 ]
Santhosh Srinivasan commented on PIG-728:
-----------------------------------------
In addition, when the framework is not able to parse the error message, the message should be annotated as such. Extraneous details like "Unable to recreate exception", "Cannot create exception from empty string", etc should not be communicated to the user. These messages reflect internal workings of the error handling framework and do not add value to the user.
> All backend error messages must be logged to preserve the original error messages
> ---------------------------------------------------------------------------------
>
> Key: PIG-728
> URL: https://issues.apache.org/jira/browse/PIG-728
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.2.1
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Priority: Minor
> Fix For: 0.2.1
>
>
> The current error handling framework logs backend error messages only when Pig is not able to parse the error message. Instead, Pig should log the backend error message irrespective of Pig's ability to parse backend error messages. On a side note, the use of instantiateFuncFromSpec in Launcher.java is not consistent and should avoid the use of class_name + "(" + string_constructor_args + ")".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-728) All backend error messages must be logged
to preserve the original error messages
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santhosh Srinivasan updated PIG-728:
------------------------------------
Status: Patch Available (was: In Progress)
> All backend error messages must be logged to preserve the original error messages
> ---------------------------------------------------------------------------------
>
> Key: PIG-728
> URL: https://issues.apache.org/jira/browse/PIG-728
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: PIG-728_1.patch
>
>
> The current error handling framework logs backend error messages only when Pig is not able to parse the error message. Instead, Pig should log the backend error message irrespective of Pig's ability to parse backend error messages. On a side note, the use of instantiateFuncFromSpec in Launcher.java is not consistent and should avoid the use of class_name + "(" + string_constructor_args + ")".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-728) All backend error messages must be
logged to preserve the original error messages
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732493#action_12732493 ]
Hudson commented on PIG-728:
----------------------------
Integrated in Pig-trunk #506 (See [http://hudson.zones.apache.org/hudson/job/Pig-trunk/506/])
: All backend error messages must be logged to preserve the original error messages
> All backend error messages must be logged to preserve the original error messages
> ---------------------------------------------------------------------------------
>
> Key: PIG-728
> URL: https://issues.apache.org/jira/browse/PIG-728
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: PIG-728_1.patch
>
>
> The current error handling framework logs backend error messages only when Pig is not able to parse the error message. Instead, Pig should log the backend error message irrespective of Pig's ability to parse backend error messages. On a side note, the use of instantiateFuncFromSpec in Launcher.java is not consistent and should avoid the use of class_name + "(" + string_constructor_args + ")".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-728) All backend error messages must be logged
to preserve the original error messages
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santhosh Srinivasan updated PIG-728:
------------------------------------
Attachment: PIG-728.patch
The attached patch logs all backend error messages before Pig tries to parse the messages. In addition, the log format has been cleaned up to be more user friendly. No new test cases have been added.
> All backend error messages must be logged to preserve the original error messages
> ---------------------------------------------------------------------------------
>
> Key: PIG-728
> URL: https://issues.apache.org/jira/browse/PIG-728
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: PIG-728.patch
>
>
> The current error handling framework logs backend error messages only when Pig is not able to parse the error message. Instead, Pig should log the backend error message irrespective of Pig's ability to parse backend error messages. On a side note, the use of instantiateFuncFromSpec in Launcher.java is not consistent and should avoid the use of class_name + "(" + string_constructor_args + ")".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-728) All backend error messages must be
logged to preserve the original error messages
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732253#action_12732253 ]
Alan Gates commented on PIG-728:
--------------------------------
+1
> All backend error messages must be logged to preserve the original error messages
> ---------------------------------------------------------------------------------
>
> Key: PIG-728
> URL: https://issues.apache.org/jira/browse/PIG-728
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: PIG-728_1.patch
>
>
> The current error handling framework logs backend error messages only when Pig is not able to parse the error message. Instead, Pig should log the backend error message irrespective of Pig's ability to parse backend error messages. On a side note, the use of instantiateFuncFromSpec in Launcher.java is not consistent and should avoid the use of class_name + "(" + string_constructor_args + ")".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-728) All backend error messages must be logged
to preserve the original error messages
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santhosh Srinivasan updated PIG-728:
------------------------------------
Attachment: PIG-728_1.patch
Attaching a new patch that fixes the findbugs issue.
> All backend error messages must be logged to preserve the original error messages
> ---------------------------------------------------------------------------------
>
> Key: PIG-728
> URL: https://issues.apache.org/jira/browse/PIG-728
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: PIG-728_1.patch
>
>
> The current error handling framework logs backend error messages only when Pig is not able to parse the error message. Instead, Pig should log the backend error message irrespective of Pig's ability to parse backend error messages. On a side note, the use of instantiateFuncFromSpec in Launcher.java is not consistent and should avoid the use of class_name + "(" + string_constructor_args + ")".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-728) All backend error messages must be logged
to preserve the original error messages
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santhosh Srinivasan updated PIG-728:
------------------------------------
Fix Version/s: (was: 0.2.1)
0.4.0
Affects Version/s: (was: 0.2.1)
0.3.0
Status: Patch Available (was: Open)
> All backend error messages must be logged to preserve the original error messages
> ---------------------------------------------------------------------------------
>
> Key: PIG-728
> URL: https://issues.apache.org/jira/browse/PIG-728
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: PIG-728.patch
>
>
> The current error handling framework logs backend error messages only when Pig is not able to parse the error message. Instead, Pig should log the backend error message irrespective of Pig's ability to parse backend error messages. On a side note, the use of instantiateFuncFromSpec in Launcher.java is not consistent and should avoid the use of class_name + "(" + string_constructor_args + ")".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.